Change parameter to optional and add test #27693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
needs-triage
ewbankkit
removed
the
needs-triage
…and 'vpn_gateway_id'.
github-actions
bot
added
the
documentation
ewbankkit
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSiteVPNConnection_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccSiteVPNConnection_ -timeout 180m
=== RUN TestAccSiteVPNConnection_basic
=== PAUSE TestAccSiteVPNConnection_basic
=== RUN TestAccSiteVPNConnection_withoutTGWorVGW
=== PAUSE TestAccSiteVPNConnection_withoutTGWorVGW
=== RUN TestAccSiteVPNConnection_cloudWatchLogOptions
=== PAUSE TestAccSiteVPNConnection_cloudWatchLogOptions
=== RUN TestAccSiteVPNConnection_transitGatewayID
=== PAUSE TestAccSiteVPNConnection_transitGatewayID
=== RUN TestAccSiteVPNConnection_tunnel1InsideCIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideCIDR
=== RUN TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== RUN TestAccSiteVPNConnection_tunnel1PreSharedKey
=== PAUSE TestAccSiteVPNConnection_tunnel1PreSharedKey
=== RUN TestAccSiteVPNConnection_tunnelOptions
=== PAUSE TestAccSiteVPNConnection_tunnelOptions
=== RUN TestAccSiteVPNConnection_tunnelOptionsLesser
=== PAUSE TestAccSiteVPNConnection_tunnelOptionsLesser
=== RUN TestAccSiteVPNConnection_staticRoutes
=== PAUSE TestAccSiteVPNConnection_staticRoutes
=== RUN TestAccSiteVPNConnection_outsideAddressTypePrivate
=== PAUSE TestAccSiteVPNConnection_outsideAddressTypePrivate
=== RUN TestAccSiteVPNConnection_outsideAddressTypePublic
=== PAUSE TestAccSiteVPNConnection_outsideAddressTypePublic
=== RUN TestAccSiteVPNConnection_enableAcceleration
=== PAUSE TestAccSiteVPNConnection_enableAcceleration
=== RUN TestAccSiteVPNConnection_ipv6
=== PAUSE TestAccSiteVPNConnection_ipv6
=== RUN TestAccSiteVPNConnection_tags
=== PAUSE TestAccSiteVPNConnection_tags
=== RUN TestAccSiteVPNConnection_specifyIPv4
=== PAUSE TestAccSiteVPNConnection_specifyIPv4
=== RUN TestAccSiteVPNConnection_specifyIPv6
=== PAUSE TestAccSiteVPNConnection_specifyIPv6
=== RUN TestAccSiteVPNConnection_disappears
=== PAUSE TestAccSiteVPNConnection_disappears
=== RUN TestAccSiteVPNConnection_updateCustomerGatewayID
=== PAUSE TestAccSiteVPNConnection_updateCustomerGatewayID
=== RUN TestAccSiteVPNConnection_updateVPNGatewayID
=== PAUSE TestAccSiteVPNConnection_updateVPNGatewayID
=== RUN TestAccSiteVPNConnection_updateTransitGatewayID
=== PAUSE TestAccSiteVPNConnection_updateTransitGatewayID
=== RUN TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
=== PAUSE TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
=== RUN TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
=== PAUSE TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
=== CONT TestAccSiteVPNConnection_basic
=== CONT TestAccSiteVPNConnection_enableAcceleration
--- PASS: TestAccSiteVPNConnection_basic (203.81s)
=== CONT TestAccSiteVPNConnection_updateCustomerGatewayID
--- PASS: TestAccSiteVPNConnection_enableAcceleration (422.31s)
=== CONT TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
--- PASS: TestAccSiteVPNConnection_updateCustomerGatewayID (517.14s)
=== CONT TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
--- PASS: TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID (688.50s)
=== CONT TestAccSiteVPNConnection_updateTransitGatewayID
--- PASS: TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID (667.95s)
=== CONT TestAccSiteVPNConnection_updateVPNGatewayID
--- PASS: TestAccSiteVPNConnection_updateVPNGatewayID (479.12s)
=== CONT TestAccSiteVPNConnection_specifyIPv4
--- PASS: TestAccSiteVPNConnection_updateTransitGatewayID (767.89s)
=== CONT TestAccSiteVPNConnection_disappears
--- PASS: TestAccSiteVPNConnection_disappears (163.14s)
=== CONT TestAccSiteVPNConnection_specifyIPv6
--- PASS: TestAccSiteVPNConnection_specifyIPv4 (480.70s)
=== CONT TestAccSiteVPNConnection_tunnel1PreSharedKey
--- PASS: TestAccSiteVPNConnection_tunnel1PreSharedKey (196.19s)
=== CONT TestAccSiteVPNConnection_outsideAddressTypePublic
--- PASS: TestAccSiteVPNConnection_outsideAddressTypePublic (199.62s)
=== CONT TestAccSiteVPNConnection_outsideAddressTypePrivate
--- PASS: TestAccSiteVPNConnection_outsideAddressTypePrivate (1364.71s)
=== CONT TestAccSiteVPNConnection_staticRoutes
--- PASS: TestAccSiteVPNConnection_staticRoutes (196.63s)
=== CONT TestAccSiteVPNConnection_tunnelOptionsLesser
--- PASS: TestAccSiteVPNConnection_specifyIPv6 (372.31s)
=== CONT TestAccSiteVPNConnection_tunnelOptions
--- PASS: TestAccSiteVPNConnection_tunnelOptions (193.44s)
=== CONT TestAccSiteVPNConnection_transitGatewayID
--- PASS: TestAccSiteVPNConnection_transitGatewayID (441.43s)
=== CONT TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
--- PASS: TestAccSiteVPNConnection_tunnelOptionsLesser (1197.56s)
=== CONT TestAccSiteVPNConnection_tunnel1InsideCIDR
--- PASS: TestAccSiteVPNConnection_tunnel1InsideCIDR (192.98s)
=== CONT TestAccSiteVPNConnection_tags
--- PASS: TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR (451.89s)
=== CONT TestAccSiteVPNConnection_cloudWatchLogOptions
--- PASS: TestAccSiteVPNConnection_tags (221.64s)
=== CONT TestAccSiteVPNConnection_ipv6
--- PASS: TestAccSiteVPNConnection_cloudWatchLogOptions (520.53s)
=== CONT TestAccSiteVPNConnection_withoutTGWorVGW
--- PASS: TestAccSiteVPNConnection_withoutTGWorVGW (50.25s)
--- PASS: TestAccSiteVPNConnection_ipv6 (424.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 6348.610s
|
@juhala-aws Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change VPN connection parameters "transit_gateway_id" and "vpn_gateway_id" to optional. Before, one of these was required but AWS VPN API documentation states that these are optional and conflicting.
Relations
Relates #27387
References
AWS VPN API documentation https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVpnConnection.html.
Output from Acceptance Testing