-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3 datasource aws_s3_object can read application/xml #27704
s3 datasource aws_s3_object can read application/xml #27704
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @Ken-Sumi1019 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
d7c62e9
to
bb03b7f
Compare
I have noted the acceptance test results. |
bb03b7f
to
1fa3b44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T=TestAccS3ObjectDataSource K=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3ObjectDataSource' -timeout 180m
=== RUN TestAccS3ObjectDataSource_basic
=== PAUSE TestAccS3ObjectDataSource_basic
=== RUN TestAccS3ObjectDataSource_basicViaAccessPoint
=== PAUSE TestAccS3ObjectDataSource_basicViaAccessPoint
=== RUN TestAccS3ObjectDataSource_readableBody
=== PAUSE TestAccS3ObjectDataSource_readableBody
=== RUN TestAccS3ObjectDataSource_kmsEncrypted
=== PAUSE TestAccS3ObjectDataSource_kmsEncrypted
=== RUN TestAccS3ObjectDataSource_bucketKeyEnabled
=== PAUSE TestAccS3ObjectDataSource_bucketKeyEnabled
=== RUN TestAccS3ObjectDataSource_allParams
=== PAUSE TestAccS3ObjectDataSource_allParams
=== RUN TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== RUN TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== RUN TestAccS3ObjectDataSource_leadingSlash
=== PAUSE TestAccS3ObjectDataSource_leadingSlash
=== RUN TestAccS3ObjectDataSource_multipleSlashes
=== PAUSE TestAccS3ObjectDataSource_multipleSlashes
=== RUN TestAccS3ObjectDataSource_singleSlashAsKey
=== PAUSE TestAccS3ObjectDataSource_singleSlashAsKey
=== CONT TestAccS3ObjectDataSource_basic
=== CONT TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== CONT TestAccS3ObjectDataSource_singleSlashAsKey
=== CONT TestAccS3ObjectDataSource_leadingSlash
=== CONT TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== CONT TestAccS3ObjectDataSource_kmsEncrypted
=== CONT TestAccS3ObjectDataSource_readableBody
=== CONT TestAccS3ObjectDataSource_multipleSlashes
=== CONT TestAccS3ObjectDataSource_allParams
=== CONT TestAccS3ObjectDataSource_basicViaAccessPoint
=== CONT TestAccS3ObjectDataSource_bucketKeyEnabled
--- PASS: TestAccS3ObjectDataSource_singleSlashAsKey (26.71s)
--- PASS: TestAccS3ObjectDataSource_readableBody (28.97s)
--- PASS: TestAccS3ObjectDataSource_basic (29.00s)
--- PASS: TestAccS3ObjectDataSource_bucketKeyEnabled (29.27s)
--- PASS: TestAccS3ObjectDataSource_basicViaAccessPoint (30.16s)
--- PASS: TestAccS3ObjectDataSource_kmsEncrypted (30.41s)
--- PASS: TestAccS3ObjectDataSource_allParams (32.44s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOff (32.62s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOn (33.44s)
--- PASS: TestAccS3ObjectDataSource_leadingSlash (43.38s)
--- PASS: TestAccS3ObjectDataSource_multipleSlashes (44.41s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 46.331s
% make t T=TestAccS3BucketObjectDataSource K=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketObjectDataSource' -timeout 180m
=== RUN TestAccS3BucketObjectDataSource_basic
=== PAUSE TestAccS3BucketObjectDataSource_basic
=== RUN TestAccS3BucketObjectDataSource_basicViaAccessPoint
=== PAUSE TestAccS3BucketObjectDataSource_basicViaAccessPoint
=== RUN TestAccS3BucketObjectDataSource_readableBody
=== PAUSE TestAccS3BucketObjectDataSource_readableBody
=== RUN TestAccS3BucketObjectDataSource_kmsEncrypted
=== PAUSE TestAccS3BucketObjectDataSource_kmsEncrypted
=== RUN TestAccS3BucketObjectDataSource_bucketKeyEnabled
=== PAUSE TestAccS3BucketObjectDataSource_bucketKeyEnabled
=== RUN TestAccS3BucketObjectDataSource_allParams
=== PAUSE TestAccS3BucketObjectDataSource_allParams
=== RUN TestAccS3BucketObjectDataSource_objectLockLegalHoldOff
=== PAUSE TestAccS3BucketObjectDataSource_objectLockLegalHoldOff
=== RUN TestAccS3BucketObjectDataSource_objectLockLegalHoldOn
=== PAUSE TestAccS3BucketObjectDataSource_objectLockLegalHoldOn
=== RUN TestAccS3BucketObjectDataSource_leadingSlash
=== PAUSE TestAccS3BucketObjectDataSource_leadingSlash
=== RUN TestAccS3BucketObjectDataSource_multipleSlashes
=== PAUSE TestAccS3BucketObjectDataSource_multipleSlashes
=== RUN TestAccS3BucketObjectDataSource_singleSlashAsKey
=== PAUSE TestAccS3BucketObjectDataSource_singleSlashAsKey
=== CONT TestAccS3BucketObjectDataSource_basic
=== CONT TestAccS3BucketObjectDataSource_objectLockLegalHoldOff
=== CONT TestAccS3BucketObjectDataSource_kmsEncrypted
=== CONT TestAccS3BucketObjectDataSource_singleSlashAsKey
=== CONT TestAccS3BucketObjectDataSource_basicViaAccessPoint
=== CONT TestAccS3BucketObjectDataSource_multipleSlashes
=== CONT TestAccS3BucketObjectDataSource_allParams
=== CONT TestAccS3BucketObjectDataSource_bucketKeyEnabled
=== CONT TestAccS3BucketObjectDataSource_readableBody
=== CONT TestAccS3BucketObjectDataSource_leadingSlash
=== CONT TestAccS3BucketObjectDataSource_objectLockLegalHoldOn
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (27.35s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (27.96s)
--- PASS: TestAccS3BucketObjectDataSource_basic (29.38s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (29.53s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (30.58s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (30.65s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (32.26s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (32.82s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (32.89s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (43.65s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (44.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 46.391s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T=TestAccS3ObjectDataSource K=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3ObjectDataSource' -timeout 180m
=== RUN TestAccS3ObjectDataSource_basic
=== PAUSE TestAccS3ObjectDataSource_basic
=== RUN TestAccS3ObjectDataSource_basicViaAccessPoint
=== PAUSE TestAccS3ObjectDataSource_basicViaAccessPoint
=== RUN TestAccS3ObjectDataSource_readableBody
=== PAUSE TestAccS3ObjectDataSource_readableBody
=== RUN TestAccS3ObjectDataSource_kmsEncrypted
=== PAUSE TestAccS3ObjectDataSource_kmsEncrypted
=== RUN TestAccS3ObjectDataSource_bucketKeyEnabled
=== PAUSE TestAccS3ObjectDataSource_bucketKeyEnabled
=== RUN TestAccS3ObjectDataSource_allParams
=== PAUSE TestAccS3ObjectDataSource_allParams
=== RUN TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== RUN TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== PAUSE TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== RUN TestAccS3ObjectDataSource_leadingSlash
=== PAUSE TestAccS3ObjectDataSource_leadingSlash
=== RUN TestAccS3ObjectDataSource_multipleSlashes
=== PAUSE TestAccS3ObjectDataSource_multipleSlashes
=== RUN TestAccS3ObjectDataSource_singleSlashAsKey
=== PAUSE TestAccS3ObjectDataSource_singleSlashAsKey
=== CONT TestAccS3ObjectDataSource_basic
=== CONT TestAccS3ObjectDataSource_objectLockLegalHoldOff
=== CONT TestAccS3ObjectDataSource_singleSlashAsKey
=== CONT TestAccS3ObjectDataSource_leadingSlash
=== CONT TestAccS3ObjectDataSource_objectLockLegalHoldOn
=== CONT TestAccS3ObjectDataSource_kmsEncrypted
=== CONT TestAccS3ObjectDataSource_readableBody
=== CONT TestAccS3ObjectDataSource_multipleSlashes
=== CONT TestAccS3ObjectDataSource_allParams
=== CONT TestAccS3ObjectDataSource_basicViaAccessPoint
=== CONT TestAccS3ObjectDataSource_bucketKeyEnabled
--- PASS: TestAccS3ObjectDataSource_singleSlashAsKey (26.71s)
--- PASS: TestAccS3ObjectDataSource_readableBody (28.97s)
--- PASS: TestAccS3ObjectDataSource_basic (29.00s)
--- PASS: TestAccS3ObjectDataSource_bucketKeyEnabled (29.27s)
--- PASS: TestAccS3ObjectDataSource_basicViaAccessPoint (30.16s)
--- PASS: TestAccS3ObjectDataSource_kmsEncrypted (30.41s)
--- PASS: TestAccS3ObjectDataSource_allParams (32.44s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOff (32.62s)
--- PASS: TestAccS3ObjectDataSource_objectLockLegalHoldOn (33.44s)
--- PASS: TestAccS3ObjectDataSource_leadingSlash (43.38s)
--- PASS: TestAccS3ObjectDataSource_multipleSlashes (44.41s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 46.331s
% make t T=TestAccS3BucketObjectDataSource K=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketObjectDataSource' -timeout 180m
=== RUN TestAccS3BucketObjectDataSource_basic
=== PAUSE TestAccS3BucketObjectDataSource_basic
=== RUN TestAccS3BucketObjectDataSource_basicViaAccessPoint
=== PAUSE TestAccS3BucketObjectDataSource_basicViaAccessPoint
=== RUN TestAccS3BucketObjectDataSource_readableBody
=== PAUSE TestAccS3BucketObjectDataSource_readableBody
=== RUN TestAccS3BucketObjectDataSource_kmsEncrypted
=== PAUSE TestAccS3BucketObjectDataSource_kmsEncrypted
=== RUN TestAccS3BucketObjectDataSource_bucketKeyEnabled
=== PAUSE TestAccS3BucketObjectDataSource_bucketKeyEnabled
=== RUN TestAccS3BucketObjectDataSource_allParams
=== PAUSE TestAccS3BucketObjectDataSource_allParams
=== RUN TestAccS3BucketObjectDataSource_objectLockLegalHoldOff
=== PAUSE TestAccS3BucketObjectDataSource_objectLockLegalHoldOff
=== RUN TestAccS3BucketObjectDataSource_objectLockLegalHoldOn
=== PAUSE TestAccS3BucketObjectDataSource_objectLockLegalHoldOn
=== RUN TestAccS3BucketObjectDataSource_leadingSlash
=== PAUSE TestAccS3BucketObjectDataSource_leadingSlash
=== RUN TestAccS3BucketObjectDataSource_multipleSlashes
=== PAUSE TestAccS3BucketObjectDataSource_multipleSlashes
=== RUN TestAccS3BucketObjectDataSource_singleSlashAsKey
=== PAUSE TestAccS3BucketObjectDataSource_singleSlashAsKey
=== CONT TestAccS3BucketObjectDataSource_basic
=== CONT TestAccS3BucketObjectDataSource_objectLockLegalHoldOff
=== CONT TestAccS3BucketObjectDataSource_kmsEncrypted
=== CONT TestAccS3BucketObjectDataSource_singleSlashAsKey
=== CONT TestAccS3BucketObjectDataSource_basicViaAccessPoint
=== CONT TestAccS3BucketObjectDataSource_multipleSlashes
=== CONT TestAccS3BucketObjectDataSource_allParams
=== CONT TestAccS3BucketObjectDataSource_bucketKeyEnabled
=== CONT TestAccS3BucketObjectDataSource_readableBody
=== CONT TestAccS3BucketObjectDataSource_leadingSlash
=== CONT TestAccS3BucketObjectDataSource_objectLockLegalHoldOn
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (27.35s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (27.96s)
--- PASS: TestAccS3BucketObjectDataSource_basic (29.38s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (29.53s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (30.58s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (30.65s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (32.26s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (32.82s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (32.89s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (43.65s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (44.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 46.391s
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This fix allows datasource aws_s3_object to read application/xml.
Relations
Closes #27697
References
Output from Acceptance Testing