Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_schemas_registry_policy: new resource #27705

Merged
merged 6 commits into from
Nov 17, 2022
Merged

r/aws_schemas_registry_policy: new resource #27705

merged 6 commits into from
Nov 17, 2022

Conversation

georgealton
Copy link
Contributor

@georgealton georgealton commented Nov 8, 2022

Description

Adds a new resource aws_schemas_registry_policy for creating AWS EventBridge Schema Registry Resource Policies.

Relations

Closes #20831

References

https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-resource-based-schemas.html

Output from Acceptance Testing

make testacc TF_DEBUG=1 TESTS='TestAccSchemasRegistryPolicy' PKG=schemas
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/schemas/... -v -count 1 -parallel 20 -run='TestAccSchemasRegistryPolicy'  -timeout 180m
=== RUN   TestAccSchemasRegistryPolicy_basic
=== PAUSE TestAccSchemasRegistryPolicy_basic
=== RUN   TestAccSchemasRegistryPolicy_disappears
=== PAUSE TestAccSchemasRegistryPolicy_disappears
=== RUN   TestAccSchemasRegistryPolicy_disappears_Registry
=== PAUSE TestAccSchemasRegistryPolicy_disappears_Registry
=== RUN   TestAccSchemasRegistryPolicy_Policy
=== PAUSE TestAccSchemasRegistryPolicy_Policy
=== CONT  TestAccSchemasRegistryPolicy_basic
=== CONT  TestAccSchemasRegistryPolicy_disappears_Registry
=== CONT  TestAccSchemasRegistryPolicy_Policy
=== CONT  TestAccSchemasRegistryPolicy_disappears
--- PASS: TestAccSchemasRegistryPolicy_disappears (71.13s)
--- PASS: TestAccSchemasRegistryPolicy_disappears_Registry (73.10s)
--- PASS: TestAccSchemasRegistryPolicy_basic (83.27s)
--- PASS: TestAccSchemasRegistryPolicy_Policy (113.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	117.786s
...

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/schemas Issues and PRs that pertain to the schemas service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 8, 2022
@georgealton georgealton changed the title wip [WIP] Event Schema Registry Resource Policy Nov 8, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Nov 8, 2022
@georgealton georgealton changed the title [WIP] Event Schema Registry Resource Policy [WIP] r/aws_schemas_registry_policy Nov 9, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 9, 2022
@georgealton georgealton changed the title [WIP] r/aws_schemas_registry_policy r/aws_schemas_registry_policy Nov 10, 2022
@georgealton georgealton changed the title r/aws_schemas_registry_policy r/aws_schemas_registry_policy: new resource Nov 10, 2022
@georgealton georgealton marked this pull request as ready for review November 10, 2022 14:58
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 17, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSchemasRegistryPolicy_' PKG=schemas ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/schemas/... -v -count 1 -parallel 2  -run=TestAccSchemasRegistryPolicy_ -timeout 180m
=== RUN   TestAccSchemasRegistryPolicy_basic
=== PAUSE TestAccSchemasRegistryPolicy_basic
=== RUN   TestAccSchemasRegistryPolicy_disappears
=== PAUSE TestAccSchemasRegistryPolicy_disappears
=== RUN   TestAccSchemasRegistryPolicy_disappears_Registry
=== PAUSE TestAccSchemasRegistryPolicy_disappears_Registry
=== RUN   TestAccSchemasRegistryPolicy_Policy
=== PAUSE TestAccSchemasRegistryPolicy_Policy
=== CONT  TestAccSchemasRegistryPolicy_basic
=== CONT  TestAccSchemasRegistryPolicy_disappears_Registry
--- PASS: TestAccSchemasRegistryPolicy_disappears_Registry (22.62s)
=== CONT  TestAccSchemasRegistryPolicy_disappears
--- PASS: TestAccSchemasRegistryPolicy_basic (28.42s)
=== CONT  TestAccSchemasRegistryPolicy_Policy
--- PASS: TestAccSchemasRegistryPolicy_disappears (19.62s)
--- PASS: TestAccSchemasRegistryPolicy_Policy (38.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	73.356s

@ewbankkit
Copy link
Contributor

@georgealton Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2978a05 into hashicorp:main Nov 17, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 17, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@georgealton georgealton deleted the f-schemas-registry-policy branch December 6, 2022 00:08
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/schemas Issues and PRs that pertain to the schemas service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Amazon EventBridge Schema Registry Resource-based policy
2 participants