-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: aws_ivs_recording_configuration #27718
new resource: aws_ivs_recording_configuration #27718
Conversation
Community NoteVoting for Prioritization
For Submitters
|
- Prefer AWS Go SDK pointer conversion functions for dereferencing
- Use spaces instead of tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some general implementation questions as comments. Please take a look.
- Prefer AWS Go SDK pointer conversion functions for dereferencing - Use AWS Go SDK state constants for Recording Configuration state
- Use AWS Go SDK state constants for Recording Configuration state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIVSRecordingConfiguration_' PKG=ivs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivs/... -v -count 1 -parallel 2 -run=TestAccIVSRecordingConfiguration_ -timeout 180m
=== RUN TestAccIVSRecordingConfiguration_basic
=== PAUSE TestAccIVSRecordingConfiguration_basic
=== RUN TestAccIVSRecordingConfiguration_update
=== PAUSE TestAccIVSRecordingConfiguration_update
=== RUN TestAccIVSRecordingConfiguration_disappears
=== PAUSE TestAccIVSRecordingConfiguration_disappears
=== RUN TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== PAUSE TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== RUN TestAccIVSRecordingConfiguration_tags
=== PAUSE TestAccIVSRecordingConfiguration_tags
=== CONT TestAccIVSRecordingConfiguration_basic
=== CONT TestAccIVSRecordingConfiguration_disappears_S3Bucket
--- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (24.02s)
=== CONT TestAccIVSRecordingConfiguration_disappears
--- PASS: TestAccIVSRecordingConfiguration_basic (28.78s)
=== CONT TestAccIVSRecordingConfiguration_update
--- PASS: TestAccIVSRecordingConfiguration_disappears (22.39s)
=== CONT TestAccIVSRecordingConfiguration_tags
--- PASS: TestAccIVSRecordingConfiguration_update (50.66s)
--- PASS: TestAccIVSRecordingConfiguration_tags (66.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ivs 117.950s
@KevinEady Thanks for the contribution 🎉 👏. |
Thanks for the review @ewbankkit ! Tomorrow I'll post the next PR in the series for the Channel resource. |
This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add new resource for AWS IVS Recording Configuration: aws_ivs_recording_configuration. This PR is the second in a set to support the full AWS IVS entities:
Playback Key PairRelations
Relates #17272
Output from Acceptance Testing