Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: aws_ivs_recording_configuration #27718

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

KevinEady
Copy link
Contributor

@KevinEady KevinEady commented Nov 9, 2022

Description

Add new resource for AWS IVS Recording Configuration: aws_ivs_recording_configuration. This PR is the second in a set to support the full AWS IVS entities:

  1. Playback Key Pair
  2. Recording Configuration
  3. Channel
  4. Stream Key

Relations

Relates #17272

Output from Acceptance Testing

$ make testacc TESTS=TestAccIVSRecordingConfiguration_ PKG=ivs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 /Users/eakevinh/go/bin/go1.18.4 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSRecordingConfiguration_'  -timeout 180m
=== RUN   TestAccIVSRecordingConfiguration_basic
=== PAUSE TestAccIVSRecordingConfiguration_basic
=== RUN   TestAccIVSRecordingConfiguration_update
=== PAUSE TestAccIVSRecordingConfiguration_update
=== RUN   TestAccIVSRecordingConfiguration_disappears
=== PAUSE TestAccIVSRecordingConfiguration_disappears
=== RUN   TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== PAUSE TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== RUN   TestAccIVSRecordingConfiguration_tags
=== PAUSE TestAccIVSRecordingConfiguration_tags
=== CONT  TestAccIVSRecordingConfiguration_basic
=== CONT  TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== CONT  TestAccIVSRecordingConfiguration_disappears
=== CONT  TestAccIVSRecordingConfiguration_tags
=== CONT  TestAccIVSRecordingConfiguration_update
--- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (39.73s)
--- PASS: TestAccIVSRecordingConfiguration_disappears (43.56s)
--- PASS: TestAccIVSRecordingConfiguration_basic (49.20s)
--- PASS: TestAccIVSRecordingConfiguration_update (83.09s)
--- PASS: TestAccIVSRecordingConfiguration_tags (108.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivs        110.759s

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivs Issues and PRs that pertain to the ivs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2022
Kevin Eady added 3 commits November 9, 2022 12:17
- Prefer AWS Go SDK pointer conversion functions for dereferencing
- Use spaces instead of tabs
@KevinEady KevinEady marked this pull request as ready for review November 9, 2022 12:00
Copy link
Contributor Author

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some general implementation questions as comments. Please take a look.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 9, 2022
Kevin Eady added 2 commits November 9, 2022 16:29
- Prefer AWS Go SDK pointer conversion functions for dereferencing
- Use AWS Go SDK state constants for Recording Configuration state
- Use AWS Go SDK state constants for Recording Configuration state
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Nov 9, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIVSRecordingConfiguration_' PKG=ivs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivs/... -v -count 1 -parallel 2  -run=TestAccIVSRecordingConfiguration_ -timeout 180m
=== RUN   TestAccIVSRecordingConfiguration_basic
=== PAUSE TestAccIVSRecordingConfiguration_basic
=== RUN   TestAccIVSRecordingConfiguration_update
=== PAUSE TestAccIVSRecordingConfiguration_update
=== RUN   TestAccIVSRecordingConfiguration_disappears
=== PAUSE TestAccIVSRecordingConfiguration_disappears
=== RUN   TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== PAUSE TestAccIVSRecordingConfiguration_disappears_S3Bucket
=== RUN   TestAccIVSRecordingConfiguration_tags
=== PAUSE TestAccIVSRecordingConfiguration_tags
=== CONT  TestAccIVSRecordingConfiguration_basic
=== CONT  TestAccIVSRecordingConfiguration_disappears_S3Bucket
--- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (24.02s)
=== CONT  TestAccIVSRecordingConfiguration_disappears
--- PASS: TestAccIVSRecordingConfiguration_basic (28.78s)
=== CONT  TestAccIVSRecordingConfiguration_update
--- PASS: TestAccIVSRecordingConfiguration_disappears (22.39s)
=== CONT  TestAccIVSRecordingConfiguration_tags
--- PASS: TestAccIVSRecordingConfiguration_update (50.66s)
--- PASS: TestAccIVSRecordingConfiguration_tags (66.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ivs	117.950s

@ewbankkit
Copy link
Contributor

@KevinEady Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 84a4f15 into hashicorp:main Nov 9, 2022
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 9, 2022
@KevinEady
Copy link
Contributor Author

Thanks for the review @ewbankkit ! Tomorrow I'll post the next PR in the series for the Channel resource.

@KevinEady KevinEady deleted the f-ivs-recording_configuration branch November 9, 2022 16:54
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivs Issues and PRs that pertain to the ivs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants