-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi_party_conference_enabled to aws_connect_instance #27734
Add multi_party_conference_enabled to aws_connect_instance #27734
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccConnect_serial/Instance/basic' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccConnect_serial/Instance/basic -timeout 180m
=== RUN TestAccConnect_serial
=== RUN TestAccConnect_serial/Instance
=== RUN TestAccConnect_serial/Instance/basic
=== RUN TestAccConnect_serial/Instance/dataSource_basic
=== RUN TestAccConnect_serial/InstanceStorageConfig
=== RUN TestAccConnect_serial/InstanceStorageConfig/basic
--- PASS: TestAccConnect_serial (320.27s)
--- PASS: TestAccConnect_serial/Instance (231.07s)
--- PASS: TestAccConnect_serial/Instance/basic (106.46s)
--- PASS: TestAccConnect_serial/Instance/dataSource_basic (124.61s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig (89.20s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/basic (89.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 324.742s
@schuylr Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add the
multi_party_conference_enabled
argument to theaws_connect_instance
resource, as well as themulti_party_conference_enabled
attribute to the same data source.Relations
Closes #27728
References
https://docs.aws.amazon.com/connect/latest/adminguide/multi-party-calls.html
https://docs.aws.amazon.com/connect/latest/APIReference/API_UpdateInstanceAttribute.html
Output from Acceptance Testing