-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_docdb_cluster_instance Add enable_performance_insights & performance_insights_kms_key_id argument #27769
aws_docdb_cluster_instance Add enable_performance_insights & performance_insights_kms_key_id argument #27769
Conversation
…rovider-aws into docdb-performance-insights
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDocDBClusterInstance_basic\|TestAccDocDBClusterInstance_performanceInsights' PKG=docdb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 2 -run=TestAccDocDBClusterInstance_basic\|TestAccDocDBClusterInstance_performanceInsights -timeout 180m
=== RUN TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== RUN TestAccDocDBClusterInstance_performanceInsights
=== PAUSE TestAccDocDBClusterInstance_performanceInsights
=== CONT TestAccDocDBClusterInstance_basic
=== CONT TestAccDocDBClusterInstance_performanceInsights
--- PASS: TestAccDocDBClusterInstance_basic (763.24s)
--- PASS: TestAccDocDBClusterInstance_performanceInsights (804.09s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/docdb 810.762s
@adamstirk-ct Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
PR #24948 seems to be abandoned, I've taken the code by @meetreks and completed the remaining issues
This PR adds
enable_performance_insights
andperformance_insights_kms_key_id
argumentRelations
Closes #24948
Closes #24857
References
Output from Acceptance Testing