Add support for key_algorithm in aws_acm_certificate resource

[JamesJJ]

Description

Support specifying the key algorithm when requesting ACM certificates. Enables requesting certificates with ECDSA algorithms.

Relations

Relates #27715

References

• https://aws.amazon.com/about-aws/whats-new/2022/11/aws-certificate-manager-elliptic-curve-digital-signature-algorithm-tls-certificates/
• https://docs.aws.amazon.com/acm/latest/userguide/acm-certificate.html#algorithms

Output from Acceptance Testing

$ ACM_CERTIFICATE_ROOT_DOMAIN=beta-env.idv.tw make testacc TESTS='TestAccACMCertificate_(root|keyAlgorithm)' PKG=acm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 20 -run='TestAccACMCertificate_(root|keyAlgorithm)'  -timeout 180m
=== RUN   TestAccACMCertificate_root
=== PAUSE TestAccACMCertificate_root
=== RUN   TestAccACMCertificate_rootAndWildcardSan
=== PAUSE TestAccACMCertificate_rootAndWildcardSan
=== RUN   TestAccACMCertificate_keyAlgorithm
=== PAUSE TestAccACMCertificate_keyAlgorithm
=== CONT  TestAccACMCertificate_root
=== CONT  TestAccACMCertificate_keyAlgorithm
=== CONT  TestAccACMCertificate_rootAndWildcardSan
--- PASS: TestAccACMCertificate_keyAlgorithm (42.44s)
--- PASS: TestAccACMCertificate_root (43.58s)
--- PASS: TestAccACMCertificate_rootAndWildcardSan (46.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	48.472s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTS='TestAccACMCertificate_' PKG=acm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 2 -run='TestAccACMCertificate_'  -timeout 180m
=== RUN   TestAccACMCertificate_emailValidation
=== PAUSE TestAccACMCertificate_emailValidation
=== RUN   TestAccACMCertificate_dnsValidation
=== PAUSE TestAccACMCertificate_dnsValidation
=== RUN   TestAccACMCertificate_root
=== PAUSE TestAccACMCertificate_root
=== RUN   TestAccACMCertificate_validationOptions
=== PAUSE TestAccACMCertificate_validationOptions
=== RUN   TestAccACMCertificate_privateCertificate_renewable
=== PAUSE TestAccACMCertificate_privateCertificate_renewable
=== RUN   TestAccACMCertificate_privateCertificate_noRenewalPermission
=== PAUSE TestAccACMCertificate_privateCertificate_noRenewalPermission
=== RUN   TestAccACMCertificate_privateCertificate_pendingRenewalGoDuration
=== PAUSE TestAccACMCertificate_privateCertificate_pendingRenewalGoDuration
=== RUN   TestAccACMCertificate_privateCertificate_pendingRenewalRFC3339Duration
=== PAUSE TestAccACMCertificate_privateCertificate_pendingRenewalRFC3339Duration
=== RUN   TestAccACMCertificate_privateCertificate_addEarlyRenewalPast
=== PAUSE TestAccACMCertificate_privateCertificate_addEarlyRenewalPast
=== RUN   TestAccACMCertificate_privateCertificate_addEarlyRenewalPastIneligible
=== PAUSE TestAccACMCertificate_privateCertificate_addEarlyRenewalPastIneligible
=== RUN   TestAccACMCertificate_privateCertificate_addEarlyRenewalFuture
=== PAUSE TestAccACMCertificate_privateCertificate_addEarlyRenewalFuture
=== RUN   TestAccACMCertificate_privateCertificate_updateEarlyRenewalFuture
=== PAUSE TestAccACMCertificate_privateCertificate_updateEarlyRenewalFuture
=== RUN   TestAccACMCertificate_privateCertificate_removeEarlyRenewal
=== PAUSE TestAccACMCertificate_privateCertificate_removeEarlyRenewal
=== RUN   TestAccACMCertificate_Root_trailingPeriod
=== PAUSE TestAccACMCertificate_Root_trailingPeriod
=== RUN   TestAccACMCertificate_rootAndWildcardSan
=== PAUSE TestAccACMCertificate_rootAndWildcardSan
=== RUN   TestAccACMCertificate_SubjectAlternativeNames_emptyString
=== PAUSE TestAccACMCertificate_SubjectAlternativeNames_emptyString
=== RUN   TestAccACMCertificate_San_single
=== PAUSE TestAccACMCertificate_San_single
=== RUN   TestAccACMCertificate_San_multiple
=== PAUSE TestAccACMCertificate_San_multiple
=== RUN   TestAccACMCertificate_San_trailingPeriod
=== PAUSE TestAccACMCertificate_San_trailingPeriod
=== RUN   TestAccACMCertificate_San_matches_domain
=== PAUSE TestAccACMCertificate_San_matches_domain
=== RUN   TestAccACMCertificate_wildcard
=== PAUSE TestAccACMCertificate_wildcard
=== RUN   TestAccACMCertificate_wildcardAndRootSan
=== PAUSE TestAccACMCertificate_wildcardAndRootSan
=== RUN   TestAccACMCertificate_keyAlgorithm
=== PAUSE TestAccACMCertificate_keyAlgorithm
=== RUN   TestAccACMCertificate_disableCTLogging
=== PAUSE TestAccACMCertificate_disableCTLogging
=== RUN   TestAccACMCertificate_Imported_domainName
=== PAUSE TestAccACMCertificate_Imported_domainName
=== RUN   TestAccACMCertificate_Imported_validityDates
=== PAUSE TestAccACMCertificate_Imported_validityDates
=== RUN   TestAccACMCertificate_Imported_ipAddress
=== PAUSE TestAccACMCertificate_Imported_ipAddress
=== RUN   TestAccACMCertificate_PrivateKey_tags
=== PAUSE TestAccACMCertificate_PrivateKey_tags
=== CONT  TestAccACMCertificate_emailValidation
=== CONT  TestAccACMCertificate_rootAndWildcardSan
--- PASS: TestAccACMCertificate_rootAndWildcardSan (30.35s)
=== CONT  TestAccACMCertificate_wildcardAndRootSan
--- PASS: TestAccACMCertificate_emailValidation (34.13s)
=== CONT  TestAccACMCertificate_PrivateKey_tags
--- PASS: TestAccACMCertificate_wildcardAndRootSan (27.81s)
=== CONT  TestAccACMCertificate_Imported_ipAddress
--- PASS: TestAccACMCertificate_Imported_ipAddress (20.20s)
=== CONT  TestAccACMCertificate_Imported_validityDates
--- PASS: TestAccACMCertificate_PrivateKey_tags (61.64s)
=== CONT  TestAccACMCertificate_Imported_domainName
--- PASS: TestAccACMCertificate_Imported_validityDates (19.87s)
=== CONT  TestAccACMCertificate_disableCTLogging
--- PASS: TestAccACMCertificate_disableCTLogging (27.86s)
=== CONT  TestAccACMCertificate_keyAlgorithm
--- PASS: TestAccACMCertificate_Imported_domainName (53.52s)
=== CONT  TestAccACMCertificate_privateCertificate_pendingRenewalRFC3339Duration
--- PASS: TestAccACMCertificate_keyAlgorithm (27.21s)
=== CONT  TestAccACMCertificate_Root_trailingPeriod
--- PASS: TestAccACMCertificate_Root_trailingPeriod (1.52s)
=== CONT  TestAccACMCertificate_privateCertificate_removeEarlyRenewal
--- PASS: TestAccACMCertificate_privateCertificate_removeEarlyRenewal (64.69s)
=== CONT  TestAccACMCertificate_privateCertificate_updateEarlyRenewalFuture
--- PASS: TestAccACMCertificate_privateCertificate_pendingRenewalRFC3339Duration (91.34s)
=== CONT  TestAccACMCertificate_privateCertificate_addEarlyRenewalFuture
--- PASS: TestAccACMCertificate_privateCertificate_updateEarlyRenewalFuture (66.98s)
=== CONT  TestAccACMCertificate_privateCertificate_addEarlyRenewalPastIneligible
--- PASS: TestAccACMCertificate_privateCertificate_addEarlyRenewalFuture (78.45s)
=== CONT  TestAccACMCertificate_privateCertificate_addEarlyRenewalPast
--- PASS: TestAccACMCertificate_privateCertificate_addEarlyRenewalPastIneligible (58.22s)
=== CONT  TestAccACMCertificate_privateCertificate_renewable
--- PASS: TestAccACMCertificate_privateCertificate_addEarlyRenewalPast (105.46s)
=== CONT  TestAccACMCertificate_privateCertificate_pendingRenewalGoDuration
--- PASS: TestAccACMCertificate_privateCertificate_renewable (104.07s)
=== CONT  TestAccACMCertificate_privateCertificate_noRenewalPermission
--- PASS: TestAccACMCertificate_privateCertificate_pendingRenewalGoDuration (96.30s)
=== CONT  TestAccACMCertificate_San_single
--- PASS: TestAccACMCertificate_San_single (34.06s)
=== CONT  TestAccACMCertificate_San_multiple
--- PASS: TestAccACMCertificate_San_multiple (33.51s)
=== CONT  TestAccACMCertificate_SubjectAlternativeNames_emptyString
--- PASS: TestAccACMCertificate_SubjectAlternativeNames_emptyString (1.86s)
=== CONT  TestAccACMCertificate_root
--- PASS: TestAccACMCertificate_privateCertificate_noRenewalPermission (167.87s)
=== CONT  TestAccACMCertificate_validationOptions
--- PASS: TestAccACMCertificate_root (29.43s)
=== CONT  TestAccACMCertificate_San_trailingPeriod
--- PASS: TestAccACMCertificate_validationOptions (29.87s)
=== CONT  TestAccACMCertificate_dnsValidation
--- PASS: TestAccACMCertificate_San_trailingPeriod (34.98s)
=== CONT  TestAccACMCertificate_wildcard
--- PASS: TestAccACMCertificate_dnsValidation (31.40s)
=== CONT  TestAccACMCertificate_San_matches_domain
--- PASS: TestAccACMCertificate_wildcard (30.16s)
--- PASS: TestAccACMCertificate_San_matches_domain (30.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	713.673s

[ewbankkit]

@JamesJJ Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.