-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F aws add multiple listeners and port matching #27799
F aws add multiple listeners and port matching #27799
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @dgr237 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@YakDriver @breathingdust can you please take a look at this PR? I'm from the AWS App Mesh team and the change seems fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTARGS='-run=TestAccAppMesh_serial' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial -timeout 180m
--- PASS: TestAccAppMesh_serial (1744.11s)
--- PASS: TestAccAppMesh_serial/VirtualRouter (81.56s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/tags (29.91s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/basic (20.59s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/disappears (10.45s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/multiListener (20.62s)
--- PASS: TestAccAppMesh_serial/VirtualService (85.33s)
--- PASS: TestAccAppMesh_serial/VirtualService/disappears (11.35s)
--- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (22.52s)
--- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (20.13s)
--- PASS: TestAccAppMesh_serial/VirtualService/tags (31.32s)
--- PASS: TestAccAppMesh_serial/GatewayRoute (263.11s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (40.41s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (40.48s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/basic (13.48s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (22.44s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (40.53s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (40.52s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/tags (31.34s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (11.44s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (22.46s)
--- PASS: TestAccAppMesh_serial/Mesh (63.75s)
--- PASS: TestAccAppMesh_serial/Mesh/basic (11.69s)
--- PASS: TestAccAppMesh_serial/Mesh/egressFilter (24.50s)
--- PASS: TestAccAppMesh_serial/Mesh/tags (27.56s)
--- PASS: TestAccAppMesh_serial/Route (517.77s)
--- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (22.58s)
--- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (31.42s)
--- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (31.74s)
--- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (22.57s)
--- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (13.41s)
--- PASS: TestAccAppMesh_serial/Route/http2Route (22.50s)
--- PASS: TestAccAppMesh_serial/Route/httpHeader (22.34s)
--- PASS: TestAccAppMesh_serial/Route/disappears (11.52s)
--- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (22.48s)
--- PASS: TestAccAppMesh_serial/Route/tcpRoute (31.74s)
--- PASS: TestAccAppMesh_serial/Route/grpcRoute (40.62s)
--- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (40.50s)
--- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (73.46s)
--- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (22.60s)
--- PASS: TestAccAppMesh_serial/Route/routePriority (22.38s)
--- PASS: TestAccAppMesh_serial/Route/tags (31.70s)
--- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (22.52s)
--- PASS: TestAccAppMesh_serial/Route/httpRoute (31.68s)
--- PASS: TestAccAppMesh_serial/VirtualGateway (253.42s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/basic (12.36s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (20.57s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (64.23s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (20.79s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/logging (20.86s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/tags (29.10s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (10.58s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (20.87s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (12.50s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (20.72s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (20.84s)
--- PASS: TestAccAppMesh_serial/VirtualNode (479.17s)
--- PASS: TestAccAppMesh_serial/VirtualNode/logging (22.07s)
--- PASS: TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery (108.63s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerHealthChecks (21.15s)
--- PASS: TestAccAppMesh_serial/VirtualNode/multiListenerValidation (21.01s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile (21.14s)
--- PASS: TestAccAppMesh_serial/VirtualNode/tags (29.39s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection (21.03s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerTimeout (20.84s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerTls (64.28s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerValidation (20.74s)
--- PASS: TestAccAppMesh_serial/VirtualNode/basic (12.45s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm (51.57s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate (12.61s)
--- PASS: TestAccAppMesh_serial/VirtualNode/disappears (10.58s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaults (20.76s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (20.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 1747.056s
@dgr237 thank you for the contribution! 👏🏾 🎉 |
This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This Pull Request adds the functionality to be able specify multi listeners on the following resources:
aws_appmesh_virtual_node
aws_appmesh_virtual_gateway
aws_appmesh_virtual_router
In addition port has been added to match on the routes for:
aws_appmesh_gateway_route
aws_appmesh_route
Added weighted_target port to aws_appmesh_route.
Relations
Closes #27698
Closes #26380
References
This functionality enables services to expose multiple ports/ protocols and route traffic to the different ports form other services running on the cluster or from the gateway.
Output from Acceptance Testing