Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for "single-outpost" outpost_mode and preferred_outpost_arn to elasticache #27934

Merged
merged 11 commits into from
Nov 23, 2022
Merged

feat: add support for "single-outpost" outpost_mode and preferred_outpost_arn to elasticache #27934

merged 11 commits into from
Nov 23, 2022

Conversation

weizhangfd
Copy link
Contributor

Description

Add Outpost support to aws_elasticache_cluster.

Relations

Closes #18460

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccElastiCacheCluster_outpostARN_none PKG=elasticache
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheCluster_outpostARN_none'  -timeout 180m
=== RUN   TestAccElastiCacheCluster_outpostARN_none
=== PAUSE TestAccElastiCacheCluster_outpostARN_none
=== CONT  TestAccElastiCacheCluster_outpostARN_none
--- PASS: TestAccElastiCacheCluster_outpostARN_none (2.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        5.538s

...

Unfortunately I don't have an outpost instance available to run all the acceptance tests in outpost mode, apologies. Could I please trouble you to help me running them? Please feel free to edit the code.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @weizhangfd 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Nov 23, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_redis\|TestAccElastiCacheCluster_outpost\|TestAccElastiCacheClusterDataSource_Data_basic' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheCluster_Engine_redis\|TestAccElastiCacheCluster_outpost\|TestAccElastiCacheClusterDataSource_Data_basic -timeout 180m
=== RUN   TestAccElastiCacheClusterDataSource_Data_basic
=== PAUSE TestAccElastiCacheClusterDataSource_Data_basic
=== RUN   TestAccElastiCacheCluster_Engine_redis
=== PAUSE TestAccElastiCacheCluster_Engine_redis
=== RUN   TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN   TestAccElastiCacheCluster_outpost_memcached
=== PAUSE TestAccElastiCacheCluster_outpost_memcached
=== RUN   TestAccElastiCacheCluster_outpost_redis
=== PAUSE TestAccElastiCacheCluster_outpost_redis
=== RUN   TestAccElastiCacheCluster_outpostID_memcached
=== PAUSE TestAccElastiCacheCluster_outpostID_memcached
=== RUN   TestAccElastiCacheCluster_outpostID_redis
=== PAUSE TestAccElastiCacheCluster_outpostID_redis
=== CONT  TestAccElastiCacheClusterDataSource_Data_basic
=== CONT  TestAccElastiCacheCluster_outpost_redis
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_redis (1.86s)
=== CONT  TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheClusterDataSource_Data_basic (520.98s)
=== CONT  TestAccElastiCacheCluster_outpost_memcached
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_memcached (0.52s)
=== CONT  TestAccElastiCacheCluster_Engine_redis
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (558.91s)
=== CONT  TestAccElastiCacheCluster_outpostID_redis
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_redis (0.17s)
=== CONT  TestAccElastiCacheCluster_outpostID_memcached
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_memcached (0.23s)
--- PASS: TestAccElastiCacheCluster_Engine_redis (524.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	1037.641s

@ewbankkit
Copy link
Contributor

@weizhangfd Thanks for the contribution 🎉 👏.
The HashiCorp maintainers don't currently have access to an Outpost so I have noted in the CHANGELOG that this is best-effort.

@ewbankkit ewbankkit merged commit c6577e3 into hashicorp:main Nov 23, 2022
@github-actions github-actions bot added this to the v4.41.0 milestone Nov 23, 2022
@github-actions
Copy link

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_elasticache_cluster: Add Outpost support
2 participants