-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: aws_ivschat_room #27974
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIVSChat' PKG=ivschat ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivschat/... -v -count 1 -parallel 2 -run=TestAccIVSChat -timeout 180m
=== RUN TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== RUN TestAccIVSChatLoggingConfiguration_basic_firehose
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_firehose
=== RUN TestAccIVSChatLoggingConfiguration_basic_s3
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_s3
=== RUN TestAccIVSChatLoggingConfiguration_update_s3
=== PAUSE TestAccIVSChatLoggingConfiguration_update_s3
=== RUN TestAccIVSChatLoggingConfiguration_tags
=== PAUSE TestAccIVSChatLoggingConfiguration_tags
=== RUN TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== PAUSE TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== RUN TestAccIVSChatLoggingConfiguration_disappears
=== PAUSE TestAccIVSChatLoggingConfiguration_disappears
=== RUN TestAccIVSChatRoom_basic
=== PAUSE TestAccIVSChatRoom_basic
=== RUN TestAccIVSChatRoom_tags
=== PAUSE TestAccIVSChatRoom_tags
=== RUN TestAccIVSChatRoom_disappears
=== PAUSE TestAccIVSChatRoom_disappears
=== RUN TestAccIVSChatRoom_update
=== PAUSE TestAccIVSChatRoom_update
=== RUN TestAccIVSChatRoom_loggingConfiguration
=== PAUSE TestAccIVSChatRoom_loggingConfiguration
=== RUN TestAccIVSChatRoom_update_remove_messageReviewHandler_uri
=== PAUSE TestAccIVSChatRoom_update_remove_messageReviewHandler_uri
=== CONT TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== CONT TestAccIVSChatRoom_basic
--- PASS: TestAccIVSChatRoom_basic (28.11s)
=== CONT TestAccIVSChatLoggingConfiguration_tags
--- PASS: TestAccIVSChatLoggingConfiguration_basic_cloudwatch (29.03s)
=== CONT TestAccIVSChatLoggingConfiguration_disappears
--- PASS: TestAccIVSChatLoggingConfiguration_disappears (28.12s)
=== CONT TestAccIVSChatLoggingConfiguration_failure_invalidDestination
--- PASS: TestAccIVSChatLoggingConfiguration_failure_invalidDestination (5.58s)
=== CONT TestAccIVSChatLoggingConfiguration_basic_s3
--- PASS: TestAccIVSChatLoggingConfiguration_basic_s3 (31.73s)
=== CONT TestAccIVSChatLoggingConfiguration_update_s3
--- PASS: TestAccIVSChatLoggingConfiguration_tags (72.04s)
=== CONT TestAccIVSChatLoggingConfiguration_basic_firehose
--- PASS: TestAccIVSChatLoggingConfiguration_update_s3 (54.84s)
=== CONT TestAccIVSChatRoom_update
--- PASS: TestAccIVSChatRoom_update (68.94s)
=== CONT TestAccIVSChatRoom_update_remove_messageReviewHandler_uri
--- PASS: TestAccIVSChatRoom_update_remove_messageReviewHandler_uri (68.72s)
=== CONT TestAccIVSChatRoom_loggingConfiguration
--- PASS: TestAccIVSChatRoom_loggingConfiguration (93.85s)
=== CONT TestAccIVSChatRoom_disappears
--- PASS: TestAccIVSChatRoom_disappears (15.12s)
=== CONT TestAccIVSChatRoom_tags
--- PASS: TestAccIVSChatRoom_tags (45.98s)
--- PASS: TestAccIVSChatLoggingConfiguration_basic_firehose (1021.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ivschat 1131.617s
@KevinEady Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add new resource for AWS IVS Chat Room:
aws_ivschat_room
. This PR is the last in a set to support the full AWS IVS Chat entities:Logging ConfigurationSince this PR addresses the last entity to fully support IVS and IVS Chat, merging this PR will close the issue listed in Relations.
Relations
Closes #17272
References
Room
functions and typesOutput from Acceptance Testing
Output from Example