New Resource: aws_scheduler_schedule #27975

roberth-k · 2022-11-23T14:07:43Z

Description

Implements the aws_scheduler_schedule resource.

Relations

Output from Acceptance Testing

$ make testacc TESTS=TestAccSchedulerSchedule_ PKG=scheduler
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/scheduler/... -v -count 1 -parallel 20 -run='TestAccSchedulerSchedule_'  -timeout 180m
=== RUN   TestAccSchedulerSchedule_basic
=== PAUSE TestAccSchedulerSchedule_basic
=== RUN   TestAccSchedulerSchedule_disappears
=== PAUSE TestAccSchedulerSchedule_disappears
=== RUN   TestAccSchedulerSchedule_description
=== PAUSE TestAccSchedulerSchedule_description
=== RUN   TestAccSchedulerSchedule_endDate
=== PAUSE TestAccSchedulerSchedule_endDate
=== RUN   TestAccSchedulerSchedule_flexibleTimeWindow
=== PAUSE TestAccSchedulerSchedule_flexibleTimeWindow
=== RUN   TestAccSchedulerSchedule_groupName
=== PAUSE TestAccSchedulerSchedule_groupName
=== RUN   TestAccSchedulerSchedule_kmsKeyArn
=== PAUSE TestAccSchedulerSchedule_kmsKeyArn
=== RUN   TestAccSchedulerSchedule_nameGenerated
=== PAUSE TestAccSchedulerSchedule_nameGenerated
=== RUN   TestAccSchedulerSchedule_namePrefix
=== PAUSE TestAccSchedulerSchedule_namePrefix
=== RUN   TestAccSchedulerSchedule_scheduleExpression
=== PAUSE TestAccSchedulerSchedule_scheduleExpression
=== RUN   TestAccSchedulerSchedule_scheduleExpressionTimezone
=== PAUSE TestAccSchedulerSchedule_scheduleExpressionTimezone
=== RUN   TestAccSchedulerSchedule_startDate
=== PAUSE TestAccSchedulerSchedule_startDate
=== RUN   TestAccSchedulerSchedule_state
=== PAUSE TestAccSchedulerSchedule_state
=== RUN   TestAccSchedulerSchedule_targetArn
=== PAUSE TestAccSchedulerSchedule_targetArn
=== RUN   TestAccSchedulerSchedule_targetDeadLetterConfig
=== PAUSE TestAccSchedulerSchedule_targetDeadLetterConfig
=== RUN   TestAccSchedulerSchedule_targetEcsParameters
=== PAUSE TestAccSchedulerSchedule_targetEcsParameters
=== RUN   TestAccSchedulerSchedule_targetEventBridgeParameters
=== PAUSE TestAccSchedulerSchedule_targetEventBridgeParameters
=== RUN   TestAccSchedulerSchedule_targetInput
=== PAUSE TestAccSchedulerSchedule_targetInput
=== RUN   TestAccSchedulerSchedule_targetKinesisParameters
=== PAUSE TestAccSchedulerSchedule_targetKinesisParameters
=== RUN   TestAccSchedulerSchedule_targetRetryPolicy
=== PAUSE TestAccSchedulerSchedule_targetRetryPolicy
=== RUN   TestAccSchedulerSchedule_targetRoleArn
=== PAUSE TestAccSchedulerSchedule_targetRoleArn
=== RUN   TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== PAUSE TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== RUN   TestAccSchedulerSchedule_targetSqsParameters
=== PAUSE TestAccSchedulerSchedule_targetSqsParameters
=== CONT  TestAccSchedulerSchedule_basic
=== CONT  TestAccSchedulerSchedule_state
=== CONT  TestAccSchedulerSchedule_targetRoleArn
=== CONT  TestAccSchedulerSchedule_targetEcsParameters
=== CONT  TestAccSchedulerSchedule_kmsKeyArn
=== CONT  TestAccSchedulerSchedule_endDate
=== CONT  TestAccSchedulerSchedule_targetInput
=== CONT  TestAccSchedulerSchedule_targetEventBridgeParameters
=== CONT  TestAccSchedulerSchedule_targetSqsParameters
=== CONT  TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== CONT  TestAccSchedulerSchedule_description
=== CONT  TestAccSchedulerSchedule_targetDeadLetterConfig
=== CONT  TestAccSchedulerSchedule_scheduleExpression
=== CONT  TestAccSchedulerSchedule_startDate
=== CONT  TestAccSchedulerSchedule_scheduleExpressionTimezone
=== CONT  TestAccSchedulerSchedule_groupName
=== CONT  TestAccSchedulerSchedule_flexibleTimeWindow
=== CONT  TestAccSchedulerSchedule_disappears
=== CONT  TestAccSchedulerSchedule_namePrefix
=== CONT  TestAccSchedulerSchedule_targetKinesisParameters
--- PASS: TestAccSchedulerSchedule_disappears (71.58s)
=== CONT  TestAccSchedulerSchedule_nameGenerated
--- PASS: TestAccSchedulerSchedule_namePrefix (77.35s)
=== CONT  TestAccSchedulerSchedule_targetArn
--- PASS: TestAccSchedulerSchedule_basic (77.55s)
=== CONT  TestAccSchedulerSchedule_targetRetryPolicy
--- PASS: TestAccSchedulerSchedule_groupName (88.16s)
--- PASS: TestAccSchedulerSchedule_scheduleExpression (113.44s)
--- PASS: TestAccSchedulerSchedule_targetRoleArn (113.75s)
--- PASS: TestAccSchedulerSchedule_targetInput (114.93s)
--- PASS: TestAccSchedulerSchedule_nameGenerated (64.21s)
--- PASS: TestAccSchedulerSchedule_flexibleTimeWindow (136.71s)
--- PASS: TestAccSchedulerSchedule_description (138.79s)
--- PASS: TestAccSchedulerSchedule_state (140.12s)
--- PASS: TestAccSchedulerSchedule_startDate (141.07s)
--- PASS: TestAccSchedulerSchedule_kmsKeyArn (141.37s)
--- PASS: TestAccSchedulerSchedule_targetDeadLetterConfig (142.41s)
--- PASS: TestAccSchedulerSchedule_endDate (142.88s)
--- PASS: TestAccSchedulerSchedule_scheduleExpressionTimezone (142.92s)
--- PASS: TestAccSchedulerSchedule_targetSqsParameters (143.01s)
--- PASS: TestAccSchedulerSchedule_targetEventBridgeParameters (143.63s)
--- PASS: TestAccSchedulerSchedule_targetKinesisParameters (147.64s)
--- PASS: TestAccSchedulerSchedule_targetArn (78.43s)
--- PASS: TestAccSchedulerSchedule_targetSageMakerPipelineParameters (169.11s)
--- PASS: TestAccSchedulerSchedule_targetRetryPolicy (96.52s)
--- PASS: TestAccSchedulerSchedule_targetEcsParameters (180.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/scheduler  182.672s

… block

…tion block

… block

…nfiguration block

github-actions · 2022-11-23T14:09:22Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…onfiguration This is in line with aws_cloudwatch_event_target.

…ld not find expected ':''.

…StringInSlice'.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSchedulerSchedule_' PKG=scheduler ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/scheduler/... -v -count 1 -parallel 2  -run=TestAccSchedulerSchedule_ -timeout 180m
=== RUN   TestAccSchedulerSchedule_basic
=== PAUSE TestAccSchedulerSchedule_basic
=== RUN   TestAccSchedulerSchedule_disappears
=== PAUSE TestAccSchedulerSchedule_disappears
=== RUN   TestAccSchedulerSchedule_description
=== PAUSE TestAccSchedulerSchedule_description
=== RUN   TestAccSchedulerSchedule_endDate
=== PAUSE TestAccSchedulerSchedule_endDate
=== RUN   TestAccSchedulerSchedule_flexibleTimeWindow
=== PAUSE TestAccSchedulerSchedule_flexibleTimeWindow
=== RUN   TestAccSchedulerSchedule_groupName
=== PAUSE TestAccSchedulerSchedule_groupName
=== RUN   TestAccSchedulerSchedule_kmsKeyARN
=== PAUSE TestAccSchedulerSchedule_kmsKeyARN
=== RUN   TestAccSchedulerSchedule_nameGenerated
=== PAUSE TestAccSchedulerSchedule_nameGenerated
=== RUN   TestAccSchedulerSchedule_namePrefix
=== PAUSE TestAccSchedulerSchedule_namePrefix
=== RUN   TestAccSchedulerSchedule_scheduleExpression
=== PAUSE TestAccSchedulerSchedule_scheduleExpression
=== RUN   TestAccSchedulerSchedule_scheduleExpressionTimezone
=== PAUSE TestAccSchedulerSchedule_scheduleExpressionTimezone
=== RUN   TestAccSchedulerSchedule_startDate
=== PAUSE TestAccSchedulerSchedule_startDate
=== RUN   TestAccSchedulerSchedule_state
=== PAUSE TestAccSchedulerSchedule_state
=== RUN   TestAccSchedulerSchedule_targetARN
=== PAUSE TestAccSchedulerSchedule_targetARN
=== RUN   TestAccSchedulerSchedule_targetDeadLetterConfig
=== PAUSE TestAccSchedulerSchedule_targetDeadLetterConfig
=== RUN   TestAccSchedulerSchedule_targetECSParameters
=== PAUSE TestAccSchedulerSchedule_targetECSParameters
=== RUN   TestAccSchedulerSchedule_targetEventBridgeParameters
=== PAUSE TestAccSchedulerSchedule_targetEventBridgeParameters
=== RUN   TestAccSchedulerSchedule_targetInput
=== PAUSE TestAccSchedulerSchedule_targetInput
=== RUN   TestAccSchedulerSchedule_targetKinesisParameters
=== PAUSE TestAccSchedulerSchedule_targetKinesisParameters
=== RUN   TestAccSchedulerSchedule_targetRetryPolicy
=== PAUSE TestAccSchedulerSchedule_targetRetryPolicy
=== RUN   TestAccSchedulerSchedule_targetRoleARN
=== PAUSE TestAccSchedulerSchedule_targetRoleARN
=== RUN   TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== PAUSE TestAccSchedulerSchedule_targetSageMakerPipelineParameters
=== RUN   TestAccSchedulerSchedule_targetSQSParameters
=== PAUSE TestAccSchedulerSchedule_targetSQSParameters
=== CONT  TestAccSchedulerSchedule_basic
=== CONT  TestAccSchedulerSchedule_state
--- PASS: TestAccSchedulerSchedule_basic (52.60s)
=== CONT  TestAccSchedulerSchedule_targetKinesisParameters
--- PASS: TestAccSchedulerSchedule_state (88.36s)
=== CONT  TestAccSchedulerSchedule_targetSQSParameters
--- PASS: TestAccSchedulerSchedule_targetKinesisParameters (108.97s)
=== CONT  TestAccSchedulerSchedule_targetSageMakerPipelineParameters
--- PASS: TestAccSchedulerSchedule_targetSQSParameters (90.65s)
=== CONT  TestAccSchedulerSchedule_targetRoleARN
--- PASS: TestAccSchedulerSchedule_targetRoleARN (69.07s)
=== CONT  TestAccSchedulerSchedule_targetRetryPolicy
--- PASS: TestAccSchedulerSchedule_targetSageMakerPipelineParameters (115.41s)
=== CONT  TestAccSchedulerSchedule_kmsKeyARN
--- PASS: TestAccSchedulerSchedule_targetRetryPolicy (87.14s)
=== CONT  TestAccSchedulerSchedule_startDate
--- PASS: TestAccSchedulerSchedule_kmsKeyARN (86.98s)
=== CONT  TestAccSchedulerSchedule_scheduleExpressionTimezone
--- PASS: TestAccSchedulerSchedule_startDate (88.39s)
=== CONT  TestAccSchedulerSchedule_scheduleExpression
--- PASS: TestAccSchedulerSchedule_scheduleExpressionTimezone (88.30s)
=== CONT  TestAccSchedulerSchedule_namePrefix
--- PASS: TestAccSchedulerSchedule_scheduleExpression (68.20s)
=== CONT  TestAccSchedulerSchedule_nameGenerated
--- PASS: TestAccSchedulerSchedule_namePrefix (50.77s)
=== CONT  TestAccSchedulerSchedule_endDate
--- PASS: TestAccSchedulerSchedule_nameGenerated (50.40s)
=== CONT  TestAccSchedulerSchedule_groupName
--- PASS: TestAccSchedulerSchedule_endDate (86.31s)
=== CONT  TestAccSchedulerSchedule_flexibleTimeWindow
--- PASS: TestAccSchedulerSchedule_groupName (59.87s)
=== CONT  TestAccSchedulerSchedule_targetECSParameters
--- PASS: TestAccSchedulerSchedule_flexibleTimeWindow (85.63s)
=== CONT  TestAccSchedulerSchedule_targetInput
--- PASS: TestAccSchedulerSchedule_targetECSParameters (134.46s)
=== CONT  TestAccSchedulerSchedule_targetEventBridgeParameters
--- PASS: TestAccSchedulerSchedule_targetInput (68.10s)
=== CONT  TestAccSchedulerSchedule_description
--- PASS: TestAccSchedulerSchedule_description (89.71s)
=== CONT  TestAccSchedulerSchedule_targetDeadLetterConfig
--- PASS: TestAccSchedulerSchedule_targetEventBridgeParameters (107.13s)
=== CONT  TestAccSchedulerSchedule_disappears
--- PASS: TestAccSchedulerSchedule_disappears (46.75s)
=== CONT  TestAccSchedulerSchedule_targetARN
--- PASS: TestAccSchedulerSchedule_targetDeadLetterConfig (89.79s)
--- PASS: TestAccSchedulerSchedule_targetARN (67.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/scheduler	962.515s

This reverts commit 077225d.

This reverts commit 9445365.

This reverts commit 170ccaf.

This reverts commit d03bfe4.

This reverts commit e4177a1.

This reverts commit ed45a0d.

ewbankkit · 2022-11-23T20:04:27Z

@roberth-k @atsushi-ishibashi Thanks for the contribution 🎉 👏.

github-actions · 2022-11-28T22:20:41Z

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-12-30T02:15:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

roberth-k and others added 28 commits November 16, 2022 16:06

r/aws_scheduler_schedule: new resource

0300634

r/aws_scheduler_schedule: add sweeper

a7182c7

r/aws_scheduler_schedule: add tests for generated name & name prefix

e8f8b91

r/aws_scheduler_schedule: add description attribute

137a984

r/aws_scheduler_schedule: complete flexible_time_window configuration…

d298357

… block

r/aws_scheduler_schedule: add end_date attribute

5a7e5f8

r/aws_scheduler_schedule: add test for group_name attribute

d2b732a

r/aws_scheduler_schedule: add kms_key_arn attribute

5b2aa62

r/aws_scheduler_schedule: simplify attribute reads

9dfb036

resource schema

ed45a0d

int->string for timestamp, remove tags

e4177a1

finish schema def

d03bfe4

use enum from sdk-v2

170ccaf

r/aws_scheduler_schedule: add schedule_expression_timezone attribute

75123b7

r/aws_scheduler_schedule: add start_date attribute

cb871d3

r/aws_scheduler_schedule: add state attribute

f6dea84

r/aws_scheduler_schedule: add target.sqs_parameters configuration block

1d90174

crud

9445365

fix lint

077225d

r/aws_scheduler_schedule: add target.input configuration block

f79cfe0

r/aws_scheduler_schedule: add target.dead_letter_config configuration…

fb87e67

… block

r/aws_scheduler_schedule: add target.retry_policy configuration block

0b9fe1c

r/aws_scheduler_schedule: add target.eventbridge_parameters configura…

d57afef

…tion block

r/aws_scheduler_schedule: add target.kinesis_parameters configuration…

1bf5504

… block

r/aws_scheduler_schedule: add target.sagemaker_pipeline_parameters co…

c22d1e2

…nfiguration block

r/aws_scheduler_schedule: add target.ecs_parameters configuration block

4d29893

r/aws_scheduler_schedule: tidy up

e61af0d

add changelog entry for hashicorp#27975

ac4bd62

github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Nov 23, 2022

roberth-k added 2 commits November 23, 2022 17:06

r/aws_scheduler_schedule: flatten awsvpc_configuration into network_c…

86e1e9a

…onfiguration This is in line with aws_cloudwatch_event_target.

r/aws_scheduler_schedule: fix dead links in docs

a3951a0

ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2022

ewbankkit added 6 commits November 23, 2022 13:58

Fix semgrep 'ci.caps3-in-func-name'.

527c831

Fix semgrep 'ci.caps4-in-func-name'.

a576b95

Fix semgrep 'ci.caps2-in-func-name'.

55370a9

Fix tfproviderdocs 'error parsing YAML frontmatter: yaml: line 7: cou…

0fa534e

…ld not find expected ':''.

Add nosemgrep for 'ci.scheduler-in-func-name'.

2608816

r/aws_scheduler_schedule: Use 'enum.Validate' instead of 'validation.…

5341c9d

…StringInSlice'.

ewbankkit approved these changes Nov 23, 2022

View reviewed changes

ewbankkit added 7 commits November 23, 2022 14:54

Revert "fix lint"

362795c

This reverts commit 077225d.

Revert "crud"

55ec782

This reverts commit 9445365.

Revert "use enum from sdk-v2"

6b3493a

This reverts commit 170ccaf.

Revert "finish schema def"

94b5fdd

This reverts commit d03bfe4.

Revert "int->string for timestamp, remove tags"

0d7305c

This reverts commit e4177a1.

Revert "resource schema"

b0b5270

This reverts commit ed45a0d.

Merge commit 'b0b527078b4b2169dde220d59bbccd80c86fc6f7' into HEAD

b245e12

ewbankkit merged commit dde320d into hashicorp:main Nov 23, 2022

github-actions bot added this to the v4.41.0 milestone Nov 23, 2022

github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: aws_scheduler_schedule #27975

New Resource: aws_scheduler_schedule #27975

roberth-k commented Nov 23, 2022 •

edited by ewbankkit

Loading

github-actions bot commented Nov 23, 2022

ewbankkit left a comment

ewbankkit commented Nov 23, 2022 •

edited

Loading

github-actions bot commented Nov 28, 2022

github-actions bot commented Dec 30, 2022

New Resource: aws_scheduler_schedule #27975

New Resource: aws_scheduler_schedule #27975

Conversation

roberth-k commented Nov 23, 2022 • edited by ewbankkit Loading

Description

Relations

Output from Acceptance Testing

github-actions bot commented Nov 23, 2022

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Nov 23, 2022 • edited Loading

github-actions bot commented Nov 28, 2022

github-actions bot commented Dec 30, 2022

roberth-k commented Nov 23, 2022 •

edited by ewbankkit

Loading

ewbankkit commented Nov 23, 2022 •

edited

Loading