Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon RDS Blue/Green Deployments #28046

Merged
merged 21 commits into from
Nov 28, 2022
Merged

Amazon RDS Blue/Green Deployments #28046

merged 21 commits into from
Nov 28, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 28, 2022

Description

Adds the blue_green_update configuration block to the aws_db_instance resource to support Amazon RDS Blue/Green Deployments.

Relations

Closes #28042.

Output from Acceptance Testing

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccRDSInstance_ReplicateSourceDB_basic\|TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved\|TestAccRDSInstance_license\|TestAccRDSInstance_BlueGreenDeployment_\|TestAccRDSInstance_basic\|TestAccRDSClusterInstance_basic\|TestAccRDSClusterParameterGroup_basic\|TestAccRDSParameterGroup_basic' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstance_ReplicateSourceDB_basic\|TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved\|TestAccRDSInstance_license\|TestAccRDSInstance_BlueGreenDeployment_\|TestAccRDSInstance_basic\|TestAccRDSClusterInstance_basic\|TestAccRDSClusterParameterGroup_basic\|TestAccRDSParameterGroup_basic -timeout 360m
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== RUN   TestAccRDSClusterParameterGroup_basic
=== PAUSE TestAccRDSClusterParameterGroup_basic
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_ReplicateSourceDB_basic
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_basic
=== RUN   TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
=== RUN   TestAccRDSInstance_license
=== PAUSE TestAccRDSInstance_license
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== RUN   TestAccRDSInstance_BlueGreenDeployment_tags
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_tags
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== RUN   TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== RUN   TestAccRDSParameterGroup_basic
=== PAUSE TestAccRDSParameterGroup_basic
=== CONT  TestAccRDSClusterInstance_basic
=== CONT  TestAccRDSInstance_BlueGreenDeployment_tags
=== CONT  TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
--- PASS: TestAccRDSInstance_BlueGreenDeployment_tags (675.56s)
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSClusterInstance_basic (1098.94s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_basic
--- PASS: TestAccRDSInstance_basic (478.14s)
=== CONT  TestAccRDSClusterParameterGroup_basic
--- PASS: TestAccRDSClusterParameterGroup_basic (75.96s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
--- PASS: TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved (1399.96s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1693.66s)
=== CONT  TestAccRDSInstance_license
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup (2168.72s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_deletionProtection
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2682.20s)
=== CONT  TestAccRDSParameterGroup_basic
--- PASS: TestAccRDSInstance_license (1139.62s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
--- PASS: TestAccRDSParameterGroup_basic (57.65s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
--- PASS: TestAccRDSInstance_BlueGreenDeployment_deletionProtection (2326.88s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica (3459.57s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection (3707.79s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups (2419.79s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass (2311.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	9744.744s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2022
@ewbankkit ewbankkit merged commit 773bbde into main Nov 28, 2022
@ewbankkit ewbankkit deleted the f-rds-blue-green-instance branch November 28, 2022 21:21
@github-actions github-actions bot added this to the v4.42.0 milestone Nov 28, 2022
github-actions bot pushed a commit that referenced this pull request Nov 28, 2022
@github-actions
Copy link

This functionality has been released in v4.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon RDS Blue/Green Deployments
2 participants