Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_cloudwatch_log_data_protection_policy #28049

Conversation

roberth-k
Copy link
Contributor

Description

Relations

Closes #28045
Relates #28036

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccLogsDataProtectionPolicy_ PKG=logs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 20 -run='TestAccLogsDataProtectionPolicy_'  -timeout 180m
=== RUN   TestAccLogsDataProtectionPolicy_basic
=== PAUSE TestAccLogsDataProtectionPolicy_basic
=== RUN   TestAccLogsDataProtectionPolicy_disappears
=== PAUSE TestAccLogsDataProtectionPolicy_disappears
=== RUN   TestAccLogsDataProtectionPolicy_policyDocument
=== PAUSE TestAccLogsDataProtectionPolicy_policyDocument
=== CONT  TestAccLogsDataProtectionPolicy_basic
=== CONT  TestAccLogsDataProtectionPolicy_policyDocument
=== CONT  TestAccLogsDataProtectionPolicy_disappears
--- PASS: TestAccLogsDataProtectionPolicy_disappears (11.99s)
--- PASS: TestAccLogsDataProtectionPolicy_basic (13.48s)
--- PASS: TestAccLogsDataProtectionPolicy_policyDocument (21.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/logs       23.744s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/logs Issues and PRs that pertain to the logs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Nov 28, 2022
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

roberth-k added a commit to roberth-k/terraform-provider-aws that referenced this pull request Nov 28, 2022
@roberth-k roberth-k force-pushed the f-aws_cloudwatch_log_group_data_protection_policy-2 branch from 9080a78 to 2947849 Compare November 28, 2022 18:07
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 28, 2022
@ewbankkit ewbankkit force-pushed the f-aws_cloudwatch_log_group_data_protection_policy-2 branch from 0888ac5 to 9e6449b Compare November 28, 2022 18:48
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLogsDataProtectionPolicy_' PKG=logs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2  -run=TestAccLogsDataProtectionPolicy_ -timeout 180m
=== RUN   TestAccLogsDataProtectionPolicy_basic
=== PAUSE TestAccLogsDataProtectionPolicy_basic
=== RUN   TestAccLogsDataProtectionPolicy_disappears
=== PAUSE TestAccLogsDataProtectionPolicy_disappears
=== RUN   TestAccLogsDataProtectionPolicy_policyDocument
=== PAUSE TestAccLogsDataProtectionPolicy_policyDocument
=== CONT  TestAccLogsDataProtectionPolicy_basic
=== CONT  TestAccLogsDataProtectionPolicy_policyDocument
--- PASS: TestAccLogsDataProtectionPolicy_basic (26.36s)
=== CONT  TestAccLogsDataProtectionPolicy_disappears
--- PASS: TestAccLogsDataProtectionPolicy_policyDocument (44.20s)
--- PASS: TestAccLogsDataProtectionPolicy_disappears (22.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	53.550s

@ewbankkit ewbankkit force-pushed the f-aws_cloudwatch_log_group_data_protection_policy-2 branch from 9e6449b to 9ab0d7f Compare November 28, 2022 18:53
@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 28731bc into hashicorp:main Nov 28, 2022
@github-actions github-actions bot added this to the v4.42.0 milestone Nov 28, 2022
@github-actions
Copy link

This functionality has been released in v4.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/logs Issues and PRs that pertain to the logs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants