r/neptune_cluster - fix major version upgrade #28051

DrFaust92 · 2022-11-28T18:45:29Z

Description

Relations

Closes #27998.
Closes #25982.
Closes #11752.
Closes #25972.
Closes #23601.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccNeptuneCluster_updateEngineMajorVersion  PKG=neptune

--- PASS: TestAccNeptuneCluster_updateEngineMajorVersion (1930.03s)

…p#11752 (comment)), tags may not be set when the resource is new, since there's no value for arn yet

…called, passing the engine-version along to ModifyDBCluster. This will always fail, even when the engine-version has not changed. The solution might be to omit the version from the arguments in case the resource has been freshly created.

github-actions · 2022-11-28T18:45:47Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

ran2806

According to the documentation. New requirement for modifyCluster API in major version upgrade is DBInstanceParameterGroupName https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/neptune#ModifyDBClusterInput. Actually both the parameters are required.

https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases-1.1.0.0.html

ran2806 · 2022-11-29T05:59:05Z

You might be having confusion between DBClusterParameterGroupName and DBInstanceParameterGroupName. Please add both the parameter group names while major upgrade.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNeptuneCluster_' PKG=neptune ACCTEST_PARALLELISM=2           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2  -run=TestAccNeptuneCluster_ -timeout 180m
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_copyTagsToSnapshot
=== PAUSE TestAccNeptuneCluster_copyTagsToSnapshot
=== RUN   TestAccNeptuneCluster_namePrefix
=== PAUSE TestAccNeptuneCluster_namePrefix
=== RUN   TestAccNeptuneCluster_serverlessConfiguration
=== PAUSE TestAccNeptuneCluster_serverlessConfiguration
=== RUN   TestAccNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccNeptuneCluster_tags
=== PAUSE TestAccNeptuneCluster_tags
=== RUN   TestAccNeptuneCluster_updateIAMRoles
=== PAUSE TestAccNeptuneCluster_updateIAMRoles
=== RUN   TestAccNeptuneCluster_kmsKey
=== PAUSE TestAccNeptuneCluster_kmsKey
=== RUN   TestAccNeptuneCluster_encrypted
=== PAUSE TestAccNeptuneCluster_encrypted
=== RUN   TestAccNeptuneCluster_backupsUpdate
=== PAUSE TestAccNeptuneCluster_backupsUpdate
=== RUN   TestAccNeptuneCluster_iamAuth
=== PAUSE TestAccNeptuneCluster_iamAuth
=== RUN   TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== RUN   TestAccNeptuneCluster_updateEngineVersion
=== PAUSE TestAccNeptuneCluster_updateEngineVersion
=== RUN   TestAccNeptuneCluster_updateEngineMajorVersion
=== PAUSE TestAccNeptuneCluster_updateEngineMajorVersion
=== RUN   TestAccNeptuneCluster_deleteProtection
=== PAUSE TestAccNeptuneCluster_deleteProtection
=== RUN   TestAccNeptuneCluster_disappears
=== PAUSE TestAccNeptuneCluster_disappears
=== CONT  TestAccNeptuneCluster_basic
=== CONT  TestAccNeptuneCluster_encrypted
--- PASS: TestAccNeptuneCluster_encrypted (134.83s)
=== CONT  TestAccNeptuneCluster_updateEngineVersion
--- PASS: TestAccNeptuneCluster_basic (154.82s)
=== CONT  TestAccNeptuneCluster_disappears
--- PASS: TestAccNeptuneCluster_disappears (148.03s)
=== CONT  TestAccNeptuneCluster_deleteProtection
--- PASS: TestAccNeptuneCluster_deleteProtection (221.45s)
=== CONT  TestAccNeptuneCluster_updateEngineMajorVersion
--- PASS: TestAccNeptuneCluster_updateEngineVersion (1533.70s)
=== CONT  TestAccNeptuneCluster_iamAuth
--- PASS: TestAccNeptuneCluster_iamAuth (131.35s)
=== CONT  TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (240.32s)
=== CONT  TestAccNeptuneCluster_takeFinalSnapshot
--- PASS: TestAccNeptuneCluster_takeFinalSnapshot (223.48s)
=== CONT  TestAccNeptuneCluster_kmsKey
--- PASS: TestAccNeptuneCluster_kmsKey (128.11s)
=== CONT  TestAccNeptuneCluster_updateIAMRoles
--- PASS: TestAccNeptuneCluster_updateIAMRoles (184.17s)
=== CONT  TestAccNeptuneCluster_tags
--- PASS: TestAccNeptuneCluster_tags (200.49s)
=== CONT  TestAccNeptuneCluster_backupsUpdate
--- PASS: TestAccNeptuneCluster_backupsUpdate (206.87s)
=== CONT  TestAccNeptuneCluster_namePrefix
--- PASS: TestAccNeptuneCluster_updateEngineMajorVersion (2493.73s)
=== CONT  TestAccNeptuneCluster_serverlessConfiguration
--- PASS: TestAccNeptuneCluster_namePrefix (120.58s)
=== CONT  TestAccNeptuneCluster_copyTagsToSnapshot
--- PASS: TestAccNeptuneCluster_serverlessConfiguration (130.71s)
--- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (270.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	3379.413s

ewbankkit · 2022-11-29T16:00:41Z

Currently DBInstanceParameterGroupName cannot be configured for the aws_neptune_cluster resource.

ran2806 · 2022-11-30T06:49:47Z

How to solve the issue for major version upgrade then when using custom parameterGroup for DBInstance, if we can not use DBInstanceParameterGroupName?

DrFaust92 · 2022-12-03T19:30:23Z

@ewbankkit should i rebase?

…gument.

Acceptance test output: % ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccNeptuneCluster_' PKG=neptune ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneCluster_ -timeout 360m === RUN TestAccNeptuneCluster_basic === PAUSE TestAccNeptuneCluster_basic === RUN TestAccNeptuneCluster_copyTagsToSnapshot === PAUSE TestAccNeptuneCluster_copyTagsToSnapshot === RUN TestAccNeptuneCluster_namePrefix === PAUSE TestAccNeptuneCluster_namePrefix === RUN TestAccNeptuneCluster_serverlessConfiguration === PAUSE TestAccNeptuneCluster_serverlessConfiguration === RUN TestAccNeptuneCluster_takeFinalSnapshot === PAUSE TestAccNeptuneCluster_takeFinalSnapshot === RUN TestAccNeptuneCluster_tags === PAUSE TestAccNeptuneCluster_tags === RUN TestAccNeptuneCluster_updateIAMRoles === PAUSE TestAccNeptuneCluster_updateIAMRoles === RUN TestAccNeptuneCluster_kmsKey === PAUSE TestAccNeptuneCluster_kmsKey === RUN TestAccNeptuneCluster_encrypted === PAUSE TestAccNeptuneCluster_encrypted === RUN TestAccNeptuneCluster_backupsUpdate === PAUSE TestAccNeptuneCluster_backupsUpdate === RUN TestAccNeptuneCluster_iamAuth === PAUSE TestAccNeptuneCluster_iamAuth === RUN TestAccNeptuneCluster_updateCloudWatchLogsExports === PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports === RUN TestAccNeptuneCluster_updateEngineVersion === PAUSE TestAccNeptuneCluster_updateEngineVersion === RUN TestAccNeptuneCluster_updateEngineMajorVersion === PAUSE TestAccNeptuneCluster_updateEngineMajorVersion === RUN TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters === PAUSE TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters === RUN TestAccNeptuneCluster_deleteProtection === PAUSE TestAccNeptuneCluster_deleteProtection === RUN TestAccNeptuneCluster_disappears === PAUSE TestAccNeptuneCluster_disappears === CONT TestAccNeptuneCluster_basic === CONT TestAccNeptuneCluster_backupsUpdate === CONT TestAccNeptuneCluster_disappears --- PASS: TestAccNeptuneCluster_basic (144.98s) === CONT TestAccNeptuneCluster_deleteProtection --- PASS: TestAccNeptuneCluster_disappears (150.41s) === CONT TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters --- PASS: TestAccNeptuneCluster_backupsUpdate (198.87s) === CONT TestAccNeptuneCluster_updateEngineMajorVersion --- PASS: TestAccNeptuneCluster_deleteProtection (240.80s) === CONT TestAccNeptuneCluster_updateEngineVersion testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1 Error: deleting Neptune Cluster Instance (tf-acc-test-3391912424752050633): waiting for completion: %!s(<nil>) --- FAIL: TestAccNeptuneCluster_updateEngineVersion (1653.73s) === CONT TestAccNeptuneCluster_updateCloudWatchLogsExports --- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (249.83s) === CONT TestAccNeptuneCluster_iamAuth === CONT TestAccNeptuneCluster_updateEngineMajorVersion testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1 Error: deleting Neptune Cluster Instance (tf-acc-test-3008139490537286476): waiting for completion: %!s(<nil>) --- FAIL: TestAccNeptuneCluster_updateEngineMajorVersion (2097.66s) === CONT TestAccNeptuneCluster_tags --- PASS: TestAccNeptuneCluster_iamAuth (161.64s) === CONT TestAccNeptuneCluster_encrypted --- PASS: TestAccNeptuneCluster_tags (158.66s) === CONT TestAccNeptuneCluster_kmsKey === CONT TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1 Error: deleting Neptune Cluster Instance (tf-acc-test-secondary-4479110391973925312): waiting for completion: %!s(<nil>) --- FAIL: TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (2332.89s) === CONT TestAccNeptuneCluster_updateIAMRoles --- PASS: TestAccNeptuneCluster_kmsKey (140.80s) === CONT TestAccNeptuneCluster_serverlessConfiguration --- PASS: TestAccNeptuneCluster_encrypted (146.39s) === CONT TestAccNeptuneCluster_takeFinalSnapshot --- PASS: TestAccNeptuneCluster_updateIAMRoles (172.30s) === CONT TestAccNeptuneCluster_namePrefix --- PASS: TestAccNeptuneCluster_serverlessConfiguration (129.31s) === CONT TestAccNeptuneCluster_copyTagsToSnapshot --- PASS: TestAccNeptuneCluster_namePrefix (128.57s) --- PASS: TestAccNeptuneCluster_takeFinalSnapshot (305.60s) --- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (198.01s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/neptune 2928.774s FAIL make: *** [testacc] Error 1

Acceptance test output: % make testacc TESTARGS='-run=TestAccNeptuneClusterInstance_' PKG=neptune ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneClusterInstance_ -timeout 180m === RUN TestAccNeptuneClusterInstance_basic === PAUSE TestAccNeptuneClusterInstance_basic === RUN TestAccNeptuneClusterInstance_disappears === PAUSE TestAccNeptuneClusterInstance_disappears === RUN TestAccNeptuneClusterInstance_nameGenerated === PAUSE TestAccNeptuneClusterInstance_nameGenerated === RUN TestAccNeptuneClusterInstance_namePrefix === PAUSE TestAccNeptuneClusterInstance_namePrefix === RUN TestAccNeptuneClusterInstance_tags === PAUSE TestAccNeptuneClusterInstance_tags === RUN TestAccNeptuneClusterInstance_withAZ === PAUSE TestAccNeptuneClusterInstance_withAZ === RUN TestAccNeptuneClusterInstance_withSubnetGroup === PAUSE TestAccNeptuneClusterInstance_withSubnetGroup === RUN TestAccNeptuneClusterInstance_kmsKey === PAUSE TestAccNeptuneClusterInstance_kmsKey === CONT TestAccNeptuneClusterInstance_basic === CONT TestAccNeptuneClusterInstance_tags === CONT TestAccNeptuneClusterInstance_nameGenerated --- PASS: TestAccNeptuneClusterInstance_basic (1309.76s) === CONT TestAccNeptuneClusterInstance_disappears --- PASS: TestAccNeptuneClusterInstance_nameGenerated (1384.45s) === CONT TestAccNeptuneClusterInstance_withSubnetGroup --- PASS: TestAccNeptuneClusterInstance_tags (1410.31s) --- PASS: TestAccNeptuneClusterInstance_kmsKey (1354.95s) === CONT TestAccNeptuneClusterInstance_withAZ --- PASS: TestAccNeptuneClusterInstance_withSubnetGroup (1228.83s) --- PASS: TestAccNeptuneClusterInstance_disappears (1224.74s) === CONT TestAccNeptuneClusterInstance_namePrefix --- PASS: TestAccNeptuneClusterInstance_withAZ (1219.66s) --- PASS: TestAccNeptuneClusterInstance_namePrefix (1456.29s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 3902.197s

Acceptance test output: % ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccNeptuneCluster_' PKG=neptune ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneCluster_ -timeout 360m === RUN TestAccNeptuneCluster_basic === PAUSE TestAccNeptuneCluster_basic === RUN TestAccNeptuneCluster_copyTagsToSnapshot === PAUSE TestAccNeptuneCluster_copyTagsToSnapshot === RUN TestAccNeptuneCluster_namePrefix === PAUSE TestAccNeptuneCluster_namePrefix === RUN TestAccNeptuneCluster_serverlessConfiguration === PAUSE TestAccNeptuneCluster_serverlessConfiguration === RUN TestAccNeptuneCluster_takeFinalSnapshot === PAUSE TestAccNeptuneCluster_takeFinalSnapshot === RUN TestAccNeptuneCluster_tags === PAUSE TestAccNeptuneCluster_tags === RUN TestAccNeptuneCluster_updateIAMRoles === PAUSE TestAccNeptuneCluster_updateIAMRoles === RUN TestAccNeptuneCluster_kmsKey === PAUSE TestAccNeptuneCluster_kmsKey === RUN TestAccNeptuneCluster_encrypted === PAUSE TestAccNeptuneCluster_encrypted === RUN TestAccNeptuneCluster_backupsUpdate === PAUSE TestAccNeptuneCluster_backupsUpdate === RUN TestAccNeptuneCluster_iamAuth === PAUSE TestAccNeptuneCluster_iamAuth === RUN TestAccNeptuneCluster_updateCloudWatchLogsExports === PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports === RUN TestAccNeptuneCluster_updateEngineVersion === PAUSE TestAccNeptuneCluster_updateEngineVersion === RUN TestAccNeptuneCluster_updateEngineMajorVersion === PAUSE TestAccNeptuneCluster_updateEngineMajorVersion === RUN TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters === PAUSE TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters === RUN TestAccNeptuneCluster_deleteProtection === PAUSE TestAccNeptuneCluster_deleteProtection === RUN TestAccNeptuneCluster_disappears === PAUSE TestAccNeptuneCluster_disappears === CONT TestAccNeptuneCluster_basic === CONT TestAccNeptuneCluster_backupsUpdate === CONT TestAccNeptuneCluster_updateEngineMajorVersion --- PASS: TestAccNeptuneCluster_basic (193.90s) === CONT TestAccNeptuneCluster_tags --- PASS: TestAccNeptuneCluster_backupsUpdate (227.60s) === CONT TestAccNeptuneCluster_encrypted --- PASS: TestAccNeptuneCluster_tags (180.02s) === CONT TestAccNeptuneCluster_kmsKey --- PASS: TestAccNeptuneCluster_encrypted (171.27s) === CONT TestAccNeptuneCluster_disappears --- PASS: TestAccNeptuneCluster_kmsKey (177.91s) === CONT TestAccNeptuneCluster_deleteProtection --- PASS: TestAccNeptuneCluster_disappears (177.48s) === CONT TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters --- PASS: TestAccNeptuneCluster_deleteProtection (221.62s) === CONT TestAccNeptuneCluster_serverlessConfiguration --- PASS: TestAccNeptuneCluster_serverlessConfiguration (129.39s) === CONT TestAccNeptuneCluster_updateIAMRoles --- PASS: TestAccNeptuneCluster_updateIAMRoles (171.19s) === CONT TestAccNeptuneCluster_takeFinalSnapshot --- PASS: TestAccNeptuneCluster_takeFinalSnapshot (223.40s) === CONT TestAccNeptuneCluster_namePrefix --- PASS: TestAccNeptuneCluster_namePrefix (149.11s) === CONT TestAccNeptuneCluster_updateEngineVersion --- PASS: TestAccNeptuneCluster_updateEngineMajorVersion (1974.41s) === CONT TestAccNeptuneCluster_copyTagsToSnapshot --- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (228.62s) === CONT TestAccNeptuneCluster_iamAuth --- PASS: TestAccNeptuneCluster_iamAuth (141.64s) === CONT TestAccNeptuneCluster_updateCloudWatchLogsExports --- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (249.87s) --- PASS: TestAccNeptuneCluster_updateEngineVersion (1778.42s) --- PASS: TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (3163.49s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 3744.706s

Acceptance test output: % make testacc TESTARGS='-run=TestAccNeptuneGlobalCluster_' PKG=neptune ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneGlobalCluster_ -timeout 180m === RUN TestAccNeptuneGlobalCluster_basic === PAUSE TestAccNeptuneGlobalCluster_basic === RUN TestAccNeptuneGlobalCluster_completeBasic === PAUSE TestAccNeptuneGlobalCluster_completeBasic === RUN TestAccNeptuneGlobalCluster_disappears === PAUSE TestAccNeptuneGlobalCluster_disappears === RUN TestAccNeptuneGlobalCluster_DeletionProtection === PAUSE TestAccNeptuneGlobalCluster_DeletionProtection === RUN TestAccNeptuneGlobalCluster_Engine === PAUSE TestAccNeptuneGlobalCluster_Engine === RUN TestAccNeptuneGlobalCluster_EngineVersion === PAUSE TestAccNeptuneGlobalCluster_EngineVersion === RUN TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic === PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic === RUN TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted === PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted === RUN TestAccNeptuneGlobalCluster_StorageEncrypted === PAUSE TestAccNeptuneGlobalCluster_StorageEncrypted === CONT TestAccNeptuneGlobalCluster_basic === CONT TestAccNeptuneGlobalCluster_EngineVersion === CONT TestAccNeptuneGlobalCluster_DeletionProtection --- PASS: TestAccNeptuneGlobalCluster_basic (19.46s) === CONT TestAccNeptuneGlobalCluster_Engine --- PASS: TestAccNeptuneGlobalCluster_Engine (16.56s) === CONT TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted --- PASS: TestAccNeptuneGlobalCluster_DeletionProtection (60.19s) === CONT TestAccNeptuneGlobalCluster_StorageEncrypted --- PASS: TestAccNeptuneGlobalCluster_StorageEncrypted (30.49s) === CONT TestAccNeptuneGlobalCluster_disappears --- PASS: TestAccNeptuneGlobalCluster_disappears (13.04s) === CONT TestAccNeptuneGlobalCluster_completeBasic --- PASS: TestAccNeptuneGlobalCluster_EngineVersion (1719.98s) === CONT TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic --- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (151.49s) --- PASS: TestAccNeptuneGlobalCluster_completeBasic (154.27s) --- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic (141.40s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 1725.286s

Acceptance test output: % make testacc TESTARGS='-run=TestAccNeptuneClusterSnapshot_' PKG=neptune ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneClusterSnapshot_ -timeout 180m === RUN TestAccNeptuneClusterSnapshot_basic === PAUSE TestAccNeptuneClusterSnapshot_basic === RUN TestAccNeptuneClusterSnapshot_disappears === PAUSE TestAccNeptuneClusterSnapshot_disappears === CONT TestAccNeptuneClusterSnapshot_basic === CONT TestAccNeptuneClusterSnapshot_disappears --- PASS: TestAccNeptuneClusterSnapshot_disappears (295.28s) --- PASS: TestAccNeptuneClusterSnapshot_basic (298.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 303.749s

ewbankkit · 2023-02-11T22:39:50Z

% make testacc TESTARGS='-run=TestAccNeptuneClusterSnapshot_' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneClusterSnapshot_ -timeout 180m
=== RUN   TestAccNeptuneClusterSnapshot_basic
=== PAUSE TestAccNeptuneClusterSnapshot_basic
=== RUN   TestAccNeptuneClusterSnapshot_disappears
=== PAUSE TestAccNeptuneClusterSnapshot_disappears
=== CONT  TestAccNeptuneClusterSnapshot_basic
=== CONT  TestAccNeptuneClusterSnapshot_disappears
--- PASS: TestAccNeptuneClusterSnapshot_disappears (295.28s)
--- PASS: TestAccNeptuneClusterSnapshot_basic (298.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	303.749s
% make testacc TESTARGS='-run=TestAccNeptuneGlobalCluster_' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneGlobalCluster_ -timeout 180m
=== RUN   TestAccNeptuneGlobalCluster_basic
=== PAUSE TestAccNeptuneGlobalCluster_basic
=== RUN   TestAccNeptuneGlobalCluster_completeBasic
=== PAUSE TestAccNeptuneGlobalCluster_completeBasic
=== RUN   TestAccNeptuneGlobalCluster_disappears
=== PAUSE TestAccNeptuneGlobalCluster_disappears
=== RUN   TestAccNeptuneGlobalCluster_DeletionProtection
=== PAUSE TestAccNeptuneGlobalCluster_DeletionProtection
=== RUN   TestAccNeptuneGlobalCluster_Engine
=== PAUSE TestAccNeptuneGlobalCluster_Engine
=== RUN   TestAccNeptuneGlobalCluster_EngineVersion
=== PAUSE TestAccNeptuneGlobalCluster_EngineVersion
=== RUN   TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== RUN   TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccNeptuneGlobalCluster_StorageEncrypted
=== PAUSE TestAccNeptuneGlobalCluster_StorageEncrypted
=== CONT  TestAccNeptuneGlobalCluster_basic
=== CONT  TestAccNeptuneGlobalCluster_EngineVersion
=== CONT  TestAccNeptuneGlobalCluster_DeletionProtection
--- PASS: TestAccNeptuneGlobalCluster_basic (19.46s)
=== CONT  TestAccNeptuneGlobalCluster_Engine
--- PASS: TestAccNeptuneGlobalCluster_Engine (16.56s)
=== CONT  TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
--- PASS: TestAccNeptuneGlobalCluster_DeletionProtection (60.19s)
=== CONT  TestAccNeptuneGlobalCluster_StorageEncrypted
--- PASS: TestAccNeptuneGlobalCluster_StorageEncrypted (30.49s)
=== CONT  TestAccNeptuneGlobalCluster_disappears
--- PASS: TestAccNeptuneGlobalCluster_disappears (13.04s)
=== CONT  TestAccNeptuneGlobalCluster_completeBasic
--- PASS: TestAccNeptuneGlobalCluster_EngineVersion (1719.98s)
=== CONT  TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
--- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (151.49s)
--- PASS: TestAccNeptuneGlobalCluster_completeBasic (154.27s)
--- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic (141.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	1725.286s
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccNeptuneCluster_' PKG=neptune ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneCluster_ -timeout 360m
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_copyTagsToSnapshot
=== PAUSE TestAccNeptuneCluster_copyTagsToSnapshot
=== RUN   TestAccNeptuneCluster_namePrefix
=== PAUSE TestAccNeptuneCluster_namePrefix
=== RUN   TestAccNeptuneCluster_serverlessConfiguration
=== PAUSE TestAccNeptuneCluster_serverlessConfiguration
=== RUN   TestAccNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccNeptuneCluster_tags
=== PAUSE TestAccNeptuneCluster_tags
=== RUN   TestAccNeptuneCluster_updateIAMRoles
=== PAUSE TestAccNeptuneCluster_updateIAMRoles
=== RUN   TestAccNeptuneCluster_kmsKey
=== PAUSE TestAccNeptuneCluster_kmsKey
=== RUN   TestAccNeptuneCluster_encrypted
=== PAUSE TestAccNeptuneCluster_encrypted
=== RUN   TestAccNeptuneCluster_backupsUpdate
=== PAUSE TestAccNeptuneCluster_backupsUpdate
=== RUN   TestAccNeptuneCluster_iamAuth
=== PAUSE TestAccNeptuneCluster_iamAuth
=== RUN   TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== RUN   TestAccNeptuneCluster_updateEngineVersion
=== PAUSE TestAccNeptuneCluster_updateEngineVersion
=== RUN   TestAccNeptuneCluster_updateEngineMajorVersion
=== PAUSE TestAccNeptuneCluster_updateEngineMajorVersion
=== RUN   TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccNeptuneCluster_deleteProtection
=== PAUSE TestAccNeptuneCluster_deleteProtection
=== RUN   TestAccNeptuneCluster_disappears
=== PAUSE TestAccNeptuneCluster_disappears
=== CONT  TestAccNeptuneCluster_basic
=== CONT  TestAccNeptuneCluster_backupsUpdate
=== CONT  TestAccNeptuneCluster_updateEngineMajorVersion
--- PASS: TestAccNeptuneCluster_basic (193.90s)
=== CONT  TestAccNeptuneCluster_tags
--- PASS: TestAccNeptuneCluster_backupsUpdate (227.60s)
=== CONT  TestAccNeptuneCluster_encrypted
--- PASS: TestAccNeptuneCluster_tags (180.02s)
=== CONT  TestAccNeptuneCluster_kmsKey
--- PASS: TestAccNeptuneCluster_encrypted (171.27s)
=== CONT  TestAccNeptuneCluster_disappears
--- PASS: TestAccNeptuneCluster_kmsKey (177.91s)
=== CONT  TestAccNeptuneCluster_deleteProtection
--- PASS: TestAccNeptuneCluster_disappears (177.48s)
=== CONT  TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
--- PASS: TestAccNeptuneCluster_deleteProtection (221.62s)
=== CONT  TestAccNeptuneCluster_serverlessConfiguration
--- PASS: TestAccNeptuneCluster_serverlessConfiguration (129.39s)
=== CONT  TestAccNeptuneCluster_updateIAMRoles
--- PASS: TestAccNeptuneCluster_updateIAMRoles (171.19s)
=== CONT  TestAccNeptuneCluster_takeFinalSnapshot
--- PASS: TestAccNeptuneCluster_takeFinalSnapshot (223.40s)
=== CONT  TestAccNeptuneCluster_namePrefix
--- PASS: TestAccNeptuneCluster_namePrefix (149.11s)
=== CONT  TestAccNeptuneCluster_updateEngineVersion
--- PASS: TestAccNeptuneCluster_updateEngineMajorVersion (1974.41s)
=== CONT  TestAccNeptuneCluster_copyTagsToSnapshot
--- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (228.62s)
=== CONT  TestAccNeptuneCluster_iamAuth
--- PASS: TestAccNeptuneCluster_iamAuth (141.64s)
=== CONT  TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (249.87s)
--- PASS: TestAccNeptuneCluster_updateEngineVersion (1778.42s)
--- PASS: TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (3163.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	3744.706s
% make testacc TESTARGS='-run=TestAccNeptuneClusterInstance_' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneClusterInstance_ -timeout 180m
=== RUN   TestAccNeptuneClusterInstance_basic
=== PAUSE TestAccNeptuneClusterInstance_basic
=== RUN   TestAccNeptuneClusterInstance_disappears
=== PAUSE TestAccNeptuneClusterInstance_disappears
=== RUN   TestAccNeptuneClusterInstance_nameGenerated
=== PAUSE TestAccNeptuneClusterInstance_nameGenerated
=== RUN   TestAccNeptuneClusterInstance_namePrefix
=== PAUSE TestAccNeptuneClusterInstance_namePrefix
=== RUN   TestAccNeptuneClusterInstance_tags
=== PAUSE TestAccNeptuneClusterInstance_tags
=== RUN   TestAccNeptuneClusterInstance_withAZ
=== PAUSE TestAccNeptuneClusterInstance_withAZ
=== RUN   TestAccNeptuneClusterInstance_withSubnetGroup
=== PAUSE TestAccNeptuneClusterInstance_withSubnetGroup
=== RUN   TestAccNeptuneClusterInstance_kmsKey
=== PAUSE TestAccNeptuneClusterInstance_kmsKey
=== CONT  TestAccNeptuneClusterInstance_basic
=== CONT  TestAccNeptuneClusterInstance_tags
=== CONT  TestAccNeptuneClusterInstance_nameGenerated
--- PASS: TestAccNeptuneClusterInstance_basic (1309.76s)
=== CONT  TestAccNeptuneClusterInstance_disappears
--- PASS: TestAccNeptuneClusterInstance_nameGenerated (1384.45s)
=== CONT  TestAccNeptuneClusterInstance_withSubnetGroup
--- PASS: TestAccNeptuneClusterInstance_tags (1410.31s)
--- PASS: TestAccNeptuneClusterInstance_kmsKey (1354.95s)
=== CONT  TestAccNeptuneClusterInstance_withAZ
--- PASS: TestAccNeptuneClusterInstance_withSubnetGroup (1228.83s)
--- PASS: TestAccNeptuneClusterInstance_disappears (1224.74s)
=== CONT  TestAccNeptuneClusterInstance_namePrefix
--- PASS: TestAccNeptuneClusterInstance_withAZ (1219.66s)
--- PASS: TestAccNeptuneClusterInstance_namePrefix (1456.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	3902.197s
% make testacc TESTARGS='-run=TestAccNeptuneCluster_restoreFromSnapshot\|TestAccNeptuneCluster_takeFinalSnapshot' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3  -run=TestAccNeptuneCluster_restoreFromSnapshot\|TestAccNeptuneCluster_takeFinalSnapshot -timeout 180m
=== RUN   TestAccNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccNeptuneCluster_restoreFromSnapshot
=== PAUSE TestAccNeptuneCluster_restoreFromSnapshot
=== CONT  TestAccNeptuneCluster_takeFinalSnapshot
=== CONT  TestAccNeptuneCluster_restoreFromSnapshot
--- PASS: TestAccNeptuneCluster_takeFinalSnapshot (387.12s)
--- PASS: TestAccNeptuneCluster_restoreFromSnapshot (535.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	539.942s

This reverts commit 16b488e.

…date is called, passing the engine-version along to ModifyDBCluster. This will always fail, even when the engine-version has not changed. The solution might be to omit the version from the arguments in case the resource has been freshly created." This reverts commit 0cff00b.

This reverts commit 5445a93.

…ashicorp#11752 (comment)), tags may not be set when the resource is new, since there's no value for arn yet" This reverts commit 482a86e.

Acceptance test output: % make testacc TESTARGS='-run=TestAccNeptuneCluster_restoreFromSnapshot\|TestAccNeptuneCluster_takeFinalSnapshot' PKG=neptune ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneCluster_restoreFromSnapshot\|TestAccNeptuneCluster_takeFinalSnapshot -timeout 180m === RUN TestAccNeptuneCluster_takeFinalSnapshot === PAUSE TestAccNeptuneCluster_takeFinalSnapshot === RUN TestAccNeptuneCluster_restoreFromSnapshot === PAUSE TestAccNeptuneCluster_restoreFromSnapshot === CONT TestAccNeptuneCluster_takeFinalSnapshot === CONT TestAccNeptuneCluster_restoreFromSnapshot --- PASS: TestAccNeptuneCluster_takeFinalSnapshot (387.12s) --- PASS: TestAccNeptuneCluster_restoreFromSnapshot (535.02s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 539.942s

ewbankkit · 2023-02-13T13:04:34Z

@DrFaust92 Thanks for the contribution 🎉 👏.

github-actions · 2023-02-17T18:36:46Z

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-03-20T02:16:31Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

danielcweber added 4 commits July 25, 2022 22:43

Attempt to fix hashicorp#11752. As noted [here by @chungath](hashicor…

482a86e

…p#11752 (comment)), tags may not be set when the resource is new, since there's no value for arn yet

Add changelog.

5445a93

Add changelog.

16b488e

DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 28, 2022

DrFaust92 marked this pull request as ready for review November 28, 2022 19:27

ran2806 reviewed Nov 29, 2022

View reviewed changes

github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 29, 2022

ewbankkit approved these changes Nov 29, 2022

View reviewed changes

DrFaust92 added 2 commits December 13, 2022 23:14

update fix

289edbc

changelog

4136972

DrFaust92 force-pushed the neptune-update branch from c2e6673 to 4136972 Compare December 13, 2022 21:15

ewbankkit added 7 commits February 10, 2023 10:49

Merge branch 'main' into HEAD

44f4eee

r/aws_neptune_cluster: Add 'neptune_instance_parameter_group_name' ar…

36de6fa

…gument.

Fix golangci-lint 'unparam'.

80bf773

github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 11, 2023

ewbankkit added 8 commits February 11, 2023 17:56

Revert "Add changelog."

a68d200

This reverts commit 16b488e.

Revert "Add changelog."

8729b22

This reverts commit 5445a93.

Revert "Attempt to fix hashicorp#11752. As noted [here by @chungath](h…

2b53e50

…ashicorp#11752 (comment)), tags may not be set when the resource is new, since there's no value for arn yet" This reverts commit 482a86e.

Merge commit '25eaa0e37acc26a89c17b921d420af44e58e249d' into HEAD

34f5228

Merge commit '2b53e5086405abd6d28bdf1c3fad835eb8009175' into HEAD

a4fb71d

Fix terrafmt error.

3e2e767

Fix Neptune sweeper compilation error.

dfc3147

This was referenced Feb 12, 2023

Attempt to fix #11752. #25972

Merged

Attempt to fix #23601 #25982

Closed

github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Feb 12, 2023

Fix terrafmt error.

2fb2034

ewbankkit merged commit 6c8da7a into hashicorp:main Feb 13, 2023

github-actions bot added this to the v4.55.0 milestone Feb 13, 2023

kastlbo mentioned this pull request Mar 3, 2023

[Bug]: Neputne_cluster. Fix Major Version Upgrade from 1.1.1.0 to 1.2.0.0 #29785

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/neptune_cluster - fix major version upgrade #28051

r/neptune_cluster - fix major version upgrade #28051

DrFaust92 commented Nov 28, 2022 •

edited by ewbankkit

Loading

github-actions bot commented Nov 28, 2022

ran2806 left a comment

ran2806 commented Nov 29, 2022

ewbankkit left a comment

ewbankkit commented Nov 29, 2022

ran2806 commented Nov 30, 2022

DrFaust92 commented Dec 3, 2022

ewbankkit commented Feb 11, 2023 •

edited

Loading

ewbankkit commented Feb 13, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Mar 20, 2023

r/neptune_cluster - fix major version upgrade #28051

r/neptune_cluster - fix major version upgrade #28051

Conversation

DrFaust92 commented Nov 28, 2022 • edited by ewbankkit Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Nov 28, 2022

Community Note

ran2806 left a comment

Choose a reason for hiding this comment

ran2806 commented Nov 29, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Nov 29, 2022

ran2806 commented Nov 30, 2022

DrFaust92 commented Dec 3, 2022

ewbankkit commented Feb 11, 2023 • edited Loading

ewbankkit commented Feb 13, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Mar 20, 2023

DrFaust92 commented Nov 28, 2022 •

edited by ewbankkit

Loading

ewbankkit commented Feb 11, 2023 •

edited

Loading