Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshiftserverless_namespace - fix user/pass update #28125

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 1, 2022

Description

Relations

Closes #28122

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRedshiftServerlessNamespace_ PKG=redshiftserverless
--- PASS: TestAccRedshiftServerlessNamespace_disappears (20.45s)
--- PASS: TestAccRedshiftServerlessNamespace_user (47.28s)
--- PASS: TestAccRedshiftServerlessNamespace_basic (51.88s)
--- PASS: TestAccRedshiftServerlessNamespace_tags (62.37s)

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Dec 1, 2022
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 1, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review December 1, 2022 18:10
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Dec 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftServerlessNamespace_' PKG=redshiftserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 2  -run=TestAccRedshiftServerlessNamespace_ -timeout 180m
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_user
=== PAUSE TestAccRedshiftServerlessNamespace_user
=== RUN   TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN   TestAccRedshiftServerlessNamespace_disappears
=== PAUSE TestAccRedshiftServerlessNamespace_disappears
=== CONT  TestAccRedshiftServerlessNamespace_basic
=== CONT  TestAccRedshiftServerlessNamespace_tags
--- PASS: TestAccRedshiftServerlessNamespace_basic (29.93s)
=== CONT  TestAccRedshiftServerlessNamespace_disappears
--- PASS: TestAccRedshiftServerlessNamespace_tags (39.13s)
=== CONT  TestAccRedshiftServerlessNamespace_user
--- PASS: TestAccRedshiftServerlessNamespace_disappears (12.67s)
--- PASS: TestAccRedshiftServerlessNamespace_user (27.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	71.133s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 794a765 into hashicorp:main Dec 1, 2022
@github-actions github-actions bot added this to the v4.45.0 milestone Dec 1, 2022
@meetvasu15
Copy link

@DrFaust92, @ewbankkit Appreciate the quick turn around!

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants