Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_rum_metrics_destination - new resource #28143

Merged
merged 6 commits into from
Dec 8, 2022
Merged

r/aws_rum_metrics_destination - new resource #28143

merged 6 commits into from
Dec 8, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 2, 2022 •
edited by ewbankkit

Description

Relations

Relates #22201.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRUMMetricsDestination_ PKG=rum
--- PASS: TestAccRUMMetricsDestination_disappears_appMonitor (26.10s)
--- PASS: TestAccRUMMetricsDestination_disappears (28.46s)
--- PASS: TestAccRUMMetricsDestination_basic (33.77s)

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/rum Issues and PRs that pertain to the rum service. needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/rum Issues and PRs that pertain to the rum service. labels Dec 2, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/rum Issues and PRs that pertain to the rum service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 2, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. labels Dec 2, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review December 2, 2022 15:54
@ewbankkit
'FindMetricsDestinationsByName' -> 'FindMetricsDestinationByName'.
4bf76c9
@ewbankkit
r/aws_rum_app_monitor: Switch to 'WithoutTimeout' CRUD handlers (hash…
6e08655 
…icorp#15090).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRUMAppMonitor_' PKG=rum ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3  -run=TestAccRUMAppMonitor_ -timeout 180m
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_disappears (15.75s)
--- PASS: TestAccRUMAppMonitor_basic (31.95s)
--- PASS: TestAccRUMAppMonitor_tags (41.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	46.586s
@ewbankkit
r/aws_rum_metrics_destination: Switch to 'WithoutTimeout' CRUD handle…
cd8b30c 
…rs (hashicorp#15090).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRUMMetricsDestination_' PKG=rum ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3  -run=TestAccRUMMetricsDestination_ -timeout 180m
=== RUN   TestAccRUMMetricsDestination_basic
=== PAUSE TestAccRUMMetricsDestination_basic
=== RUN   TestAccRUMMetricsDestination_disappears
=== PAUSE TestAccRUMMetricsDestination_disappears
=== RUN   TestAccRUMMetricsDestination_disappears_appMonitor
=== PAUSE TestAccRUMMetricsDestination_disappears_appMonitor
=== CONT  TestAccRUMMetricsDestination_basic
=== CONT  TestAccRUMMetricsDestination_disappears_appMonitor
=== CONT  TestAccRUMMetricsDestination_disappears
--- PASS: TestAccRUMMetricsDestination_disappears_appMonitor (16.24s)
--- PASS: TestAccRUMMetricsDestination_disappears (18.22s)
--- PASS: TestAccRUMMetricsDestination_basic (20.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	25.636s
ewbankkit
ewbankkit approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRUMMetricsDestination_' PKG=rum ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3  -run=TestAccRUMMetricsDestination_ -timeout 180m
=== RUN   TestAccRUMMetricsDestination_basic
=== PAUSE TestAccRUMMetricsDestination_basic
=== RUN   TestAccRUMMetricsDestination_disappears
=== PAUSE TestAccRUMMetricsDestination_disappears
=== RUN   TestAccRUMMetricsDestination_disappears_appMonitor
=== PAUSE TestAccRUMMetricsDestination_disappears_appMonitor
=== CONT  TestAccRUMMetricsDestination_basic
=== CONT  TestAccRUMMetricsDestination_disappears
=== CONT  TestAccRUMMetricsDestination_disappears_appMonitor
--- PASS: TestAccRUMMetricsDestination_disappears_appMonitor (16.28s)
--- PASS: TestAccRUMMetricsDestination_disappears (18.11s)
--- PASS: TestAccRUMMetricsDestination_basic (20.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	25.794s
% make testacc TESTARGS='-run=TestAccRUMAppMonitor_' PKG=rum ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3  -run=TestAccRUMAppMonitor_ -timeout 180m
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_disappears (15.75s)
--- PASS: TestAccRUMAppMonitor_basic (31.95s)
--- PASS: TestAccRUMAppMonitor_tags (41.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	46.586s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e5ac56b into hashicorp:main Dec 8, 2022
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/rum Issues and PRs that pertain to the rum service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.46.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrFaust92 @ewbankkit