-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/glue_crawler - add args to targets #28156
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGlueCrawler_' PKG=glue ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 3 -run=TestAccGlueCrawler_ -timeout 180m
=== RUN TestAccGlueCrawler_dynamoDBTarget
=== PAUSE TestAccGlueCrawler_dynamoDBTarget
=== RUN TestAccGlueCrawler_DynamoDBTarget_scanAll
=== PAUSE TestAccGlueCrawler_DynamoDBTarget_scanAll
=== RUN TestAccGlueCrawler_DynamoDBTarget_scanRate
=== PAUSE TestAccGlueCrawler_DynamoDBTarget_scanRate
=== RUN TestAccGlueCrawler_jdbcTarget
=== PAUSE TestAccGlueCrawler_jdbcTarget
=== RUN TestAccGlueCrawler_JDBCTarget_exclusions
=== PAUSE TestAccGlueCrawler_JDBCTarget_exclusions
=== RUN TestAccGlueCrawler_JDBCTarget_multiple
=== PAUSE TestAccGlueCrawler_JDBCTarget_multiple
=== RUN TestAccGlueCrawler_mongoDBTarget
=== PAUSE TestAccGlueCrawler_mongoDBTarget
=== RUN TestAccGlueCrawler_MongoDBTargetScan_all
=== PAUSE TestAccGlueCrawler_MongoDBTargetScan_all
=== RUN TestAccGlueCrawler_MongoDBTarget_multiple
=== PAUSE TestAccGlueCrawler_MongoDBTarget_multiple
=== RUN TestAccGlueCrawler_deltaTarget
=== PAUSE TestAccGlueCrawler_deltaTarget
=== RUN TestAccGlueCrawler_s3Target
=== PAUSE TestAccGlueCrawler_s3Target
=== RUN TestAccGlueCrawler_S3Target_connectionName
=== PAUSE TestAccGlueCrawler_S3Target_connectionName
=== RUN TestAccGlueCrawler_S3Target_sampleSize
=== PAUSE TestAccGlueCrawler_S3Target_sampleSize
=== RUN TestAccGlueCrawler_S3Target_exclusions
=== PAUSE TestAccGlueCrawler_S3Target_exclusions
=== RUN TestAccGlueCrawler_S3Target_eventqueue
=== PAUSE TestAccGlueCrawler_S3Target_eventqueue
=== RUN TestAccGlueCrawler_CatalogTarget_dlqeventqueue
=== PAUSE TestAccGlueCrawler_CatalogTarget_dlqeventqueue
=== RUN TestAccGlueCrawler_S3Target_dlqeventqueue
=== PAUSE TestAccGlueCrawler_S3Target_dlqeventqueue
=== RUN TestAccGlueCrawler_S3Target_multiple
=== PAUSE TestAccGlueCrawler_S3Target_multiple
=== RUN TestAccGlueCrawler_catalogTarget
=== PAUSE TestAccGlueCrawler_catalogTarget
=== RUN TestAccGlueCrawler_CatalogTarget_multiple
=== PAUSE TestAccGlueCrawler_CatalogTarget_multiple
=== RUN TestAccGlueCrawler_disappears
=== PAUSE TestAccGlueCrawler_disappears
=== RUN TestAccGlueCrawler_classifiers
=== PAUSE TestAccGlueCrawler_classifiers
=== RUN TestAccGlueCrawler_Configuration
=== PAUSE TestAccGlueCrawler_Configuration
=== RUN TestAccGlueCrawler_description
=== PAUSE TestAccGlueCrawler_description
=== RUN TestAccGlueCrawler_RoleARN_noPath
=== PAUSE TestAccGlueCrawler_RoleARN_noPath
=== RUN TestAccGlueCrawler_RoleARN_path
=== PAUSE TestAccGlueCrawler_RoleARN_path
=== RUN TestAccGlueCrawler_RoleName_path
=== PAUSE TestAccGlueCrawler_RoleName_path
=== RUN TestAccGlueCrawler_schedule
=== PAUSE TestAccGlueCrawler_schedule
=== RUN TestAccGlueCrawler_schemaChangePolicy
=== PAUSE TestAccGlueCrawler_schemaChangePolicy
=== RUN TestAccGlueCrawler_tablePrefix
=== PAUSE TestAccGlueCrawler_tablePrefix
=== RUN TestAccGlueCrawler_removeTablePrefix
=== PAUSE TestAccGlueCrawler_removeTablePrefix
=== RUN TestAccGlueCrawler_tags
=== PAUSE TestAccGlueCrawler_tags
=== RUN TestAccGlueCrawler_security
=== PAUSE TestAccGlueCrawler_security
=== RUN TestAccGlueCrawler_lineage
=== PAUSE TestAccGlueCrawler_lineage
=== RUN TestAccGlueCrawler_lakeformation
=== PAUSE TestAccGlueCrawler_lakeformation
=== RUN TestAccGlueCrawler_reCrawlPolicy
=== PAUSE TestAccGlueCrawler_reCrawlPolicy
=== CONT TestAccGlueCrawler_dynamoDBTarget
=== CONT TestAccGlueCrawler_reCrawlPolicy
=== CONT TestAccGlueCrawler_security
--- PASS: TestAccGlueCrawler_dynamoDBTarget (45.51s)
=== CONT TestAccGlueCrawler_lakeformation
--- PASS: TestAccGlueCrawler_security (46.26s)
=== CONT TestAccGlueCrawler_lineage
--- PASS: TestAccGlueCrawler_reCrawlPolicy (59.26s)
=== CONT TestAccGlueCrawler_S3Target_dlqeventqueue
--- PASS: TestAccGlueCrawler_lakeformation (42.77s)
=== CONT TestAccGlueCrawler_tags
--- PASS: TestAccGlueCrawler_lineage (55.42s)
=== CONT TestAccGlueCrawler_removeTablePrefix
--- PASS: TestAccGlueCrawler_S3Target_dlqeventqueue (67.40s)
=== CONT TestAccGlueCrawler_tablePrefix
--- PASS: TestAccGlueCrawler_tags (56.26s)
=== CONT TestAccGlueCrawler_schemaChangePolicy
--- PASS: TestAccGlueCrawler_removeTablePrefix (43.41s)
=== CONT TestAccGlueCrawler_schedule
--- PASS: TestAccGlueCrawler_tablePrefix (44.20s)
=== CONT TestAccGlueCrawler_RoleName_path
--- PASS: TestAccGlueCrawler_schemaChangePolicy (44.26s)
=== CONT TestAccGlueCrawler_RoleARN_path
--- PASS: TestAccGlueCrawler_RoleName_path (30.68s)
=== CONT TestAccGlueCrawler_RoleARN_noPath
--- PASS: TestAccGlueCrawler_schedule (57.83s)
=== CONT TestAccGlueCrawler_description
--- PASS: TestAccGlueCrawler_RoleARN_path (27.95s)
=== CONT TestAccGlueCrawler_Configuration
--- PASS: TestAccGlueCrawler_RoleARN_noPath (28.54s)
=== CONT TestAccGlueCrawler_classifiers
--- PASS: TestAccGlueCrawler_description (41.54s)
=== CONT TestAccGlueCrawler_disappears
--- PASS: TestAccGlueCrawler_disappears (26.04s)
=== CONT TestAccGlueCrawler_CatalogTarget_multiple
--- PASS: TestAccGlueCrawler_Configuration (54.46s)
=== CONT TestAccGlueCrawler_catalogTarget
--- PASS: TestAccGlueCrawler_classifiers (56.24s)
=== CONT TestAccGlueCrawler_S3Target_multiple
--- PASS: TestAccGlueCrawler_catalogTarget (51.31s)
=== CONT TestAccGlueCrawler_MongoDBTarget_multiple
--- PASS: TestAccGlueCrawler_S3Target_multiple (54.58s)
=== CONT TestAccGlueCrawler_CatalogTarget_dlqeventqueue
--- PASS: TestAccGlueCrawler_CatalogTarget_multiple (72.72s)
=== CONT TestAccGlueCrawler_S3Target_eventqueue
--- PASS: TestAccGlueCrawler_MongoDBTarget_multiple (56.01s)
=== CONT TestAccGlueCrawler_S3Target_exclusions
--- PASS: TestAccGlueCrawler_CatalogTarget_dlqeventqueue (49.72s)
=== CONT TestAccGlueCrawler_S3Target_sampleSize
--- PASS: TestAccGlueCrawler_S3Target_eventqueue (58.53s)
=== CONT TestAccGlueCrawler_S3Target_connectionName
--- PASS: TestAccGlueCrawler_S3Target_exclusions (40.69s)
=== CONT TestAccGlueCrawler_s3Target
--- PASS: TestAccGlueCrawler_S3Target_connectionName (32.35s)
=== CONT TestAccGlueCrawler_deltaTarget
--- PASS: TestAccGlueCrawler_S3Target_sampleSize (49.84s)
=== CONT TestAccGlueCrawler_JDBCTarget_exclusions
--- PASS: TestAccGlueCrawler_s3Target (41.61s)
=== CONT TestAccGlueCrawler_MongoDBTargetScan_all
--- PASS: TestAccGlueCrawler_deltaTarget (41.07s)
=== CONT TestAccGlueCrawler_mongoDBTarget
--- PASS: TestAccGlueCrawler_JDBCTarget_exclusions (43.48s)
=== CONT TestAccGlueCrawler_JDBCTarget_multiple
--- PASS: TestAccGlueCrawler_MongoDBTargetScan_all (55.45s)
=== CONT TestAccGlueCrawler_DynamoDBTarget_scanRate
--- PASS: TestAccGlueCrawler_mongoDBTarget (51.04s)
=== CONT TestAccGlueCrawler_jdbcTarget
--- PASS: TestAccGlueCrawler_JDBCTarget_multiple (59.59s)
=== CONT TestAccGlueCrawler_DynamoDBTarget_scanAll
--- PASS: TestAccGlueCrawler_DynamoDBTarget_scanRate (69.82s)
--- PASS: TestAccGlueCrawler_jdbcTarget (59.97s)
--- PASS: TestAccGlueCrawler_DynamoDBTarget_scanAll (67.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 615.506s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #27331
Closes #27745
References
Output from Acceptance Testing