Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dms/s3_endpoint: Different attributes by region #28220

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 6, 2022

Description

Relations

Relates #28130
Closes #28221

References

Output from Acceptance Testing

us-east-1

% make testacc TESTS=TestAccDMSS3Endpoint_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSS3Endpoint_'  -timeout 180m
--- PASS: TestAccDMSS3Endpoint_basic (42.40s)
--- PASS: TestAccDMSS3Endpoint_simple (42.74s)
--- PASS: TestAccDMSS3Endpoint_sourceSimple (53.98s)
--- PASS: TestAccDMSS3Endpoint_update (56.22s)
--- PASS: TestAccDMSS3Endpoint_source (56.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	58.378s

us-east-2

% make testacc TESTS=TestAccDMSS3Endpoint_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSS3Endpoint_'  -timeout 180m
--- PASS: TestAccDMSS3Endpoint_sourceSimple (37.04s)
--- PASS: TestAccDMSS3Endpoint_source (37.07s)
--- PASS: TestAccDMSS3Endpoint_simple (37.81s)
--- PASS: TestAccDMSS3Endpoint_basic (39.84s)
--- PASS: TestAccDMSS3Endpoint_update (52.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	54.024s

us-west-2

% make testacc TESTS=TestAccDMSS3Endpoint_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSS3Endpoint_'  -timeout 180m
--- PASS: TestAccDMSS3Endpoint_simple (45.58s)
--- PASS: TestAccDMSS3Endpoint_basic (46.41s)
--- PASS: TestAccDMSS3Endpoint_sourceSimple (56.22s)
--- PASS: TestAccDMSS3Endpoint_source (66.17s)
--- PASS: TestAccDMSS3Endpoint_update (68.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	69.639s

us-gov-west-1

% make testacc TESTS=TestAccDMSS3Endpoint_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSS3Endpoint_'  -timeout 180m
--- PASS: TestAccDMSS3Endpoint_basic (129.35s)
--- PASS: TestAccDMSS3Endpoint_simple (138.94s)
--- PASS: TestAccDMSS3Endpoint_update (148.33s)
--- PASS: TestAccDMSS3Endpoint_sourceSimple (152.65s)
--- PASS: TestAccDMSS3Endpoint_source (154.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	156.036s

@github-actions github-actions bot added the size/S Managed by automation to categorize the size of a PR. label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 6, 2022
@YakDriver YakDriver merged commit 9813089 into main Dec 6, 2022
@YakDriver YakDriver deleted the b-dms-endpoint-errors-region branch December 6, 2022 20:59
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 6, 2022
github-actions bot pushed a commit that referenced this pull request Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_dms_s3_endpoint: InvalidParameterValueException
1 participant