-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aws_ssoadmin_permissions_boundary_attachment resource #28241
add aws_ssoadmin_permissions_boundary_attachment resource #28241
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @atkretsch 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSSOAdminPermissionsBoundaryAttachment_' PKG=ssoadmin ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 3 -run=TestAccSSOAdminPermissionsBoundaryAttachment_ -timeout 180m
=== RUN TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== RUN TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
=== RUN TestAccSSOAdminPermissionsBoundaryAttachment_disappears
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_disappears (27.53s)
=== RUN TestAccSSOAdminPermissionsBoundaryAttachment_Disappears_permissionSet
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_Disappears_permissionSet (19.98s)
=== RUN TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== CONT TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== CONT TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== CONT TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined (8.85s)
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_basic (29.68s)
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_forceNew (52.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin 105.719s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Also confirmed status checks have passed on this branch, although they are not currently displaying on the latest commit.
Thanks for your contribution @atkretsch! |
This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a
aws_ssoadmin_permissions_boundary_attachment
resource to enable attaching a permissions boundary to a permission set. Example usage:This is my first contribution, so if I've failed to follow any important conventions in the code, documentation, or this PR itself, please let me know!
Relations
Closes #25893
Output from Acceptance Testing