Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_ssoadmin_permissions_boundary_attachment resource #28241

Merged

Conversation

atkretsch
Copy link
Contributor

Description

Adds a aws_ssoadmin_permissions_boundary_attachment resource to enable attaching a permissions boundary to a permission set. Example usage:

resource "aws_ssoadmin_permissions_boundary_attachment" "example" {
  instance_arn       = aws_ssoadmin_permission_set.example.instance_arn
  permission_set_arn = aws_ssoadmin_permission_set.example.arn
  permissions_boundary {
    customer_managed_policy_reference {
      name = aws_iam_policy.example.name
      path = "/"
    }
  }
}

This is my first contribution, so if I've failed to follow any important conventions in the code, documentation, or this PR itself, please let me know!

Relations

Closes #25893

Output from Acceptance Testing

$ make testacc TESTS=TestAccSSOAdminPermissionsBoundaryAttachment_ PKG=ssoadmin 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.19 test ./internal/service/ssoadmin/... -v -count 1 -parallel 20 -run='TestAccSSOAdminPermissionsBoundaryAttachment_'  -timeout 180m
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_disappears
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_disappears (39.21s)
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_Disappears_permissionSet
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_Disappears_permissionSet (32.64s)
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== CONT  TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== CONT  TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== CONT  TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined (16.58s)
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_basic (45.94s)
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_forceNew (77.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	151.866s

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Dec 7, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @atkretsch 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Dec 9, 2022
@jar-b jar-b self-assigned this Dec 13, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSOAdminPermissionsBoundaryAttachment_' PKG=ssoadmin ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 3  -run=TestAccSSOAdminPermissionsBoundaryAttachment_ -timeout 180m
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_disappears
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_disappears (27.53s)
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_Disappears_permissionSet
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_Disappears_permissionSet (19.98s)
=== RUN   TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== PAUSE TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== CONT  TestAccSSOAdminPermissionsBoundaryAttachment_basic
=== CONT  TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined
=== CONT  TestAccSSOAdminPermissionsBoundaryAttachment_forceNew
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_managedPolicyAndCustomerManagedPolicyRefBothDefined (8.85s)
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_basic (29.68s)
--- PASS: TestAccSSOAdminPermissionsBoundaryAttachment_forceNew (52.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	105.719s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Also confirmed status checks have passed on this branch, although they are not currently displaying on the latest commit.

image

https://github.com/hashicorp/terraform-provider-aws/actions?query=branch%3Af-aws_ssoadmin_permissions_boundary_attachment+actor%3Ajar-b

@jar-b jar-b merged commit bfcd55c into hashicorp:main Dec 13, 2022
@jar-b
Copy link
Member

jar-b commented Dec 13, 2022

Thanks for your contribution @atkretsch!

@github-actions github-actions bot added this to the v4.47.0 milestone Dec 13, 2022
@github-actions
Copy link

This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO: Support for permission boundary policies
3 participants