-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_eks_addon with custom configuration_values #28295
aws_eks_addon with custom configuration_values #28295
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSAddon_configurationValues\|TestAccEKSAddon_basic\|TestAccEKSAddonDataSource_' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2 -run=TestAccEKSAddon_configurationValues\|TestAccEKSAddon_basic\|TestAccEKSAddonDataSource_ -timeout 180m
=== RUN TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== RUN TestAccEKSAddonDataSource_configurationValues
=== PAUSE TestAccEKSAddonDataSource_configurationValues
=== RUN TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN TestAccEKSAddon_configurationValues
=== PAUSE TestAccEKSAddon_configurationValues
=== CONT TestAccEKSAddonDataSource_basic
=== CONT TestAccEKSAddon_basic
--- PASS: TestAccEKSAddon_basic (645.38s)
=== CONT TestAccEKSAddonDataSource_configurationValues
--- PASS: TestAccEKSAddonDataSource_basic (720.78s)
=== CONT TestAccEKSAddon_configurationValues
--- PASS: TestAccEKSAddonDataSource_configurationValues (747.90s)
--- PASS: TestAccEKSAddon_configurationValues (714.50s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 1440.696s
@vara-bonthu Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
AWS EKS team recently launched a new feature to pass the custom
configuration_values
for EKS managed add-ons. This feature allows users to pass theconfiguration_values
while creating or updating the EKS addon.EKS API config
configurationValues
createAddon -> https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateAddon.html
updateAddon -> https://docs.aws.amazon.com/eks/latest/APIReference/API_UpdateAddon.html
Check the output of the below API
describeAddon -> https://docs.aws.amazon.com/eks/latest/APIReference/API_DescribeAddon.html
This implements and solves #28287
Relations
Closes #28287.
Closes #28374.
References
Output from Acceptance Testing
Data Source test results