-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS Service Connect Fixes #28338
ECS Service Connect Fixes #28338
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @dragondgold 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSCapacityProvider_\|TestAccECSTaskSet_withCapacityProviderStrategy\|TestAccECSCluster_singleCapacityProvider\|TestAccECSService_CapacityProviderStrategy' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSCapacityProvider_\|TestAccECSTaskSet_withCapacityProviderStrategy\|TestAccECSCluster_singleCapacityProvider\|TestAccECSService_CapacityProviderStrategy -timeout 180m === RUN TestAccECSCapacityProvider_basic === PAUSE TestAccECSCapacityProvider_basic === RUN TestAccECSCapacityProvider_disappears === PAUSE TestAccECSCapacityProvider_disappears === RUN TestAccECSCapacityProvider_managedScaling === PAUSE TestAccECSCapacityProvider_managedScaling === RUN TestAccECSCapacityProvider_managedScalingPartial === PAUSE TestAccECSCapacityProvider_managedScalingPartial === RUN TestAccECSCapacityProvider_tags === PAUSE TestAccECSCapacityProvider_tags === RUN TestAccECSCluster_singleCapacityProvider === PAUSE TestAccECSCluster_singleCapacityProvider === RUN TestAccECSService_CapacityProviderStrategy_basic === PAUSE TestAccECSService_CapacityProviderStrategy_basic === RUN TestAccECSService_CapacityProviderStrategy_forceNewDeployment === PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment === RUN TestAccECSService_CapacityProviderStrategy_update === PAUSE TestAccECSService_CapacityProviderStrategy_update === RUN TestAccECSService_CapacityProviderStrategy_multiple === PAUSE TestAccECSService_CapacityProviderStrategy_multiple === RUN TestAccECSTaskSet_withCapacityProviderStrategy === PAUSE TestAccECSTaskSet_withCapacityProviderStrategy === CONT TestAccECSCapacityProvider_basic === CONT TestAccECSService_CapacityProviderStrategy_basic === CONT TestAccECSService_CapacityProviderStrategy_multiple --- PASS: TestAccECSCapacityProvider_basic (63.86s) === CONT TestAccECSTaskSet_withCapacityProviderStrategy --- PASS: TestAccECSService_CapacityProviderStrategy_basic (178.59s) === CONT TestAccECSCapacityProvider_managedScalingPartial --- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (138.32s) === CONT TestAccECSCluster_singleCapacityProvider --- PASS: TestAccECSCapacityProvider_managedScalingPartial (64.93s) === CONT TestAccECSCapacityProvider_tags --- PASS: TestAccECSCluster_singleCapacityProvider (66.40s) === CONT TestAccECSCapacityProvider_disappears --- PASS: TestAccECSCapacityProvider_disappears (57.78s) === CONT TestAccECSService_CapacityProviderStrategy_update --- PASS: TestAccECSCapacityProvider_tags (100.91s) === CONT TestAccECSService_CapacityProviderStrategy_forceNewDeployment --- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (149.76s) === CONT TestAccECSCapacityProvider_managedScaling --- PASS: TestAccECSCapacityProvider_managedScaling (101.31s) --- PASS: TestAccECSService_CapacityProviderStrategy_update (286.03s) --- PASS: TestAccECSService_CapacityProviderStrategy_multiple (928.49s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 933.264s
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_loadBalancerChanges' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_loadBalancerChanges -timeout 180m === RUN TestAccECSService_loadBalancerChanges === PAUSE TestAccECSService_loadBalancerChanges === CONT TestAccECSService_loadBalancerChanges --- PASS: TestAccECSService_loadBalancerChanges (203.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 208.352s
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_LaunchTypeFargate' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_LaunchTypeFargate -timeout 180m === RUN TestAccECSService_LaunchTypeFargate_basic === PAUSE TestAccECSService_LaunchTypeFargate_basic === RUN TestAccECSService_LaunchTypeFargate_platformVersion === PAUSE TestAccECSService_LaunchTypeFargate_platformVersion === RUN TestAccECSService_LaunchTypeFargate_waitForSteadyState === PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState === RUN TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState === PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState === CONT TestAccECSService_LaunchTypeFargate_basic === CONT TestAccECSService_LaunchTypeFargate_waitForSteadyState === CONT TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState --- PASS: TestAccECSService_LaunchTypeFargate_basic (142.64s) === CONT TestAccECSService_LaunchTypeFargate_platformVersion --- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (164.68s) --- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (178.50s) --- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (148.85s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 296.246s
…y_update'. Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_CapacityProviderStrategy_update' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_CapacityProviderStrategy_update -timeout 180m === RUN TestAccECSService_CapacityProviderStrategy_update === PAUSE TestAccECSService_CapacityProviderStrategy_update === CONT TestAccECSService_CapacityProviderStrategy_update --- PASS: TestAccECSService_CapacityProviderStrategy_update (317.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 322.718s
…e_codeDeploy*'. Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_DeploymentControllerType_codeDeploy' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_DeploymentControllerType_codeDeploy -timeout 180m === RUN TestAccECSService_DeploymentControllerType_codeDeploy === PAUSE TestAccECSService_DeploymentControllerType_codeDeploy === RUN TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod === PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod === CONT TestAccECSService_DeploymentControllerType_codeDeploy === CONT TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod --- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (230.35s) --- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (413.50s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 419.245s
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_ServiceRegistries' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_ServiceRegistries -timeout 180m === RUN TestAccECSService_ServiceRegistries_basic === PAUSE TestAccECSService_ServiceRegistries_basic === RUN TestAccECSService_ServiceRegistries_container === PAUSE TestAccECSService_ServiceRegistries_container === RUN TestAccECSService_ServiceRegistries_changes === PAUSE TestAccECSService_ServiceRegistries_changes === CONT TestAccECSService_ServiceRegistries_basic === CONT TestAccECSService_ServiceRegistries_changes === CONT TestAccECSService_ServiceRegistries_container --- PASS: TestAccECSService_ServiceRegistries_basic (175.82s) --- PASS: TestAccECSService_ServiceRegistries_container (176.43s) --- PASS: TestAccECSService_ServiceRegistries_changes (297.49s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 302.722s
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_LaunchTypeEC2_network' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_LaunchTypeEC2_network -timeout 180m === RUN TestAccECSService_LaunchTypeEC2_network === PAUSE TestAccECSService_LaunchTypeEC2_network === CONT TestAccECSService_LaunchTypeEC2_network --- PASS: TestAccECSService_LaunchTypeEC2_network (92.90s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 99.065s
…nd 'TestAccECSService_alb'. Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_multipleTargetGroups\|TestAccECSService_alb' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_multipleTargetGroups\|TestAccECSService_alb -timeout 180m === RUN TestAccECSService_alb === PAUSE TestAccECSService_alb === RUN TestAccECSService_multipleTargetGroups === PAUSE TestAccECSService_multipleTargetGroups === CONT TestAccECSService_alb === CONT TestAccECSService_multipleTargetGroups --- PASS: TestAccECSService_multipleTargetGroups (236.20s) --- PASS: TestAccECSService_alb (236.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 242.113s
…verride'. Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_ServiceConnect_ingressPortOverride' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_ServiceConnect_ingressPortOverride -timeout 180m === RUN TestAccECSService_ServiceConnect_ingressPortOverride === PAUSE TestAccECSService_ServiceConnect_ingressPortOverride === CONT TestAccECSService_ServiceConnect_ingressPortOverride service_test.go:1225: Step 1/1 error: Error running apply: exit status 1 Error: error creating ECS service (tf-acc-test-8186966170523430470): InvalidParameterException: IngressPortOverride cannot use ports <= 1024. with aws_ecs_service.test, on terraform_plugin_test.tf line 85, in resource "aws_ecs_service" "test": 85: resource "aws_ecs_service" "test" { --- FAIL: TestAccECSService_ServiceConnect_ingressPortOverride (96.74s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ecs 101.655s FAIL make: *** [testacc] Error 1
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_ServiceConnect_remove' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_ServiceConnect_remove -timeout 180m === RUN TestAccECSService_ServiceConnect_remove === PAUSE TestAccECSService_ServiceConnect_remove === CONT TestAccECSService_ServiceConnect_remove service_test.go:1247: Step 2/2 error: Error running apply: exit status 1 Error: error updating ECS Service (arn:aws:ecs:us-west-2:187416307283:service/tf-acc-test-1138227086795760796/tf-acc-test-1138227086795760796): InvalidParameter: 1 validation error(s) found. - missing required field, UpdateServiceInput.ServiceConnectConfiguration.Enabled. with aws_ecs_service.test, on terraform_plugin_test.tf line 38, in resource "aws_ecs_service" "test": 38: resource "aws_ecs_service" "test" { --- FAIL: TestAccECSService_ServiceConnect_remove (169.39s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ecs 174.639s FAIL make: *** [testacc] Error 1
…nect_ingressPortOverride'. Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_ServiceConnect_ingressPortOverride' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_ServiceConnect_ingressPortOverride -timeout 180m === RUN TestAccECSService_ServiceConnect_ingressPortOverride === PAUSE TestAccECSService_ServiceConnect_ingressPortOverride === CONT TestAccECSService_ServiceConnect_ingressPortOverride --- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (163.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 178.365s
Acceptance test output: % make testacc TESTARGS='-run=TestAccECSService_ServiceConnect_remove' PKG=ecs ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_ServiceConnect_remove -timeout 180m === RUN TestAccECSService_ServiceConnect_remove === PAUSE TestAccECSService_ServiceConnect_remove === CONT TestAccECSService_ServiceConnect_remove --- PASS: TestAccECSService_ServiceConnect_remove (177.46s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 187.177s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSService_' PKG=ecs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSService_ -timeout 180m
=== RUN TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN TestAccECSService_CapacityProviderStrategy_multiple
=== PAUSE TestAccECSService_CapacityProviderStrategy_multiple
=== RUN TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN TestAccECSService_renamedCluster
=== PAUSE TestAccECSService_renamedCluster
=== RUN TestAccECSService_healthCheckGracePeriodSeconds
=== PAUSE TestAccECSService_healthCheckGracePeriodSeconds
=== RUN TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== RUN TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN TestAccECSService_ServiceRegistries_changes
=== PAUSE TestAccECSService_ServiceRegistries_changes
=== RUN TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== CONT TestAccECSService_basic
=== CONT TestAccECSService_PlacementStrategy_basic
=== CONT TestAccECSService_ServiceRegistries_basic
--- PASS: TestAccECSService_basic (103.00s)
=== CONT TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_PlacementStrategy_basic (141.47s)
=== CONT TestAccECSService_forceNewDeploymentTriggers
--- PASS: TestAccECSService_ServiceRegistries_basic (167.21s)
=== CONT TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_forceNewDeploymentTriggers (93.20s)
=== CONT TestAccECSService_multipleTargetGroups
--- PASS: TestAccECSService_forceNewDeployment (97.04s)
=== CONT TestAccECSService_alb
--- PASS: TestAccECSService_multipleTargetGroups (225.75s)
=== CONT TestAccECSService_clusterName
--- PASS: TestAccECSService_alb (235.21s)
=== CONT TestAccECSService_loadBalancerChanges
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (420.22s)
=== CONT TestAccECSService_deploymentCircuitBreaker
--- PASS: TestAccECSService_clusterName (94.51s)
=== CONT TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_deploymentCircuitBreaker (72.96s)
=== CONT TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (82.42s)
=== CONT TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_DeploymentValues_basic (82.41s)
=== CONT TestAccECSService_CapacityProviderStrategy_multiple
--- PASS: TestAccECSService_DeploymentControllerType_external (51.54s)
=== CONT TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSService_loadBalancerChanges (195.37s)
=== CONT TestAccECSService_iamRole
--- PASS: TestAccECSService_iamRole (47.68s)
=== CONT TestAccECSService_healthCheckGracePeriodSeconds
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (237.83s)
=== CONT TestAccECSService_renamedCluster
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (260.64s)
=== CONT TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_renamedCluster (93.15s)
=== CONT TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_familyAndRevision (82.28s)
=== CONT TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (189.07s)
=== CONT TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (154.63s)
=== CONT TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_CapacityProviderStrategy_update (306.05s)
=== CONT TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (71.41s)
=== CONT TestAccECSService_executeCommand
--- PASS: TestAccECSService_executeCommand (84.73s)
=== CONT TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_ServiceConnect_remove (173.57s)
=== CONT TestAccECSService_Tags_managed
--- PASS: TestAccECSService_Tags_propagate (84.98s)
=== CONT TestAccECSService_Tags_basic
--- PASS: TestAccECSService_Tags_managed (72.39s)
=== CONT TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_Tags_basic (108.57s)
=== CONT TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (1058.77s)
=== CONT TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (27.68s)
=== CONT TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (27.76s)
=== CONT TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (156.39s)
=== CONT TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_replicaSchedulingStrategy (82.25s)
=== CONT TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSService_LaunchTypeEC2_network (82.04s)
=== CONT TestAccECSService_ServiceConnect_ingressPortOverride
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (162.15s)
=== CONT TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_ServiceConnect_basic (172.32s)
=== CONT TestAccECSService_disappears
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (161.76s)
=== CONT TestAccECSService_ServiceRegistries_changes
--- PASS: TestAccECSService_ServiceConnect_full (161.61s)
=== CONT TestAccECSService_ServiceRegistries_container
--- PASS: TestAccECSService_disappears (181.17s)
=== CONT TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (71.64s)
=== CONT TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_ServiceRegistries_container (155.78s)
=== CONT TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_ServiceRegistries_changes (262.28s)
=== CONT TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (141.78s)
=== CONT TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.52s)
=== CONT TestAccECSService_basicImport
--- PASS: TestAccECSService_PlacementConstraints_basic (95.89s)
--- PASS: TestAccECSService_basicImport (196.92s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (741.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 3032.520s
@dragondgold Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR fixes two issues with the newly introduced ECS Service Connect. It fixes #28293 and fixes not being able to destroy ECS Service Connect from an ECS service when the
service_connect_configuration
argument is completely removedRelations
Closes #28293
References
Output from Acceptance Testing