Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source aws_s3control_multi_region_access_point #28373

Merged
merged 16 commits into from
Dec 21, 2022
Merged

Data source aws_s3control_multi_region_access_point #28373

merged 16 commits into from
Dec 21, 2022

Conversation

tiborhercz
Copy link
Contributor

@tiborhercz tiborhercz commented Dec 15, 2022 •
edited

Description

S3 multi region access point data resource.

Relations

Closes #28251

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPointDataSource_basic' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlMultiRegionAccessPointDataSource_basic -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointDataSource_basic
--- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (324.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  327.081s


...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 15, 2022
@tiborhercz
Implement multi region access point data source
a6e4aae 
- Implement the data source
- Implement the test for the data source
- Create draft documentation
@tiborhercz tiborhercz force-pushed the f-aws_s3control_multi_region_access_point-data branch from 495fb9b to a6e4aae Compare December 15, 2022 08:49
bschaatsbergen
bschaatsbergen reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few drive-by comments, nice WIP 👍

@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Dec 15, 2022
@tiborhercz
Update the SetId parameter to MultiRegionAccessPointCreateResourceID
04358fc 
In the main resource the ID is created with the
MultiRegionAccessPointCreateResourceID function. So therefore the data
source should also generate the same ID.
@tiborhercz
change public_access_block from map to list and add element schema
acddc33
@tiborhercz
update public_access_block in test
68dbcf1
@tiborhercz
Flatten the public_access_block in multi_region_access_point_data_sou…
2dda553 
…rce.go
@tiborhercz
removed created_at in the test
9da96f4 
created_at is not returned when creating the resource so we cannot
compare this value.
@tiborhercz
update set methods
cbd91ed
@tiborhercz
clean up code
db18deb
@tiborhercz
add documentation
6fef96c
@tiborhercz tiborhercz marked this pull request as ready for review December 15, 2022 12:55
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 15, 2022
@tiborhercz tiborhercz force-pushed the f-aws_s3control_multi_region_access_point-data branch from 9560656 to 05844d3 Compare December 15, 2022 13:20
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Dec 15, 2022
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Dec 21, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 21, 2022
ewbankkit
ewbankkit approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPointDataSource_' PKG=s3control ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlMultiRegionAccessPointDataSource_ -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointDataSource_basic
--- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (347.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	352.783s

@ewbankkit
Copy link
Contributor

@tiborhercz Thanks for the contribution 🎉 👏.

@bschaatsbergen
Copy link
Member

Nice work @tiborhercz 👍

@ewbankkit ewbankkit merged commit 6a552d7 into hashicorp:main Dec 21, 2022
@github-actions github-actions bot added this to the v4.49.0 milestone Dec 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.49.0
Development

Successfully merging this pull request may close these issues.

[New]: Data source aws_s3control_multi_region_access_point
3 participants
@tiborhercz @ewbankkit @bschaatsbergen