Add execution_role to Athena Workgroup

[bschaatsbergen]

Description

Relations

Closes #28386

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[djleeam]

@bschaatsbergen , thanks for putting up this pull request. I did some dev_overrides testing with the changes in your branch on my AWS account and everything appears to work, afaik.

FYI, I also put up a small PR to your branch to fix the "Acceptance Test Linting / terrafmt" check failure.

bschaatsbergen#437

Btw, Happy New Year!

[bschaatsbergen]

Ah that's nice of you @djleeam, I was on holidays, I'll finalize the PR asap.

Happy new year :)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAthenaWorkGroup_' PKG=athena ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 3  -run=TestAccAthenaWorkGroup_ -timeout 180m
=== RUN   TestAccAthenaWorkGroup_basic
=== PAUSE TestAccAthenaWorkGroup_basic
=== RUN   TestAccAthenaWorkGroup_aclConfig
=== PAUSE TestAccAthenaWorkGroup_aclConfig
=== RUN   TestAccAthenaWorkGroup_disappears
=== PAUSE TestAccAthenaWorkGroup_disappears
=== RUN   TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
=== PAUSE TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
=== RUN   TestAccAthenaWorkGroup_enforceWorkGroup
=== PAUSE TestAccAthenaWorkGroup_enforceWorkGroup
=== RUN   TestAccAthenaWorkGroup_configurationEngineVersion
=== PAUSE TestAccAthenaWorkGroup_configurationEngineVersion
=== RUN   TestAccAthenaWorkGroup_configurationExecutionRole
=== PAUSE TestAccAthenaWorkGroup_configurationExecutionRole
=== RUN   TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
=== PAUSE TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
=== RUN   TestAccAthenaWorkGroup_ResultEncryption_sseS3
=== PAUSE TestAccAthenaWorkGroup_ResultEncryption_sseS3
=== RUN   TestAccAthenaWorkGroup_ResultEncryption_kms
=== PAUSE TestAccAthenaWorkGroup_ResultEncryption_kms
=== RUN   TestAccAthenaWorkGroup_Result_outputLocation
=== PAUSE TestAccAthenaWorkGroup_Result_outputLocation
=== RUN   TestAccAthenaWorkGroup_requesterPaysEnabled
=== PAUSE TestAccAthenaWorkGroup_requesterPaysEnabled
=== RUN   TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
=== PAUSE TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
=== RUN   TestAccAthenaWorkGroup_description
=== PAUSE TestAccAthenaWorkGroup_description
=== RUN   TestAccAthenaWorkGroup_state
=== PAUSE TestAccAthenaWorkGroup_state
=== RUN   TestAccAthenaWorkGroup_forceDestroy
=== PAUSE TestAccAthenaWorkGroup_forceDestroy
=== RUN   TestAccAthenaWorkGroup_tags
=== PAUSE TestAccAthenaWorkGroup_tags
=== CONT  TestAccAthenaWorkGroup_basic
=== CONT  TestAccAthenaWorkGroup_ResultEncryption_kms
=== CONT  TestAccAthenaWorkGroup_description
--- PASS: TestAccAthenaWorkGroup_basic (18.32s)
=== CONT  TestAccAthenaWorkGroup_state
--- PASS: TestAccAthenaWorkGroup_description (29.63s)
=== CONT  TestAccAthenaWorkGroup_tags
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_kms (32.33s)
=== CONT  TestAccAthenaWorkGroup_configurationEngineVersion
--- PASS: TestAccAthenaWorkGroup_state (42.95s)
=== CONT  TestAccAthenaWorkGroup_ResultEncryption_sseS3
--- PASS: TestAccAthenaWorkGroup_tags (47.59s)
=== CONT  TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
--- PASS: TestAccAthenaWorkGroup_configurationEngineVersion (50.33s)
=== CONT  TestAccAthenaWorkGroup_configurationExecutionRole
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_sseS3 (23.18s)
=== CONT  TestAccAthenaWorkGroup_requesterPaysEnabled
--- PASS: TestAccAthenaWorkGroup_configurationExecutionRole (27.10s)
=== CONT  TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
--- PASS: TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled (35.28s)
=== CONT  TestAccAthenaWorkGroup_forceDestroy
--- PASS: TestAccAthenaWorkGroup_requesterPaysEnabled (35.00s)
=== CONT  TestAccAthenaWorkGroup_enforceWorkGroup
--- PASS: TestAccAthenaWorkGroup_forceDestroy (32.27s)
=== CONT  TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
--- PASS: TestAccAthenaWorkGroup_enforceWorkGroup (32.72s)
=== CONT  TestAccAthenaWorkGroup_Result_outputLocation
--- PASS: TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy (46.77s)
=== CONT  TestAccAthenaWorkGroup_disappears
--- PASS: TestAccAthenaWorkGroup_disappears (14.21s)
=== CONT  TestAccAthenaWorkGroup_aclConfig
--- PASS: TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery (34.41s)
--- PASS: TestAccAthenaWorkGroup_aclConfig (19.91s)
--- PASS: TestAccAthenaWorkGroup_Result_outputLocation (45.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	203.188s

[ewbankkit]

@bschaatsbergen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.