Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/db_proxy - add client_password_auth_type argument #28432

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 17, 2022

Description

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRDSProxy_ PKG=rds
--- PASS: TestAccRDSProxy_authSecretARN (527.54s)
--- PASS: TestAccRDSProxy_authUsername (529.28s)
--- PASS: TestAccRDSProxy_basic (545.57s)
--- PASS: TestAccRDSProxy_requireTLS (546.26s)
--- PASS: TestAccRDSProxy_vpcSecurityGroupIDs (550.60s)
--- PASS: TestAccRDSProxy_idleClientTimeout (553.70s)
--- PASS: TestAccRDSProxy_authIAMAuth (556.18s)
--- PASS: TestAccRDSProxy_authDescription (567.66s)
--- PASS: TestAccRDSProxy_tags (570.89s)
--- PASS: TestAccRDSProxy_disappears (580.67s)
--- PASS: TestAccRDSProxy_debugLogging (614.13s)
--- PASS: TestAccRDSProxy_roleARN (661.57s)
--- PASS: TestAccRDSProxy_name (678.67s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. labels Dec 17, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 17, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 17, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 17, 2022
@@ -39,7 +39,7 @@ func ResourceProxy() *schema.Resource {
Computed: true,
},
"auth": {
Type: schema.TypeSet,
Type: schema.TypeList,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise causes diffs from client_password_auth_type

@DrFaust92 DrFaust92 marked this pull request as ready for review December 17, 2022 12:30
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 10, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTS=TestAccRDSProxy_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSProxy_'  -timeout 180m
=== RUN   TestAccRDSProxy_basic
=== PAUSE TestAccRDSProxy_basic
=== RUN   TestAccRDSProxy_name
=== PAUSE TestAccRDSProxy_name
=== RUN   TestAccRDSProxy_debugLogging
=== PAUSE TestAccRDSProxy_debugLogging
=== RUN   TestAccRDSProxy_idleClientTimeout
=== PAUSE TestAccRDSProxy_idleClientTimeout
=== RUN   TestAccRDSProxy_requireTLS
=== PAUSE TestAccRDSProxy_requireTLS
=== RUN   TestAccRDSProxy_roleARN
=== PAUSE TestAccRDSProxy_roleARN
=== RUN   TestAccRDSProxy_vpcSecurityGroupIDs
=== PAUSE TestAccRDSProxy_vpcSecurityGroupIDs
=== RUN   TestAccRDSProxy_authDescription
=== PAUSE TestAccRDSProxy_authDescription
=== RUN   TestAccRDSProxy_authIAMAuth
=== PAUSE TestAccRDSProxy_authIAMAuth
=== RUN   TestAccRDSProxy_authSecretARN
=== PAUSE TestAccRDSProxy_authSecretARN
=== RUN   TestAccRDSProxy_authUsername
=== PAUSE TestAccRDSProxy_authUsername
=== RUN   TestAccRDSProxy_tags
=== PAUSE TestAccRDSProxy_tags
=== RUN   TestAccRDSProxy_disappears
=== PAUSE TestAccRDSProxy_disappears
=== CONT  TestAccRDSProxy_basic
=== CONT  TestAccRDSProxy_authDescription
=== CONT  TestAccRDSProxy_authUsername
=== CONT  TestAccRDSProxy_requireTLS
=== CONT  TestAccRDSProxy_disappears
=== CONT  TestAccRDSProxy_vpcSecurityGroupIDs
=== CONT  TestAccRDSProxy_debugLogging
=== CONT  TestAccRDSProxy_authSecretARN
=== CONT  TestAccRDSProxy_name
=== CONT  TestAccRDSProxy_authIAMAuth
=== CONT  TestAccRDSProxy_roleARN
=== CONT  TestAccRDSProxy_idleClientTimeout
=== CONT  TestAccRDSProxy_tags
--- PASS: TestAccRDSProxy_authUsername (498.38s)
--- PASS: TestAccRDSProxy_tags (554.75s)
--- PASS: TestAccRDSProxy_basic (562.02s)
--- PASS: TestAccRDSProxy_disappears (579.47s)
--- PASS: TestAccRDSProxy_idleClientTimeout (690.71s)
--- PASS: TestAccRDSProxy_authDescription (722.31s)
--- PASS: TestAccRDSProxy_requireTLS (760.33s)
--- PASS: TestAccRDSProxy_name (762.19s)
--- PASS: TestAccRDSProxy_debugLogging (770.63s)
--- PASS: TestAccRDSProxy_vpcSecurityGroupIDs (772.99s)
--- PASS: TestAccRDSProxy_authIAMAuth (782.48s)
--- PASS: TestAccRDSProxy_roleARN (783.00s)
--- PASS: TestAccRDSProxy_authSecretARN (783.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        786.355s

@jar-b jar-b merged commit 7147fc9 into hashicorp:main Feb 10, 2023
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@jar-b
Copy link
Member

jar-b commented Feb 10, 2023

Thanks for your contribution, @DrFaust92! 👏

@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants