-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/appsync_resolver - add support for js #28436
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@DrFaust92 not sure if I need to put it in here, but I reported a bug to the pulumi aws provider about APPSYNC_JS that might be relevant for this PR: pulumi/pulumi-aws#2277 |
Thanks @Jimmy89 for a quick glance at the test case in the ticket and test case I made for PR it should work for resolvers after this PR, I'll double check docs to make sure things that are optional are reflected in docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAppSync_serial/Resolver PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/Resolver' -timeout 180m
=== RUN TestAccAppSync_serial
=== RUN TestAccAppSync_serial/Resolver
=== RUN TestAccAppSync_serial/Resolver/pipeline
=== RUN TestAccAppSync_serial/Resolver/caching
=== RUN TestAccAppSync_serial/Resolver/code
=== RUN TestAccAppSync_serial/Resolver/dataSource
=== RUN TestAccAppSync_serial/Resolver/DataSource_lambda
=== RUN TestAccAppSync_serial/Resolver/requestTemplate
=== RUN TestAccAppSync_serial/Resolver/responseTemplate
=== RUN TestAccAppSync_serial/Resolver/basic
=== RUN TestAccAppSync_serial/Resolver/disappears
=== RUN TestAccAppSync_serial/Resolver/multipleResolvers
=== RUN TestAccAppSync_serial/Resolver/sync
--- PASS: TestAccAppSync_serial (327.12s)
--- PASS: TestAccAppSync_serial/Resolver (327.12s)
--- PASS: TestAccAppSync_serial/Resolver/pipeline (27.10s)
--- PASS: TestAccAppSync_serial/Resolver/caching (23.14s)
--- PASS: TestAccAppSync_serial/Resolver/code (25.95s)
--- PASS: TestAccAppSync_serial/Resolver/dataSource (34.63s)
--- PASS: TestAccAppSync_serial/Resolver/DataSource_lambda (40.75s)
--- PASS: TestAccAppSync_serial/Resolver/requestTemplate (31.91s)
--- PASS: TestAccAppSync_serial/Resolver/responseTemplate (31.39s)
--- PASS: TestAccAppSync_serial/Resolver/basic (23.16s)
--- PASS: TestAccAppSync_serial/Resolver/disappears (17.84s)
--- PASS: TestAccAppSync_serial/Resolver/multipleResolvers (33.82s)
--- PASS: TestAccAppSync_serial/Resolver/sync (37.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appsync 332.558s
@DrFaust92 Thanks for the contribution 🎉 👏. |
"caching_config": { | ||
Type: schema.TypeList, | ||
Optional: true, | ||
MaxItems: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 been going through PRs to learn and I've noticed a lot of these where the type is TypeList and the MaxItems is 1 item of type map. We then have expand functions which always expects a list of one map item. What is this pattern? Why can't the type be TypeMap instead?
This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #27873
Closes #28429
References
Output from Acceptance Testing