r/appsync_resolver - add support for js

[DrFaust92]

Description

Relations

Closes #27873
Closes #28429

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppSync_serial/Resolver PKG=appsync
--- PASS: TestAccAppSync_serial (440.04s)
    --- PASS: TestAccAppSync_serial/Resolver (440.04s)
        --- PASS: TestAccAppSync_serial/Resolver/disappears (31.16s)
        --- PASS: TestAccAppSync_serial/Resolver/pipeline (34.79s)
        --- PASS: TestAccAppSync_serial/Resolver/responseTemplate (47.13s)
        --- PASS: TestAccAppSync_serial/Resolver/multipleResolvers (49.70s)
        --- PASS: TestAccAppSync_serial/Resolver/caching (30.77s)
        --- PASS: TestAccAppSync_serial/Resolver/basic (31.18s)
        --- PASS: TestAccAppSync_serial/Resolver/code (33.29s)
        --- PASS: TestAccAppSync_serial/Resolver/dataSource (46.78s)
        --- PASS: TestAccAppSync_serial/Resolver/DataSource_lambda (45.82s)
        --- PASS: TestAccAppSync_serial/Resolver/requestTemplate (49.98s)
        --- PASS: TestAccAppSync_serial/Resolver/sync (39.44s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[Jimmy89]

@DrFaust92 not sure if I need to put it in here, but I reported a bug to the pulumi aws provider about APPSYNC_JS that might be relevant for this PR: pulumi/pulumi-aws#2277
With the current terraform-provider-aws v4.47.0 (in combination with pulumi) using the runtime and code attributes does not change the requirement of the request_template template (which should be optional instead).

[DrFaust92]

Thanks @Jimmy89 for a quick glance at the test case in the ticket and test case I made for PR it should work for resolvers after this PR, I'll double check docs to make sure things that are optional are reflected in docs

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccAppSync_serial/Resolver PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/Resolver'  -timeout 180m
=== RUN   TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/Resolver
=== RUN   TestAccAppSync_serial/Resolver/pipeline
=== RUN   TestAccAppSync_serial/Resolver/caching
=== RUN   TestAccAppSync_serial/Resolver/code
=== RUN   TestAccAppSync_serial/Resolver/dataSource
=== RUN   TestAccAppSync_serial/Resolver/DataSource_lambda
=== RUN   TestAccAppSync_serial/Resolver/requestTemplate
=== RUN   TestAccAppSync_serial/Resolver/responseTemplate
=== RUN   TestAccAppSync_serial/Resolver/basic
=== RUN   TestAccAppSync_serial/Resolver/disappears
=== RUN   TestAccAppSync_serial/Resolver/multipleResolvers
=== RUN   TestAccAppSync_serial/Resolver/sync
--- PASS: TestAccAppSync_serial (327.12s)
    --- PASS: TestAccAppSync_serial/Resolver (327.12s)
        --- PASS: TestAccAppSync_serial/Resolver/pipeline (27.10s)
        --- PASS: TestAccAppSync_serial/Resolver/caching (23.14s)
        --- PASS: TestAccAppSync_serial/Resolver/code (25.95s)
        --- PASS: TestAccAppSync_serial/Resolver/dataSource (34.63s)
        --- PASS: TestAccAppSync_serial/Resolver/DataSource_lambda (40.75s)
        --- PASS: TestAccAppSync_serial/Resolver/requestTemplate (31.91s)
        --- PASS: TestAccAppSync_serial/Resolver/responseTemplate (31.39s)
        --- PASS: TestAccAppSync_serial/Resolver/basic (23.16s)
        --- PASS: TestAccAppSync_serial/Resolver/disappears (17.84s)
        --- PASS: TestAccAppSync_serial/Resolver/multipleResolvers (33.82s)
        --- PASS: TestAccAppSync_serial/Resolver/sync (37.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	332.558s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[bennylu2]

👋 been going through PRs to learn and I've noticed a lot of these where the type is TypeList and the MaxItems is 1 item of type map. We then have expand functions which always expects a list of one map item. What is this pattern? Why can't the type be TypeMap instead?

[github-actions]

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.