-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_kinesis_firehose_delivery_stream add timeouts (#22645) #28469
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ameddin73 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Add timeout to kineses firehose create tmp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_ -timeout 180m
=== CONT TestAccFirehoseDeliveryStream_s3KinesisStreamSource
--- PASS: TestAccFirehoseDeliveryStream_s3KinesisStreamSource (62.21s)
=== CONT TestAccFirehoseDeliveryStream_httpEndpoint
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource (64.84s)
=== CONT TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration (129.74s)
=== CONT TestAccFirehoseDeliveryStream_s3basicWithSSE
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate (140.44s)
=== CONT TestAccFirehoseDeliveryStream_s3basicWithSSEAndKeyType
--- PASS: TestAccFirehoseDeliveryStream_s3Updates (148.45s)
=== CONT TestAccFirehoseDeliveryStream_s3basicWithSSEAndKeyARN
--- PASS: TestAccFirehoseDeliveryStream_missingProcessing (149.86s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging (155.08s)
=== CONT TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
--- PASS: TestAccFirehoseDeliveryStream_extendedS3basic (159.59s)
=== CONT TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
--- PASS: TestAccFirehoseDeliveryStream_basic (159.85s)
=== CONT TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
--- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (241.41s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
--- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (245.63s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (181.82s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix (246.78s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithTags (249.59s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled (256.82s)
=== CONT TestAccFirehoseDeliveryStream_s3basic
--- PASS: TestAccFirehoseDeliveryStream_httpEndpoint (194.84s)
=== CONT TestAccFirehoseDeliveryStream_s3basicWithPrefixes
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty (118.85s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty (121.71s)
=== CONT TestAccFirehoseDeliveryStream_disappears
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix (219.51s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning (210.64s)
=== CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN (225.02s)
--- PASS: TestAccFirehoseDeliveryStream_redshiftUpdates (415.68s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty (189.22s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix (194.30s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update (197.29s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithSSEAndKeyType (348.72s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithSSE (360.63s)
--- PASS: TestAccFirehoseDeliveryStream_s3basic (238.50s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithPrefixes (243.05s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithSSEAndKeyARN (393.39s)
--- PASS: TestAccFirehoseDeliveryStream_tagUpdates (560.47s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty (200.77s)
--- PASS: TestAccFirehoseDeliveryStream_disappears (212.47s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty (242.89s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate (465.65s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update (282.80s)
--- PASS: TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix (1488.10s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchUpdates (1525.78s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates (1620.81s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates (2441.45s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 2444.638s
Thanks for your contribution, @ameddin73! |
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
AWS Kinesis Firehose can take longer than 20 minutes to create (or destroy), but 20 minutes is the default timeout hardcoded into the provider resource.
This PR adds a
Timeout
field to the resource with the same 20 minute default to allow a user to extend it and prevent timeout failures.Relations
Closes #22645
References
Output from Acceptance Testing
ameddin73:main
:hashicorp:main
:Test error related to #19936 or #26964