-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_autoscaling_policy: Support metric math for target tracking policy #28560
r/aws_autoscaling_policy: Support metric math for target tracking policy #28560
Conversation
Community NoteVoting for Prioritization
For Submitters
|
This patch supports metric math for EC2 Auto Scaling target tracking policy, which was released on Dec 8, 2022.
2612dc0
to
6329f54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…cation Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
…ication's metrics Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
Signed-off-by: Mehmet Gungoren <mehgungoren@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAutoScalingPolicy_' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 3 -run=TestAccAutoScalingPolicy_ -timeout 180m
=== RUN TestAccAutoScalingPolicy_basic
=== PAUSE TestAccAutoScalingPolicy_basic
=== RUN TestAccAutoScalingPolicy_disappears
=== PAUSE TestAccAutoScalingPolicy_disappears
=== RUN TestAccAutoScalingPolicy_predictiveScalingPredefined
=== PAUSE TestAccAutoScalingPolicy_predictiveScalingPredefined
=== RUN TestAccAutoScalingPolicy_predictiveScalingResourceLabel
=== PAUSE TestAccAutoScalingPolicy_predictiveScalingResourceLabel
=== RUN TestAccAutoScalingPolicy_predictiveScalingCustom
=== PAUSE TestAccAutoScalingPolicy_predictiveScalingCustom
=== RUN TestAccAutoScalingPolicy_predictiveScalingRemoved
=== PAUSE TestAccAutoScalingPolicy_predictiveScalingRemoved
=== RUN TestAccAutoScalingPolicy_predictiveScalingUpdated
=== PAUSE TestAccAutoScalingPolicy_predictiveScalingUpdated
=== RUN TestAccAutoScalingPolicy_predictiveScalingFloatTargetValue
=== PAUSE TestAccAutoScalingPolicy_predictiveScalingFloatTargetValue
=== RUN TestAccAutoScalingPolicy_simpleScalingStepAdjustment
=== PAUSE TestAccAutoScalingPolicy_simpleScalingStepAdjustment
=== RUN TestAccAutoScalingPolicy_TargetTrack_predefined
=== PAUSE TestAccAutoScalingPolicy_TargetTrack_predefined
=== RUN TestAccAutoScalingPolicy_TargetTrack_custom
=== PAUSE TestAccAutoScalingPolicy_TargetTrack_custom
=== RUN TestAccAutoScalingPolicy_TargetTrack_metricMath
=== PAUSE TestAccAutoScalingPolicy_TargetTrack_metricMath
=== RUN TestAccAutoScalingPolicy_zeroValue
=== PAUSE TestAccAutoScalingPolicy_zeroValue
=== CONT TestAccAutoScalingPolicy_basic
=== CONT TestAccAutoScalingPolicy_predictiveScalingFloatTargetValue
=== CONT TestAccAutoScalingPolicy_TargetTrack_custom
--- PASS: TestAccAutoScalingPolicy_TargetTrack_custom (49.39s)
=== CONT TestAccAutoScalingPolicy_predictiveScalingCustom
--- PASS: TestAccAutoScalingPolicy_predictiveScalingFloatTargetValue (67.73s)
=== CONT TestAccAutoScalingPolicy_predictiveScalingUpdated
--- PASS: TestAccAutoScalingPolicy_basic (100.45s)
=== CONT TestAccAutoScalingPolicy_predictiveScalingRemoved
--- PASS: TestAccAutoScalingPolicy_predictiveScalingCustom (62.73s)
=== CONT TestAccAutoScalingPolicy_predictiveScalingPredefined
--- PASS: TestAccAutoScalingPolicy_predictiveScalingUpdated (83.54s)
=== CONT TestAccAutoScalingPolicy_predictiveScalingResourceLabel
--- PASS: TestAccAutoScalingPolicy_predictiveScalingRemoved (70.24s)
=== CONT TestAccAutoScalingPolicy_zeroValue
--- PASS: TestAccAutoScalingPolicy_predictiveScalingPredefined (65.21s)
=== CONT TestAccAutoScalingPolicy_TargetTrack_predefined
--- PASS: TestAccAutoScalingPolicy_predictiveScalingResourceLabel (64.28s)
=== CONT TestAccAutoScalingPolicy_disappears
--- PASS: TestAccAutoScalingPolicy_zeroValue (57.50s)
=== CONT TestAccAutoScalingPolicy_TargetTrack_metricMath
--- PASS: TestAccAutoScalingPolicy_TargetTrack_predefined (51.81s)
=== CONT TestAccAutoScalingPolicy_simpleScalingStepAdjustment
--- PASS: TestAccAutoScalingPolicy_disappears (50.22s)
--- PASS: TestAccAutoScalingPolicy_TargetTrack_metricMath (50.94s)
--- PASS: TestAccAutoScalingPolicy_simpleScalingStepAdjustment (54.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 288.629s
@jungseoklee @gungoren Thanks for the contribution 🎉 👏. |
@AdamTylerLynch @ewbankkit Great thanks for reviewing and taking care of this PR! |
This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR supports metric math for EC2 Auto Scaling target tracking policy, which was released on Dec 8, 2022: https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-ec2-auto-scaling-supports-metric-math-target-tracking-policies/
Relations
Closes #29148.
Closes #29145.
References
Output from Acceptance Testing