-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_dms_endpoint.cdc_min_file_size is kilobytes, no longer megabytes #28578
aws_dms_endpoint.cdc_min_file_size is kilobytes, no longer megabytes #28578
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Changing a default is generally considered a breaking change. However, I think we have good grounds for changing anyway since the change in multiplier comes from AWS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Thanks for your work on this!
% make testacc TESTS=TestAccDMSEndpoint_S3 PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_S3' -timeout 180m
=== RUN TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== CONT TestAccDMSEndpoint_S3_basic
=== CONT TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (43.61s)
--- PASS: TestAccDMSEndpoint_S3_basic (67.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 69.626s
This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
#27688 captures the details of the bug
cdc_min_file_size
is 32 which previously was correct when api was in megabytess but has since changed to kilobytes. Updating to 32000 as default which is in aws docs.Closes #27688
References
https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Target.S3.html#CHAP_Target.S3.Configuring