Add aws_fsx_windows_file_system data source #28622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
github-actions
bot
added
documentation
github-actions
bot
added
the
documentation
github-actions
bot
added
service/fsx
bennylu2
force-pushed
the
f-aws_fsx_windows_file_system-data-source
branch
from
cb8b65b to
5d01965
Compare
github-actions
bot
removed
the
service/ssm
justinretzolk
added
new-data-source
github-actions
bot
removed
the
provider
bennylu2
changed the title
# Conflicts: # internal/service/fsx/service_package_gen.go # internal/service/fsx/windows_file_system.go
% make testacc TESTARGS='-run=TestAccFSxWindowsFileSystemDataSource_' PKG=fsx ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxWindowsFileSystemDataSource_ -timeout 180m === RUN TestAccFSxWindowsFileSystemDataSource_basic === PAUSE TestAccFSxWindowsFileSystemDataSource_basic === CONT TestAccFSxWindowsFileSystemDataSource_basic --- PASS: TestAccFSxWindowsFileSystemDataSource_basic (2655.28s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 2660.624s
…o avoid `BadRequest` errors. Acceptance test output: % make testacc TESTARGS='-run=TestAccFSxWindowsFileSystem_storageCapacity\|TestAccFSxWindowsFileSystem_throughputCapacity' PKG=fsx ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxWindowsFileSystem_storageCapacity\|TestAccFSxWindowsFileSystem_throughputCapacity -timeout 180m === RUN TestAccFSxWindowsFileSystem_storageCapacity === PAUSE TestAccFSxWindowsFileSystem_storageCapacity === RUN TestAccFSxWindowsFileSystem_throughputCapacity === PAUSE TestAccFSxWindowsFileSystem_throughputCapacity === CONT TestAccFSxWindowsFileSystem_storageCapacity === CONT TestAccFSxWindowsFileSystem_throughputCapacity --- PASS: TestAccFSxWindowsFileSystem_throughputCapacity (3485.64s) --- PASS: TestAccFSxWindowsFileSystem_storageCapacity (3759.19s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 3764.680s
ewbankkit
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccFSxWindowsFileSystemDataSource_' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxWindowsFileSystemDataSource_ -timeout 180m
=== RUN TestAccFSxWindowsFileSystemDataSource_basic
=== PAUSE TestAccFSxWindowsFileSystemDataSource_basic
=== CONT TestAccFSxWindowsFileSystemDataSource_basic
--- PASS: TestAccFSxWindowsFileSystemDataSource_basic (2655.28s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 2660.624s--- PASS: TestAccFSxWindowsFileSystem_basic (2564.39s)s
--- PASS: TestAccFSxWindowsFileSystem_securityGroupIDs (4267.07s)
--- PASS: TestAccFSxWindowsFileSystem_tags (2640.21s)
--- PASS: TestAccFSxWindowsFileSystem_audit (2545.73s)
--- PASS: TestAccFSxWindowsFileSystem_weeklyMaintenanceStartTime (2995.06s)
--- PASS: TestAccFSxWindowsFileSystem_throughputCapacity (3546.61s)
--- PASS: TestAccFSxWindowsFileSystem_storageCapacity (4000.25s)
--- PASS: TestAccFSxWindowsFileSystem_fromBackup (4056.60s)
--- PASS: TestAccFSxWindowsFileSystem_aliases (3017.69s)
--- PASS: TestAccFSxWindowsFileSystem_dailyAutomaticBackupStartTime (2647.91s)
--- PASS: TestAccFSxWindowsFileSystem_kmsKeyID (4956.46s)
|
@bennylu2 Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data source for
aws_fsx_windows_file_systemRelations
Closes #27659.
Closes #20646.
Closes #25607.
Output from Acceptance Testing