Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_lightsail_bucket_access_key. New Shared Resource Separator and associated functions #28699

Merged

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Jan 5, 2023

Description

This Pull request Implements a new resource: aws_lightsail_bucket_access_key which allows creating and managing lightsail bucket access keys.

Additionally this pull request also implements a shared ResourceSeparator constant and the ExpandResourceId and FlattenResourceId functions for standardizing on a common resource separator as discussed in #27843 , so that new resources can start using this new standard.

Relations

Relates #27843

References

Output from Acceptance Testing

➜ terraform-provider-aws (f-aws_lightsail_bucket_access_key) ✗ make testacc TESTARGS='-run=TestAccLightsailBucketAccessKey' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailBucketAccessKey -timeout 180m
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketAccessKey_disappears
=== PAUSE TestAccLightsailBucketAccessKey_disappears
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailBucketAccessKey_disappears
--- PASS: TestAccLightsailBucketAccessKey_disappears (44.43s)
--- PASS: TestAccLightsailBucketAccessKey_basic (49.58s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  51.815s


➜ terraform-provider-aws (f-aws_lightsail_bucket_access_key) ✔ make test TEST=./internal/flex                                            
==> Checking that code complies with gofmt requirements...
go test ./internal/flex  -timeout=5m
ok      github.com/hashicorp/terraform-provider-aws/internal/flex       (cached)

...

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jan 5, 2023
@brittandeyoung brittandeyoung added new-resource Introduces a new resource. proposal Proposes new design or functionality. labels Jan 5, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 5, 2023
@brittandeyoung brittandeyoung changed the title New Resource: `aws_lightsail_bucket_access_key. New Shared Resource Separator and associated functions New Resource: aws_lightsail_bucket_access_key. New Shared Resource Separator and associated functions Jan 6, 2023
@brittandeyoung
Copy link
Collaborator Author

@YakDriver Friendly bump.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailBucketAccessKey -timeout 180m

go: downloading github.com/aws/aws-sdk-go v1.44.171
go: downloading github.com/aws/aws-sdk-go-v2/service/auditmanager v1.21.2
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.10.21
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.17.3
go: downloading github.com/aws/aws-sdk-go-v2/service/comprehend v1.20.2
go: downloading github.com/aws/aws-sdk-go-v2/service/computeoptimizer v1.19.0
go: downloading github.com/aws/aws-sdk-go-v2/service/fis v1.13.5
go: downloading github.com/aws/aws-sdk-go-v2/service/identitystore v1.15.10
go: downloading github.com/aws/aws-sdk-go-v2/service/inspector2 v1.10.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ivschat v1.2.1
go: downloading github.com/aws/aws-sdk-go-v2/service/kendra v1.36.3
go: downloading github.com/aws/aws-sdk-go-v2/service/medialive v1.27.0
go: downloading github.com/aws/aws-sdk-go-v2/service/opensearchserverless v1.0.3
go: downloading github.com/aws/aws-sdk-go-v2/service/pipes v1.0.2
go: downloading github.com/aws/aws-sdk-go-v2/service/rds v1.38.0
go: downloading github.com/aws/aws-sdk-go-v2/service/resourceexplorer2 v1.1.0
go: downloading github.com/aws/aws-sdk-go-v2/service/rolesanywhere v1.0.14
go: downloading github.com/aws/aws-sdk-go-v2/service/route53domains v1.13.0
go: downloading github.com/aws/aws-sdk-go-v2/service/s3control v1.28.2
go: downloading github.com/aws/aws-sdk-go-v2/service/scheduler v1.0.3
go: downloading github.com/aws/aws-sdk-go-v2/service/sesv2 v1.15.3
go: downloading github.com/aws/aws-sdk-go-v2/service/ssm v1.33.4
go: downloading github.com/aws/aws-sdk-go-v2/service/ssmincidents v1.19.2
go: downloading github.com/aws/aws-sdk-go-v2/service/transcribe v1.24.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.17.7
go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.18.25
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.11.27
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketAccessKey_disappears
=== PAUSE TestAccLightsailBucketAccessKey_disappears
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailBucketAccessKey_disappears
--- PASS: TestAccLightsailBucketAccessKey_disappears (50.61s)
--- PASS: TestAccLightsailBucketAccessKey_basic (53.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	55.270s

@YakDriver YakDriver merged commit dbe2e3e into hashicorp:main Feb 6, 2023
@github-actions github-actions bot added this to the v4.54.0 milestone Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. new-resource Introduces a new resource. proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants