Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align aws_ecs_service security_connect_configuration schema with API #28813

Merged

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jan 10, 2023

Description

Various elements of the aws_ecs_service relating to service_connect_configuration didn't match up with the documented API at https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ServiceConnectConfiguration.html and https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ServiceConnectService.html

Relations

Closes #28754

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccECSService_ServiceConnect PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_ServiceConnect'  -timeout 180m
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== CONT  TestAccECSService_ServiceConnect_basic
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
=== CONT  TestAccECSService_ServiceConnect_full
=== CONT  TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_ServiceConnect_full (147.65s)
--- PASS: TestAccECSService_ServiceConnect_basic (156.67s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (157.75s)
--- PASS: TestAccECSService_ServiceConnect_remove (164.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	165.015s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 13, 2023
@gdavison gdavison self-assigned this Feb 10, 2023
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (52.08s)
--- PASS: TestAccECSService_Tags_managed (92.78s)
--- PASS: TestAccECSService_clusterName (92.84s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (93.80s)
--- PASS: TestAccECSService_Alarms (93.84s)
--- PASS: TestAccECSService_DeploymentValues_basic (93.87s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (94.09s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (94.34s)
--- PASS: TestAccECSService_executeCommand (101.18s)
--- PASS: TestAccECSService_Tags_propagate (107.36s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (108.90s)
--- PASS: TestAccECSService_forceNewDeployment (109.17s)
--- PASS: TestAccECSService_basic (109.24s)
--- PASS: TestAccECSService_PlacementConstraints_basic (119.39s)
--- PASS: TestAccECSService_Tags_basic (130.01s)
--- PASS: TestAccECSService_DeploymentControllerType_external (52.53s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (159.89s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (165.03s)
--- PASS: TestAccECSService_familyAndRevision (88.78s)
--- PASS: TestAccECSService_PlacementStrategy_missing (1.08s)
--- PASS: TestAccECSService_renamedCluster (77.11s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (24.06s)
--- PASS: TestAccECSService_loadBalancerChanges (197.64s)
--- PASS: TestAccECSService_ServiceConnect_remove (178.31s)
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (111.41s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (81.19s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (56.33s)
--- PASS: TestAccECSService_alb (245.65s)
--- PASS: TestAccECSService_multipleTargetGroups (246.87s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (138.24s)
--- PASS: TestAccECSService_ServiceConnect_full (159.78s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (110.71s)
--- PASS: TestAccECSService_ServiceConnect_basic (167.44s)
--- PASS: TestAccECSService_PlacementStrategy_basic (90.47s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (68.04s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (190.38s)
--- PASS: TestAccECSService_ServiceRegistries_changes (249.50s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (248.93s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (239.31s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (164.72s)
--- PASS: TestAccECSService_iamRole (263.48s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (242.19s)
--- PASS: TestAccECSService_ServiceRegistries_basic (137.14s)
--- PASS: TestAccECSService_disappears (187.41s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (157.23s)
--- PASS: TestAccECSService_ServiceRegistries_container (157.58s)
--- PASS: TestAccECSService_basicImport (181.35s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (393.17s)

@gdavison gdavison merged commit 468259f into hashicorp:main Feb 10, 2023
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:
3 participants