Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3/bucket policy: Improve diffs with policies #28855

Merged
merged 3 commits into from
Jan 12, 2023
Merged

s3/bucket policy: Improve diffs with policies #28855

merged 3 commits into from
Jan 12, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 12, 2023 •
edited

Description

Relations

Relates #23288
Closes #18878
Closes #22030
Closes #24338

References

Output from Acceptance Testing

Errors unrelated to these changes.

% TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run='TestAccS3BucketPolicy_|TestAccS3Bucket_'  -timeout 180m
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 3 -run='TestAccKMSExternalKey_|TestAccKMSKey_'  -timeout 180m=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPolicy_disappears
=== PAUSE TestAccS3BucketPolicy_disappears
=== RUN   TestAccS3BucketPolicy_disappears_bucket
=== PAUSE TestAccS3BucketPolicy_disappears_bucket
=== RUN   TestAccS3BucketPolicy_policyUpdate
=== PAUSE TestAccS3BucketPolicy_policyUpdate
=== RUN   TestAccS3BucketPolicy_IAMRoleOrder_policyDoc
=== PAUSE TestAccS3BucketPolicy_IAMRoleOrder_policyDoc
=== RUN   TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal
=== PAUSE TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal
=== RUN   TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode
=== PAUSE TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode
=== RUN   TestAccS3BucketPolicy_migrate_noChange
=== PAUSE TestAccS3BucketPolicy_migrate_noChange
=== RUN   TestAccS3BucketPolicy_migrate_withChange
=== PAUSE TestAccS3BucketPolicy_migrate_withChange
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Basic_emptyString
=== PAUSE TestAccS3Bucket_Basic_emptyString
=== RUN   TestAccS3Bucket_Basic_generatedName
=== PAUSE TestAccS3Bucket_Basic_generatedName
=== RUN   TestAccS3Bucket_Basic_namePrefix
=== PAUSE TestAccS3Bucket_Basic_namePrefix
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== RUN   TestAccS3Bucket_Basic_acceleration
=== PAUSE TestAccS3Bucket_Basic_acceleration
=== RUN   TestAccS3Bucket_Basic_keyEnabled
=== PAUSE TestAccS3Bucket_Basic_keyEnabled
=== RUN   TestAccS3Bucket_Basic_requestPayer
=== PAUSE TestAccS3Bucket_Basic_requestPayer
=== RUN   TestAccS3Bucket_disappears
=== PAUSE TestAccS3Bucket_disappears
=== RUN   TestAccS3Bucket_Duplicate_basic
=== PAUSE TestAccS3Bucket_Duplicate_basic
=== RUN   TestAccS3Bucket_Duplicate_UsEast1
=== PAUSE TestAccS3Bucket_Duplicate_UsEast1
=== RUN   TestAccS3Bucket_Duplicate_UsEast1AltAccount
=== PAUSE TestAccS3Bucket_Duplicate_UsEast1AltAccount
=== RUN   TestAccS3Bucket_Tags_basic
=== PAUSE TestAccS3Bucket_Tags_basic
=== RUN   TestAccS3Bucket_Tags_withNoSystemTags
=== PAUSE TestAccS3Bucket_Tags_withNoSystemTags
=== RUN   TestAccS3Bucket_Tags_withSystemTags
=== PAUSE TestAccS3Bucket_Tags_withSystemTags
=== RUN   TestAccS3Bucket_Tags_ignoreTags
=== PAUSE TestAccS3Bucket_Tags_ignoreTags
=== RUN   TestAccS3Bucket_Manage_lifecycleBasic
=== PAUSE TestAccS3Bucket_Manage_lifecycleBasic
=== RUN   TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
=== PAUSE TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
=== RUN   TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
=== PAUSE TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
=== RUN   TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
=== PAUSE TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
=== RUN   TestAccS3Bucket_Manage_lifecycleRemove
=== PAUSE TestAccS3Bucket_Manage_lifecycleRemove
=== RUN   TestAccS3Bucket_Manage_objectLock
=== PAUSE TestAccS3Bucket_Manage_objectLock
=== RUN   TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== RUN   TestAccS3Bucket_Manage_objectLock_migrate
=== PAUSE TestAccS3Bucket_Manage_objectLock_migrate
=== RUN   TestAccS3Bucket_Manage_objectLockWithVersioning
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning
=== RUN   TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== RUN   TestAccS3Bucket_Manage_versioning
=== PAUSE TestAccS3Bucket_Manage_versioning
=== RUN   TestAccS3Bucket_Manage_versioningDisabled
=== PAUSE TestAccS3Bucket_Manage_versioningDisabled
=== RUN   TestAccS3Bucket_Manage_MFADeleteDisabled
=== PAUSE TestAccS3Bucket_Manage_MFADeleteDisabled
=== RUN   TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled
=== PAUSE TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled
=== RUN   TestAccS3Bucket_Replication_basic
=== PAUSE TestAccS3Bucket_Replication_basic
=== RUN   TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
=== PAUSE TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
=== RUN   TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
=== PAUSE TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
=== RUN   TestAccS3Bucket_Replication_twoDestination
=== PAUSE TestAccS3Bucket_Replication_twoDestination
=== RUN   TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
=== PAUSE TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
=== RUN   TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
=== PAUSE TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
=== RUN   TestAccS3Bucket_Replication_withoutStorageClass
=== PAUSE TestAccS3Bucket_Replication_withoutStorageClass
=== RUN   TestAccS3Bucket_Replication_expectVersioningValidationError
=== PAUSE TestAccS3Bucket_Replication_expectVersioningValidationError
=== RUN   TestAccS3Bucket_Replication_withoutPrefix
=== PAUSE TestAccS3Bucket_Replication_withoutPrefix
=== RUN   TestAccS3Bucket_Replication_schemaV2
=== PAUSE TestAccS3Bucket_Replication_schemaV2
=== RUN   TestAccS3Bucket_Replication_schemaV2SameRegion
=== PAUSE TestAccS3Bucket_Replication_schemaV2SameRegion
=== RUN   TestAccS3Bucket_Replication_RTC_valid
=== PAUSE TestAccS3Bucket_Replication_RTC_valid
=== RUN   TestAccS3Bucket_Security_updateACL
=== PAUSE TestAccS3Bucket_Security_updateACL
=== RUN   TestAccS3Bucket_Security_updateGrant
=== PAUSE TestAccS3Bucket_Security_updateGrant
=== RUN   TestAccS3Bucket_Security_aclToGrant
=== PAUSE TestAccS3Bucket_Security_aclToGrant
=== RUN   TestAccS3Bucket_Security_grantToACL
=== PAUSE TestAccS3Bucket_Security_grantToACL
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== RUN   TestAccS3Bucket_Security_corsDelete
=== PAUSE TestAccS3Bucket_Security_corsDelete
=== RUN   TestAccS3Bucket_Security_corsEmptyOrigin
=== PAUSE TestAccS3Bucket_Security_corsEmptyOrigin
=== RUN   TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
=== PAUSE TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
=== RUN   TestAccS3Bucket_Security_logging
=== PAUSE TestAccS3Bucket_Security_logging
=== RUN   TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
=== PAUSE TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
=== RUN   TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
=== PAUSE TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
=== RUN   TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
=== PAUSE TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
=== RUN   TestAccS3Bucket_Security_policy
=== PAUSE TestAccS3Bucket_Security_policy
=== RUN   TestAccS3Bucket_Web_simple
=== PAUSE TestAccS3Bucket_Web_simple
=== RUN   TestAccS3Bucket_Web_redirect
=== PAUSE TestAccS3Bucket_Web_redirect
=== RUN   TestAccS3Bucket_Web_routingRules
=== PAUSE TestAccS3Bucket_Web_routingRules
=== CONT  TestAccS3BucketPolicy_basic
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning
=== CONT  TestAccS3Bucket_Replication_RTC_valid
    bucket_test.go:1687: Step 1/4 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
=== CONT  TestAccS3Bucket_Web_routingRules
--- FAIL: TestAccS3Bucket_Replication_RTC_valid (2.17s)
--- PASS: TestAccS3BucketPolicy_basic (28.88s)
=== CONT  TestAccS3Bucket_Web_redirect
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (30.83s)
=== CONT  TestAccS3Bucket_Web_simple
--- PASS: TestAccS3Bucket_Web_routingRules (46.33s)
=== CONT  TestAccS3Bucket_Security_policy
--- PASS: TestAccS3Bucket_Web_redirect (68.11s)
=== CONT  TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
--- PASS: TestAccS3Bucket_Web_simple (67.82s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
--- PASS: TestAccS3Bucket_Security_policy (58.18s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (23.11s)
=== CONT  TestAccS3Bucket_Security_logging
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (27.84s)
=== CONT  TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (38.24s)
=== CONT  TestAccS3Bucket_Security_corsEmptyOrigin
--- PASS: TestAccS3Bucket_Security_logging (33.87s)
=== CONT  TestAccS3Bucket_Security_corsDelete
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (23.63s)
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (28.10s)
=== CONT  TestAccS3Bucket_Security_grantToACL
--- PASS: TestAccS3Bucket_Security_corsDelete (25.29s)
=== CONT  TestAccS3Bucket_Security_aclToGrant
--- PASS: TestAccS3Bucket_Security_corsUpdate (43.15s)
=== CONT  TestAccS3Bucket_Security_updateGrant
--- PASS: TestAccS3Bucket_Security_grantToACL (38.34s)
=== CONT  TestAccS3Bucket_Security_updateACL
--- PASS: TestAccS3Bucket_Security_aclToGrant (37.90s)
=== CONT  TestAccS3Bucket_Replication_twoDestination
    bucket_test.go:1321: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
=== CONT  TestAccS3Bucket_Replication_schemaV2SameRegion
--- FAIL: TestAccS3Bucket_Replication_twoDestination (1.25s)
--- PASS: TestAccS3Bucket_Security_updateACL (39.80s)
=== CONT  TestAccS3Bucket_Replication_schemaV2
    bucket_test.go:1572: Step 1/6 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
--- FAIL: TestAccS3Bucket_Replication_schemaV2 (1.26s)
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
    bucket_test.go:1535: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
--- FAIL: TestAccS3Bucket_Replication_withoutPrefix (1.27s)
=== CONT  TestAccS3Bucket_Replication_expectVersioningValidationError
    bucket_test.go:1508: Step 1/1, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
--- FAIL: TestAccS3Bucket_Replication_expectVersioningValidationError (1.20s)
=== CONT  TestAccS3Bucket_Replication_withoutStorageClass
    bucket_test.go:1475: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
--- FAIL: TestAccS3Bucket_Replication_withoutStorageClass (1.35s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
    bucket_test.go:1427: Step 1/3 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 37, in data "aws_caller_identity" "current":
          37: data "aws_caller_identity" "current" {}
        
        The provider hashicorp/aws does not support data source
        "aws_caller_identity".
--- FAIL: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (1.29s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
    bucket_test.go:1379: Step 1/3 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 37, in data "aws_caller_identity" "current":
          37: data "aws_caller_identity" "current" {}
        
        The provider hashicorp/aws does not support data source
        "aws_caller_identity".
--- FAIL: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (1.29s)
=== CONT  TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (31.07s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
    bucket_test.go:1250: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
--- FAIL: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (1.33s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
    bucket_test.go:1183: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
--- FAIL: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (6.02s)
=== CONT  TestAccS3Bucket_Replication_basic
    bucket_test.go:1132: Step 1/3 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid data source
        
          on terraform_plugin_test.tf line 6, in data "aws_partition" "current":
           6: data "aws_partition" "current" {}
        
        The provider hashicorp/aws does not support data source "aws_partition".
--- FAIL: TestAccS3Bucket_Replication_basic (1.35s)
=== CONT  TestAccS3Bucket_Basic_requestPayer
--- PASS: TestAccS3Bucket_Security_updateGrant (66.35s)
=== CONT  TestAccS3Bucket_Manage_objectLock_migrate
--- PASS: TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled (25.92s)
=== CONT  TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (31.91s)
=== CONT  TestAccS3Bucket_Manage_objectLock
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (28.08s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRemove
--- PASS: TestAccS3Bucket_Basic_requestPayer (45.97s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (32.05s)
=== CONT  TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
--- PASS: TestAccS3Bucket_Manage_objectLock (44.73s)
=== CONT  TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (43.35s)
=== CONT  TestAccS3Bucket_Manage_lifecycleBasic
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (23.86s)
=== CONT  TestAccS3Bucket_Tags_ignoreTags
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (43.61s)
=== CONT  TestAccS3Bucket_Tags_withSystemTags
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (45.77s)
=== CONT  TestAccS3Bucket_Tags_withNoSystemTags
--- PASS: TestAccS3Bucket_Tags_ignoreTags (42.08s)
=== CONT  TestAccS3Bucket_Tags_basic
--- PASS: TestAccS3Bucket_Tags_basic (26.69s)
--- PASS: TestAccS3Bucket_Duplicate_UsEast1AltAccount (17.22s)
=== CONT  TestAccS3Bucket_Duplicate_UsEast1
--- PASS: TestAccS3Bucket_Duplicate_UsEast1 (11.73s)
=== CONT  TestAccS3Bucket_Duplicate_basic
--- PASS: TestAccS3Bucket_Duplicate_basic (11.84s)
=== CONT  TestAccS3Bucket_disappears
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (82.28s)
=== CONT  TestAccS3Bucket_Basic_basic
--- PASS: TestAccS3Bucket_disappears (16.02s)
=== CONT  TestAccS3Bucket_Basic_keyEnabled
--- PASS: TestAccS3Bucket_Basic_basic (24.15s)
=== CONT  TestAccS3Bucket_Basic_acceleration
--- PASS: TestAccS3Bucket_Basic_keyEnabled (25.95s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Tags_withSystemTags (135.80s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (26.62s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
--- PASS: TestAccS3Bucket_Basic_acceleration (46.81s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (25.66s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Basic_forceDestroy (20.63s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Basic_namePrefix (23.45s)
=== CONT  TestAccS3Bucket_Manage_versioningDisabled
--- PASS: TestAccS3Bucket_Basic_generatedName (24.19s)
=== CONT  TestAccS3Bucket_Manage_MFADeleteDisabled
--- PASS: TestAccS3Bucket_Basic_emptyString (23.58s)
=== CONT  TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (23.76s)
=== CONT  TestAccS3BucketPolicy_migrate_withChange
--- PASS: TestAccS3Bucket_Manage_MFADeleteDisabled (23.76s)
=== CONT  TestAccS3BucketPolicy_migrate_noChange
--- PASS: TestAccS3BucketPolicy_migrate_withChange (35.86s)
=== CONT  TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (65.27s)
=== CONT  TestAccS3Bucket_Manage_versioning
--- PASS: TestAccS3BucketPolicy_migrate_noChange (91.20s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
--- PASS: TestAccS3Bucket_Manage_versioning (44.99s)
=== CONT  TestAccS3BucketPolicy_policyUpdate
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (29.10s)
=== CONT  TestAccS3BucketPolicy_IAMRoleOrder_policyDoc
--- PASS: TestAccS3BucketPolicy_policyUpdate (43.51s)
=== CONT  TestAccS3BucketPolicy_disappears_bucket
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (117.69s)
=== CONT  TestAccS3BucketPolicy_disappears
--- PASS: TestAccS3BucketPolicy_disappears_bucket (16.80s)
--- PASS: TestAccS3BucketPolicy_disappears (21.18s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (62.91s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/s3	785.096s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. labels Jan 12, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 12, 2023
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jan 12, 2023
This was referenced Jan 12, 2023
Closed
Closed
@YakDriver YakDriver merged commit 7c2fbd9 into main Jan 12, 2023
@YakDriver YakDriver deleted the b-s3-policy-diffs branch January 12, 2023 20:01
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
Update CHANGELOG.md for #28855
2cbaaee
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.50.0
1 participant
@YakDriver