Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: eks placement groups - missing config attribute in eks_cluster data source #28924

Merged
merged 6 commits into from
Jan 17, 2023
Merged

BugFix: eks placement groups - missing config attribute in eks_cluster data source #28924

merged 6 commits into from
Jan 17, 2023

Conversation

skyscrapr
Copy link
Contributor

@skyscrapr skyscrapr commented Jan 17, 2023

Description

Add missing config attribute in aws_eks_cluster datasource.

Relations

Relates #28112
Closes #28839

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccEKSClusterDataSource_ PKG=eks       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource_'  -timeout 180m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSClusterDataSource_outpost
--- PASS: TestAccEKSClusterDataSource_basic (768.90s)
--- PASS: TestAccEKSClusterDataSource_outpost (1059.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        1064.292s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 17, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSClusterDataSource_outpost' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSClusterDataSource_outpost -timeout 180m
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== CONT  TestAccEKSClusterDataSource_outpost
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (1.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	7.346s

@ewbankkit
Copy link
Contributor

@skyscrapr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 84c5b41 into hashicorp:main Jan 17, 2023
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 17, 2023
@sharepointoscar
Copy link

@skyscrapr Thanks for the contribution 🎉 👏.

Thank you for fixing this bug so fast @skyscrapr , really appreciate this as it will help me on a demo for a large event! 🚀

Thank you @ewbankkit for looking at the PR and merging it so fast, greatly appreciate our community! 🎉

@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:
3 participants