Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: AWS Glue for Ray is not supported yet #29180

Closed
jrichard8 opened this issue Jan 31, 2023 · 4 comments · Fixed by #32528
Closed

[Enhancement]: AWS Glue for Ray is not supported yet #29180

jrichard8 opened this issue Jan 31, 2023 · 4 comments · Fixed by #32528
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. upstream Addresses functionality related to the cloud provider.

Comments

@jrichard8
Copy link

jrichard8 commented Jan 31, 2023

Description

It appears that currently the aws_glue_job resource does not support the new AWS GLUE for Ray feature,In particular on the selection of worker type. The resource does not support Z.2X worker type when it is required.

╷
│ Error: creating Glue Job: InvalidInputException: Worker type cannot be null and only [Z.2X] worker types are supported for glueray jobs.
│ 
│   with aws_glue_job.exemple,
│   on main.tf line 14, in resource "aws_glue_job" "exemple":
│   14: resource "aws_glue_job" "exemple" {
│ 
╵

But when we try to use Z.2X

╷
│ Error: expected worker_type to be one of [Standard G.1X G.2X G.025X], got Z.2X
│ 
│   with aws_glue_job.exemple,
│   on main.tf line 31, in resource "aws_glue_job" "exemple":
│   31:   worker_type = "Z.2X"
│ 
╵

Could you add support of Z.2X worker type in case of glueray job type.

Affected Resource(s) and/or Data Source(s)

No response

Potential Terraform Configuration

No response

References

Official documentation: https://docs.amazonaws.cn/en_us/glue/latest/dg/ray-using.html

Extract:

--worker-type (WorkerType) – Ray jobs are backed by a new Amazon Graviton-based instance type. This is represented by the value Z.2X. For the Z.2X worker type, each worker maps to 2 DPU (8 vCPU, 64 GB of memory, 128 GB disk), and provides up to 8 Ray workers (one per vCPU) based on the autoscaler.

Would you like to implement a fix?

None

@jrichard8 jrichard8 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jan 31, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/glue Issues and PRs that pertain to the glue service. label Jan 31, 2023
@jrichard8 jrichard8 changed the title [Enhancement]: Implement AWS Glue for Ray [Enhancement]: AWS Glue for Ray is not supported yet Jan 31, 2023
@jrichard8
Copy link
Author

jrichard8 commented Jan 31, 2023

After some research it seems that this limitation comes from the AWS SDK for GO itself.
I opened an issue about that on AWS SDK for GO V2:
aws/aws-sdk#460

@justinretzolk justinretzolk added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 31, 2023
@djleeam
Copy link
Contributor

djleeam commented Jul 16, 2023

@jrichard8 , it appears the AWS Glue SDK should be in a good state for this now. I can pick this up.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants