-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_kms_grant: Retries read until principals return valid ARNs #29245
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKMSGrant_' PKG=kms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 3 -run=TestAccKMSGrant_ -timeout 180m
=== RUN TestAccKMSGrant_basic
=== PAUSE TestAccKMSGrant_basic
=== RUN TestAccKMSGrant_withConstraints
=== PAUSE TestAccKMSGrant_withConstraints
=== RUN TestAccKMSGrant_withRetiringPrincipal
=== PAUSE TestAccKMSGrant_withRetiringPrincipal
=== RUN TestAccKMSGrant_bare
=== PAUSE TestAccKMSGrant_bare
=== RUN TestAccKMSGrant_arn
=== PAUSE TestAccKMSGrant_arn
=== RUN TestAccKMSGrant_asymmetricKey
=== PAUSE TestAccKMSGrant_asymmetricKey
=== RUN TestAccKMSGrant_disappears
=== PAUSE TestAccKMSGrant_disappears
=== CONT TestAccKMSGrant_basic
=== CONT TestAccKMSGrant_arn
=== CONT TestAccKMSGrant_withRetiringPrincipal
--- PASS: TestAccKMSGrant_arn (25.85s)
=== CONT TestAccKMSGrant_disappears
--- PASS: TestAccKMSGrant_withRetiringPrincipal (35.33s)
=== CONT TestAccKMSGrant_bare
--- PASS: TestAccKMSGrant_basic (35.36s)
=== CONT TestAccKMSGrant_withConstraints
--- PASS: TestAccKMSGrant_bare (24.43s)
=== CONT TestAccKMSGrant_asymmetricKey
--- PASS: TestAccKMSGrant_withConstraints (46.16s)
--- PASS: TestAccKMSGrant_asymmetricKey (25.85s)
--- PASS: TestAccKMSGrant_disappears (210.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kms 241.388s
This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
In some cases, there is a race condition with KMS Key Grants where an IAM unique id is returned instead of a valid principal ARN. Retry reading until the principals are valid. Previously, the state would not be updated.
Output from Acceptance Testing