Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudwatch_log_group: Retry PutRetentionPolicyWithContext for IAM eventual consistency #29325

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 9, 2023

Description

Retries the log group's PutRetentionPolicyWithContext API call if an IAM eventual consistency error is returned.

Relations

Closes #27028.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccLogsGroup_' PKG=logs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsGroup_ -timeout 180m
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN   TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN   TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN   TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN   TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN   TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN   TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_kmsKey
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (16.70s)
=== CONT  TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_basic (19.37s)
=== CONT  TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_skipDestroy (14.46s)
=== CONT  TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_disappears (12.73s)
=== CONT  TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroup_namePrefix (17.80s)
=== CONT  TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_kmsKey (50.26s)
=== CONT  TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_nameGenerate (18.55s)
--- PASS: TestAccLogsGroup_tags (43.92s)
--- PASS: TestAccLogsGroup_retentionPolicy (30.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	86.222s

@github-actions github-actions bot added service/logs Issues and PRs that pertain to the logs service. size/XS Managed by automation to categorize the size of a PR. labels Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@ewbankkit ewbankkit added the eventual-consistency Pertains to eventual consistency issues. label Feb 9, 2023
@ewbankkit ewbankkit merged commit 3e79cdb into main Feb 9, 2023
@ewbankkit ewbankkit deleted the b-aws_cloudwatch_log_group-retention-policy-eventual-consistency branch February 9, 2023 18:39
@github-actions github-actions bot added this to the v4.54.0 milestone Feb 9, 2023
github-actions bot pushed a commit that referenced this pull request Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eventual-consistency Pertains to eventual consistency issues. service/logs Issues and PRs that pertain to the logs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_cloudwatch_log_group fails when using retention policies and tag-based IAM
1 participant