Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in dvb_sub_pids and audio_pids assignment #29371

Merged

Conversation

quartercastle
Copy link
Contributor

@quartercastle quartercastle commented Feb 13, 2023

Description

This PR fixes an issue where dvb_sub_pids is assigned to audio_pids and
a typo where audio_pids was misspelled audi_pids.

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccMediaLiveChannel_m2ts_settings PKG=medialive

... WIP (having a resource limit issue at the moment)

dvb_sub_pids is getting assigned audio_pids, this results in aws
returning a 422 responds as the dvb_sub_pids and audio_pids collide.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link

Hey @quartercastle 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/medialive Issues and PRs that pertain to the medialive service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 13, 2023
@quartercastle
Copy link
Contributor Author

quartercastle commented Feb 13, 2023

Hey @quartercastle 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

I can't change this as the organisation i'm contributing from doesn't allow it at the moment.

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Feb 13, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 180m
=== RUN   TestAccMediaLiveChannel_basic
=== PAUSE TestAccMediaLiveChannel_basic
=== RUN   TestAccMediaLiveChannel_m2ts_settings
=== PAUSE TestAccMediaLiveChannel_m2ts_settings
=== RUN   TestAccMediaLiveChannel_audioDescriptions_codecSettings
=== PAUSE TestAccMediaLiveChannel_audioDescriptions_codecSettings
=== RUN   TestAccMediaLiveChannel_hls
=== PAUSE TestAccMediaLiveChannel_hls
=== RUN   TestAccMediaLiveChannel_status
=== PAUSE TestAccMediaLiveChannel_status
=== RUN   TestAccMediaLiveChannel_update
=== PAUSE TestAccMediaLiveChannel_update
=== RUN   TestAccMediaLiveChannel_updateTags
=== PAUSE TestAccMediaLiveChannel_updateTags
=== RUN   TestAccMediaLiveChannel_disappears
=== PAUSE TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_basic
=== CONT  TestAccMediaLiveChannel_status
=== CONT  TestAccMediaLiveChannel_audioDescriptions_codecSettings
=== CONT  TestAccMediaLiveChannel_hls
=== CONT  TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_update
=== CONT  TestAccMediaLiveChannel_updateTags
=== CONT  TestAccMediaLiveChannel_m2ts_settings
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (67.79s)
--- PASS: TestAccMediaLiveChannel_basic (85.38s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (88.59s)
--- PASS: TestAccMediaLiveChannel_disappears (92.48s)
--- PASS: TestAccMediaLiveChannel_updateTags (112.17s)
--- PASS: TestAccMediaLiveChannel_hls (159.02s)
--- PASS: TestAccMediaLiveChannel_update (213.18s)
--- PASS: TestAccMediaLiveChannel_status (267.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  270.477s

@jar-b
Copy link
Member

jar-b commented Feb 13, 2023

@quartercastle - Fixes look great. Since you can't allow edits from your org, can you please include a changelog entry?

.changelog/29371.txt

```release-note:bug
resource/aws_medialive_channel: Fix issue preventing `audio_pids` attribute from being configured in `m2ts_settings`
```

```release-note:bug
resource/aws_medialive_channel: Fix issue causing `dbv_sub_pids` attribute to be configured incorrectly in `m2ts_settings`
```

@jar-b jar-b added the waiting-response Maintainers are waiting on response from community or contributor. label Feb 13, 2023
@quartercastle
Copy link
Contributor Author

@jar-b thanks for the review, i have added the changelog in a9aeda3.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 13, 2023
@jar-b jar-b merged commit de19dd8 into hashicorp:main Feb 13, 2023
@jar-b
Copy link
Member

jar-b commented Feb 13, 2023

Thanks for contribution, @quartercastle! 👍

@github-actions github-actions bot added this to the v4.55.0 milestone Feb 13, 2023
@quartercastle quartercastle deleted the b-fix-dvb_sub_pids-collision-with-audio_pids branch February 14, 2023 08:56
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/medialive Issues and PRs that pertain to the medialive service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants