-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in dvb_sub_pids and audio_pids assignment #29371
Fix typo in dvb_sub_pids and audio_pids assignment #29371
Conversation
dvb_sub_pids is getting assigned audio_pids, this results in aws returning a 422 responds as the dvb_sub_pids and audio_pids collide.
Community NoteVoting for Prioritization
For Submitters
|
Hey @quartercastle 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
I can't change this as the organisation i'm contributing from doesn't allow it at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_' -timeout 180m
=== RUN TestAccMediaLiveChannel_basic
=== PAUSE TestAccMediaLiveChannel_basic
=== RUN TestAccMediaLiveChannel_m2ts_settings
=== PAUSE TestAccMediaLiveChannel_m2ts_settings
=== RUN TestAccMediaLiveChannel_audioDescriptions_codecSettings
=== PAUSE TestAccMediaLiveChannel_audioDescriptions_codecSettings
=== RUN TestAccMediaLiveChannel_hls
=== PAUSE TestAccMediaLiveChannel_hls
=== RUN TestAccMediaLiveChannel_status
=== PAUSE TestAccMediaLiveChannel_status
=== RUN TestAccMediaLiveChannel_update
=== PAUSE TestAccMediaLiveChannel_update
=== RUN TestAccMediaLiveChannel_updateTags
=== PAUSE TestAccMediaLiveChannel_updateTags
=== RUN TestAccMediaLiveChannel_disappears
=== PAUSE TestAccMediaLiveChannel_disappears
=== CONT TestAccMediaLiveChannel_basic
=== CONT TestAccMediaLiveChannel_status
=== CONT TestAccMediaLiveChannel_audioDescriptions_codecSettings
=== CONT TestAccMediaLiveChannel_hls
=== CONT TestAccMediaLiveChannel_disappears
=== CONT TestAccMediaLiveChannel_update
=== CONT TestAccMediaLiveChannel_updateTags
=== CONT TestAccMediaLiveChannel_m2ts_settings
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (67.79s)
--- PASS: TestAccMediaLiveChannel_basic (85.38s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (88.59s)
--- PASS: TestAccMediaLiveChannel_disappears (92.48s)
--- PASS: TestAccMediaLiveChannel_updateTags (112.17s)
--- PASS: TestAccMediaLiveChannel_hls (159.02s)
--- PASS: TestAccMediaLiveChannel_update (213.18s)
--- PASS: TestAccMediaLiveChannel_status (267.46s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 270.477s
@quartercastle - Fixes look great. Since you can't allow edits from your org, can you please include a changelog entry?
|
Thanks for contribution, @quartercastle! 👍 |
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR fixes an issue where
dvb_sub_pids
is assigned toaudio_pids
anda typo where
audio_pids
was misspelledaudi_pids
.Relations
References
Output from Acceptance Testing