Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_lb missing support for additional LoadBalancerAttributes #29684

Closed
phene opened this issue Feb 27, 2023 · 5 comments · Fixed by #29792
Closed

[Enhancement]: aws_lb missing support for additional LoadBalancerAttributes #29684

phene opened this issue Feb 27, 2023 · 5 comments · Fixed by #29792
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@phene
Copy link

phene commented Feb 27, 2023

Description

There are several load balancer attributes described here that are not presently supported by the Terraform resources aws_lb:

  • routing.http.xff_client_port.enabled
  • routing.http.xff_header_processing.mode
  • routing.http.x_amzn_tls_version_and_cipher_suite.enabled

Affected Resource(s) and/or Data Source(s)

  • aws_lb

Potential Terraform Configuration

resource "aws_lb" {
  enable_xff_client_port_header = true
  xff_header_processing = "preserve"
  enable_tls_version_and_cipher_suite_headers = true
}

References

https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_LoadBalancerAttribute.html

Would you like to implement a fix?

No

@phene phene added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Feb 27, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Feb 27, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 6, 2023
@ericrichtert
Copy link
Contributor

See also #22049

@mtt88
Copy link
Contributor

mtt88 commented Mar 6, 2023

I put a PR in for this without realising there was an existing issue and PR open. I'll leave it open for now, but please feel free to close it in favour of the existing.

@github-actions github-actions bot added this to the v4.59.0 milestone Mar 14, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants