Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dms/endpoint: Add s3 setting detachTargetOnLobLookupFailureParquet #29772

Merged
merged 7 commits into from
Mar 3, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 3, 2023

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make t T=TestAccDMSS3Endpoint_ K=dms                                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSS3Endpoint_'  -timeout 180m
=== RUN   TestAccDMSS3Endpoint_basic
=== PAUSE TestAccDMSS3Endpoint_basic
=== RUN   TestAccDMSS3Endpoint_update
=== PAUSE TestAccDMSS3Endpoint_update
=== RUN   TestAccDMSS3Endpoint_simple
=== PAUSE TestAccDMSS3Endpoint_simple
=== RUN   TestAccDMSS3Endpoint_sourceSimple
=== PAUSE TestAccDMSS3Endpoint_sourceSimple
=== RUN   TestAccDMSS3Endpoint_source
=== PAUSE TestAccDMSS3Endpoint_source
=== RUN   TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== CONT  TestAccDMSS3Endpoint_basic
=== CONT  TestAccDMSS3Endpoint_sourceSimple
=== CONT  TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== CONT  TestAccDMSS3Endpoint_simple
=== CONT  TestAccDMSS3Endpoint_source
=== CONT  TestAccDMSS3Endpoint_update
--- PASS: TestAccDMSS3Endpoint_simple (40.04s)
--- PASS: TestAccDMSS3Endpoint_basic (45.59s)
--- PASS: TestAccDMSS3Endpoint_update (52.91s)
--- PASS: TestAccDMSS3Endpoint_sourceSimple (53.25s)
--- PASS: TestAccDMSS3Endpoint_source (55.37s)
--- PASS: TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet (72.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	73.872s
% make t T=TestAccDMSEndpoint_ K=dms                                       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_'  -timeout 180m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_Aurora_basic
=== PAUSE TestAccDMSEndpoint_Aurora_basic
=== RUN   TestAccDMSEndpoint_Aurora_secretID
=== PAUSE TestAccDMSEndpoint_Aurora_secretID
=== RUN   TestAccDMSEndpoint_Aurora_update
=== PAUSE TestAccDMSEndpoint_Aurora_update
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_update
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_update
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
=== RUN   TestAccDMSEndpoint_S3_key
=== PAUSE TestAccDMSEndpoint_S3_key
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyId
=== RUN   TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== RUN   TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN   TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN   TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN   TestAccDMSEndpoint_MongoDB_secretID
=== PAUSE TestAccDMSEndpoint_MongoDB_secretID
=== RUN   TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN   TestAccDMSEndpoint_MariaDB_basic
=== PAUSE TestAccDMSEndpoint_MariaDB_basic
=== RUN   TestAccDMSEndpoint_MariaDB_secretID
=== PAUSE TestAccDMSEndpoint_MariaDB_secretID
=== RUN   TestAccDMSEndpoint_MariaDB_update
=== PAUSE TestAccDMSEndpoint_MariaDB_update
=== RUN   TestAccDMSEndpoint_MySQL_basic
=== PAUSE TestAccDMSEndpoint_MySQL_basic
=== RUN   TestAccDMSEndpoint_MySQL_secretID
=== PAUSE TestAccDMSEndpoint_MySQL_secretID
=== RUN   TestAccDMSEndpoint_MySQL_update
=== PAUSE TestAccDMSEndpoint_MySQL_update
=== RUN   TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN   TestAccDMSEndpoint_Oracle_secretID
=== PAUSE TestAccDMSEndpoint_Oracle_secretID
=== RUN   TestAccDMSEndpoint_Oracle_update
=== PAUSE TestAccDMSEndpoint_Oracle_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN   TestAccDMSEndpoint_SQLServer_basic
=== PAUSE TestAccDMSEndpoint_SQLServer_basic
=== RUN   TestAccDMSEndpoint_SQLServer_secretID
=== PAUSE TestAccDMSEndpoint_SQLServer_secretID
=== RUN   TestAccDMSEndpoint_SQLServer_update
=== PAUSE TestAccDMSEndpoint_SQLServer_update
=== RUN   TestAccDMSEndpoint_SQLServer_kmsKey
=== PAUSE TestAccDMSEndpoint_SQLServer_kmsKey
=== RUN   TestAccDMSEndpoint_Sybase_basic
=== PAUSE TestAccDMSEndpoint_Sybase_basic
=== RUN   TestAccDMSEndpoint_Sybase_secretID
=== PAUSE TestAccDMSEndpoint_Sybase_secretID
=== RUN   TestAccDMSEndpoint_Sybase_update
=== PAUSE TestAccDMSEndpoint_Sybase_update
=== RUN   TestAccDMSEndpoint_Sybase_kmsKey
=== PAUSE TestAccDMSEndpoint_Sybase_kmsKey
=== RUN   TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN   TestAccDMSEndpoint_db2_basic
=== PAUSE TestAccDMSEndpoint_db2_basic
=== RUN   TestAccDMSEndpoint_azureSQLManagedInstance
=== PAUSE TestAccDMSEndpoint_azureSQLManagedInstance
=== RUN   TestAccDMSEndpoint_db2_secretID
=== PAUSE TestAccDMSEndpoint_db2_secretID
=== RUN   TestAccDMSEndpoint_redis
=== PAUSE TestAccDMSEndpoint_redis
=== RUN   TestAccDMSEndpoint_Redshift_basic
=== PAUSE TestAccDMSEndpoint_Redshift_basic
=== RUN   TestAccDMSEndpoint_Redshift_secretID
=== PAUSE TestAccDMSEndpoint_Redshift_secretID
=== RUN   TestAccDMSEndpoint_Redshift_update
=== PAUSE TestAccDMSEndpoint_Redshift_update
=== RUN   TestAccDMSEndpoint_Redshift_kmsKey
=== PAUSE TestAccDMSEndpoint_Redshift_kmsKey
=== RUN   TestAccDMSEndpoint_Redshift_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_Redshift_SSEKMSKeyARN
=== RUN   TestAccDMSEndpoint_Redshift_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_Redshift_SSEKMSKeyId
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_Sybase_update
=== CONT  TestAccDMSEndpoint_Oracle_basic
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
=== CONT  TestAccDMSEndpoint_MySQL_update
=== CONT  TestAccDMSEndpoint_Redshift_basic
=== CONT  TestAccDMSEndpoint_Sybase_secretID
=== CONT  TestAccDMSEndpoint_Sybase_basic
=== CONT  TestAccDMSEndpoint_SQLServer_kmsKey
=== CONT  TestAccDMSEndpoint_SQLServer_update
=== CONT  TestAccDMSEndpoint_SQLServer_secretID
=== CONT  TestAccDMSEndpoint_SQLServer_basic
=== CONT  TestAccDMSEndpoint_PostgreSQL_kmsKey
=== CONT  TestAccDMSEndpoint_PostgreSQL_update
=== CONT  TestAccDMSEndpoint_PostgreSQL_secretID
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
=== CONT  TestAccDMSEndpoint_Oracle_update
=== CONT  TestAccDMSEndpoint_Oracle_secretID
=== CONT  TestAccDMSEndpoint_Redshift_SSEKMSKeyId
=== CONT  TestAccDMSEndpoint_Redshift_SSEKMSKeyARN
--- PASS: TestAccDMSEndpoint_SQLServer_kmsKey (40.25s)
=== CONT  TestAccDMSEndpoint_Redshift_kmsKey
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (41.08s)
=== CONT  TestAccDMSEndpoint_Redshift_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (51.08s)
=== CONT  TestAccDMSEndpoint_Redshift_secretID
--- PASS: TestAccDMSEndpoint_Oracle_basic (51.28s)
=== CONT  TestAccDMSEndpoint_MongoDB_secretID
--- PASS: TestAccDMSEndpoint_Sybase_secretID (52.90s)
=== CONT  TestAccDMSEndpoint_MySQL_secretID
--- PASS: TestAccDMSEndpoint_Oracle_secretID (54.65s)
=== CONT  TestAccDMSEndpoint_MySQL_basic
--- PASS: TestAccDMSEndpoint_SQLServer_secretID (54.74s)
=== CONT  TestAccDMSEndpoint_MariaDB_update
--- PASS: TestAccDMSEndpoint_SQLServer_basic (56.69s)
=== CONT  TestAccDMSEndpoint_MariaDB_secretID
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (57.02s)
=== CONT  TestAccDMSEndpoint_MariaDB_basic
--- PASS: TestAccDMSEndpoint_Sybase_basic (57.53s)
=== CONT  TestAccDMSEndpoint_MongoDB_update
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (65.70s)
=== CONT  TestAccDMSEndpoint_kafka
--- PASS: TestAccDMSEndpoint_Oracle_update (75.18s)
=== CONT  TestAccDMSEndpoint_MongoDB_basic
--- PASS: TestAccDMSEndpoint_Sybase_update (76.90s)
=== CONT  TestAccDMSEndpoint_kinesis
--- PASS: TestAccDMSEndpoint_basic (77.92s)
=== CONT  TestAccDMSEndpoint_redis
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (78.06s)
=== CONT  TestAccDMSEndpoint_db2_secretID
--- PASS: TestAccDMSEndpoint_SQLServer_update (78.70s)
=== CONT  TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_MySQL_update (78.73s)
=== CONT  TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_Redshift_secretID (35.45s)
=== CONT  TestAccDMSEndpoint_docDB
--- PASS: TestAccDMSEndpoint_MongoDB_secretID (37.12s)
=== CONT  TestAccDMSEndpoint_db2_basic
--- PASS: TestAccDMSEndpoint_MariaDB_secretID (41.21s)
=== CONT  TestAccDMSEndpoint_azureSQLManagedInstance
--- PASS: TestAccDMSEndpoint_MySQL_basic (45.28s)
=== CONT  TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_MariaDB_basic (44.16s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_MySQL_secretID (48.54s)
=== CONT  TestAccDMSEndpoint_dynamoDB
--- PASS: TestAccDMSEndpoint_MariaDB_update (55.37s)
=== CONT  TestAccDMSEndpoint_Sybase_kmsKey
--- PASS: TestAccDMSEndpoint_MongoDB_basic (45.89s)
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyId
--- PASS: TestAccDMSEndpoint_kafka (55.73s)
=== CONT  TestAccDMSEndpoint_Aurora_secretID
--- PASS: TestAccDMSEndpoint_MongoDB_update (67.73s)
=== CONT  TestAccDMSEndpoint_Aurora_update
--- PASS: TestAccDMSEndpoint_db2_secretID (47.47s)
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyARN
--- PASS: TestAccDMSEndpoint_redis (51.87s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_update
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (55.62s)
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (55.98s)
=== CONT  TestAccDMSEndpoint_S3_key
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (44.11s)
=== CONT  TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
--- PASS: TestAccDMSEndpoint_docDB (60.53s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_basic
--- PASS: TestAccDMSEndpoint_db2_basic (59.42s)
=== CONT  TestAccDMSEndpoint_Aurora_basic
--- PASS: TestAccDMSEndpoint_S3_key (13.19s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_Sybase_kmsKey (38.71s)
--- PASS: TestAccDMSEndpoint_azureSQLManagedInstance (54.77s)
--- PASS: TestAccDMSEndpoint_kinesis (87.04s)
--- PASS: TestAccDMSEndpoint_Aurora_secretID (47.12s)
--- PASS: TestAccDMSEndpoint_dynamoDB (87.06s)
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_basic (42.14s)
--- PASS: TestAccDMSEndpoint_Aurora_basic (41.81s)
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_update (60.33s)
--- PASS: TestAccDMSEndpoint_S3_basic (89.21s)
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_secretID (43.90s)
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyARN (66.59s)
--- PASS: TestAccDMSEndpoint_Aurora_update (72.24s)
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyId (77.50s)
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (90.97s)
--- PASS: TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet (89.07s)
--- PASS: TestAccDMSEndpoint_Redshift_SSEKMSKeyARN (255.76s)
--- PASS: TestAccDMSEndpoint_Redshift_SSEKMSKeyId (257.23s)
--- PASS: TestAccDMSEndpoint_Redshift_basic (294.02s)
--- PASS: TestAccDMSEndpoint_Redshift_kmsKey (263.84s)
--- PASS: TestAccDMSEndpoint_Redshift_update (282.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	325.067s

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/dms Issues and PRs that pertain to the dms service. labels Mar 3, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 3, 2023
@YakDriver YakDriver force-pushed the f-add-detach-target-on-lob-lookup-failure-parquet branch from 0253808 to f29ec36 Compare March 3, 2023 03:43
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 3, 2023
@YakDriver YakDriver merged commit bcfe125 into main Mar 3, 2023
@YakDriver YakDriver deleted the f-add-detach-target-on-lob-lookup-failure-parquet branch March 3, 2023 04:20
@github-actions github-actions bot added this to the v4.57.0 milestone Mar 3, 2023
github-actions bot pushed a commit that referenced this pull request Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant