-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: aws_ecs_task_execution
#29783
Conversation
Community NoteVoting for Prioritization
For Submitters
|
352cbb6
to
03f166a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSTaskExecutionDataSource_' PKG=ecs ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 1 -run=TestAccECSTaskExecutionDataSource_ -timeout 180m
=== RUN TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== CONT TestAccECSTaskExecutionDataSource_basic
--- PASS: TestAccECSTaskExecutionDataSource_basic (287.35s)
=== CONT TestAccECSTaskExecutionDataSource_tags
--- PASS: TestAccECSTaskExecutionDataSource_tags (321.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 615.013s
Thanks for the addition! A question around the execution during a plan, or any read operation. How difficult would it be to implement something similar to the |
Or, instead of adding a |
can move the convo over to new issue since this thread will get locked tomorrow once the new release goes out |
This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The
aws_ecs_task_execution
data source will enable use cases when a one-time task needs to run on an existing ECS cluster.As this data source wraps the
RunTask
API, it will provision tasks on every read operation where the input attributes are known. This may includeterraform plan
commands, and should be used with caution for any tasks that cannot safely run multiple instances in parallel.Relations
Adapted from #12096
Closes #1703
References
This data source was modeled after
aws_lambda_function_invocation
.Output from Acceptance Testing