Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 AWS Route now Support IPv6 Destinations with VPC Endpoints as Targets #29994

Conversation

cmccabe-ws
Copy link
Contributor

@cmccabe-ws cmccabe-ws commented Mar 14, 2023

Description

🐛 AWS Route now Support IPv6 Destinations with VPC Endpoints as Targets

Specifically, AWS Network Firewall now supports IPv6 traffic, and in order to route IPv6 traffic there, you need to point the IPv6 destination at the VPC endpoint ID of the network firewall.

Currently this conflict prevents you from doing so in Terraform.

Relations

Closes #29873

Output from Acceptance Testing

Added new acceptance test, however I cannot run myself, can someone please run for me?

$ make testacc TESTS= TestAccVPCRoute_ipv6ToVPCEndpoint PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2023
@cmccabe-ws
Copy link
Contributor Author

I could not run the acceptance test, but I did override my local provider configuration and ran an apply which was successful.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 14, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCRoute_ipv6ToVPCEndpoint\|TestAccVPCRoute_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCRoute_ipv6ToVPCEndpoint\|TestAccVPCRoute_basic -timeout 180m
=== RUN   TestAccVPCRoute_basic
=== PAUSE TestAccVPCRoute_basic
=== RUN   TestAccVPCRoute_ipv6ToVPCEndpoint
=== PAUSE TestAccVPCRoute_ipv6ToVPCEndpoint
=== CONT  TestAccVPCRoute_basic
=== CONT  TestAccVPCRoute_ipv6ToVPCEndpoint
--- PASS: TestAccVPCRoute_basic (23.09s)
--- PASS: TestAccVPCRoute_ipv6ToVPCEndpoint (435.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	440.648s

@ewbankkit
Copy link
Contributor

@cmccabe-ws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 32b5b87 into hashicorp:main Mar 14, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 14, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AWS Route IPV6 Destination does not support Target of VPC Endpoint ID
2 participants