-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 AWS Route now Support IPv6 Destinations with VPC Endpoints as Targets #29994
🐛 AWS Route now Support IPv6 Destinations with VPC Endpoints as Targets #29994
Conversation
Community NoteVoting for Prioritization
For Submitters
|
I could not run the acceptance test, but I did override my local provider configuration and ran an apply which was successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCRoute_ipv6ToVPCEndpoint\|TestAccVPCRoute_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCRoute_ipv6ToVPCEndpoint\|TestAccVPCRoute_basic -timeout 180m
=== RUN TestAccVPCRoute_basic
=== PAUSE TestAccVPCRoute_basic
=== RUN TestAccVPCRoute_ipv6ToVPCEndpoint
=== PAUSE TestAccVPCRoute_ipv6ToVPCEndpoint
=== CONT TestAccVPCRoute_basic
=== CONT TestAccVPCRoute_ipv6ToVPCEndpoint
--- PASS: TestAccVPCRoute_basic (23.09s)
--- PASS: TestAccVPCRoute_ipv6ToVPCEndpoint (435.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 440.648s
@cmccabe-ws Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
🐛 AWS Route now Support IPv6 Destinations with VPC Endpoints as Targets
Specifically, AWS Network Firewall now supports IPv6 traffic, and in order to route IPv6 traffic there, you need to point the IPv6 destination at the VPC endpoint ID of the network firewall.
Currently this conflict prevents you from doing so in Terraform.
Relations
Closes #29873
Output from Acceptance Testing
Added new acceptance test, however I cannot run myself, can someone please run for me?