Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS Data Protection Policy #30008

Merged
merged 19 commits into from
Mar 27, 2023
Merged

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Mar 14, 2023

Description

Adds a new SNS resource: aws_sns_topic_data_protection_policy

Relations

Closes #29966

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSNSTopicDataProtectionPolicy_ PKG=sns                                                                             (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicDataProtectionPolicy_'  -timeout 180m
=== RUN   TestAccSNSTopicDataProtectionPolicy_basic
=== PAUSE TestAccSNSTopicDataProtectionPolicy_basic
=== RUN   TestAccSNSTopicDataProtectionPolicy_disappears
=== PAUSE TestAccSNSTopicDataProtectionPolicy_disappears
=== CONT  TestAccSNSTopicDataProtectionPolicy_basic
=== CONT  TestAccSNSTopicDataProtectionPolicy_disappears
--- PASS: TestAccSNSTopicDataProtectionPolicy_disappears (23.86s)
--- PASS: TestAccSNSTopicDataProtectionPolicy_basic (26.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        26.699s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/sns Issues and PRs that pertain to the sns service. labels Mar 14, 2023
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. generators Relates to code generators. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 24, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 24, 2023
@bschaatsbergen bschaatsbergen changed the title [WIP] - SNS Data Protection Policy SNS Data Protection Policy Mar 24, 2023
@bschaatsbergen bschaatsbergen marked this pull request as ready for review March 24, 2023 22:59
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 27, 2023
@ewbankkit
Copy link
Contributor

@bschaatsbergen Please add a CHANGELOG entry.

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Mar 27, 2023
@bschaatsbergen
Copy link
Member Author

@bschaatsbergen Please add a CHANGELOG entry.

Woops, fixed

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSNSTopicDataProtectionPolicy_' PKG=sns ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 2  -run=TestAccSNSTopicDataProtectionPolicy_ -timeout 180m
=== RUN   TestAccSNSTopicDataProtectionPolicy_basic
=== PAUSE TestAccSNSTopicDataProtectionPolicy_basic
=== RUN   TestAccSNSTopicDataProtectionPolicy_disappears
=== PAUSE TestAccSNSTopicDataProtectionPolicy_disappears
=== CONT  TestAccSNSTopicDataProtectionPolicy_basic
=== CONT  TestAccSNSTopicDataProtectionPolicy_disappears
--- PASS: TestAccSNSTopicDataProtectionPolicy_disappears (16.40s)
--- PASS: TestAccSNSTopicDataProtectionPolicy_basic (18.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	23.765s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b6370cc into hashicorp:main Mar 27, 2023
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 27, 2023
@bschaatsbergen bschaatsbergen deleted the sns-deletion-policy branch March 27, 2023 14:57
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/sns Issues and PRs that pertain to the sns service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for data protection policy in SNS topic
2 participants