-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: aws_sagemaker_data_quality_job_definition
#30301
new resource: aws_sagemaker_data_quality_job_definition
#30301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @wrbooth 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hi wrbooth, please split this PR to a resource per PR (as contribution guide suggests) |
aws_sagemaker_monitoring_schedule
and aws_sagemaker_data_quality_job_definition
aws_sagemaker_data_quality_job_definition
Very sorry about that! I've removed |
…d by blank lines'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMakerDataQualityJobDefinition_' PKG=sagemaker ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 3 -run=TestAccSageMakerDataQualityJobDefinition_ -timeout 180m
=== RUN TestAccSageMakerDataQualityJobDefinition_endpoint
=== PAUSE TestAccSageMakerDataQualityJobDefinition_endpoint
=== RUN TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
=== RUN TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== PAUSE TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== RUN TestAccSageMakerDataQualityJobDefinition_batchTransform
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransform
=== RUN TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader
=== RUN TestAccSageMakerDataQualityJobDefinition_batchTransformJSON
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformJSON
=== RUN TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine
=== RUN TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== RUN TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== RUN TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== PAUSE TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== RUN TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== RUN TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== PAUSE TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== RUN TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== PAUSE TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== RUN TestAccSageMakerDataQualityJobDefinition_networkConfig
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfig
=== RUN TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== RUN TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== RUN TestAccSageMakerDataQualityJobDefinition_tags
=== PAUSE TestAccSageMakerDataQualityJobDefinition_tags
=== RUN TestAccSageMakerDataQualityJobDefinition_disappears
=== PAUSE TestAccSageMakerDataQualityJobDefinition_disappears
=== CONT TestAccSageMakerDataQualityJobDefinition_endpoint
=== CONT TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== CONT TestAccSageMakerDataQualityJobDefinition_batchTransformJSON
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformJSON (25.91s)
=== CONT TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
--- PASS: TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId (28.42s)
=== CONT TestAccSageMakerDataQualityJobDefinition_disappears
--- PASS: TestAccSageMakerDataQualityJobDefinition_disappears (21.89s)
=== CONT TestAccSageMakerDataQualityJobDefinition_tags
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption (27.99s)
=== CONT TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation (26.35s)
=== CONT TestAccSageMakerDataQualityJobDefinition_batchTransform
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransform (23.30s)
=== CONT TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader
--- PASS: TestAccSageMakerDataQualityJobDefinition_tags (55.71s)
=== CONT TestAccSageMakerDataQualityJobDefinition_baselineConfig
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader (24.26s)
=== CONT TestAccSageMakerDataQualityJobDefinition_stoppingCondition
--- PASS: TestAccSageMakerDataQualityJobDefinition_baselineConfig (24.32s)
=== CONT TestAccSageMakerDataQualityJobDefinition_networkConfig
--- PASS: TestAccSageMakerDataQualityJobDefinition_stoppingCondition (22.95s)
=== CONT TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfig (26.39s)
=== CONT TestAccSageMakerDataQualityJobDefinition_endpointOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformOptional (29.03s)
=== CONT TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
--- PASS: TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId (30.52s)
=== CONT TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine
--- PASS: TestAccSageMakerDataQualityJobDefinition_endpoint (231.40s)
=== CONT TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine (46.74s)
=== CONT TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_outputConfigOptional (62.26s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional (52.44s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_endpointOptional (354.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 516.677s
@wrbooth Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a new resource:
aws_sagemaker_data_quality_job_definition
: A definition of a job that monitors data quality and drift for sagemaker endpoints or batch transforms.Adds
sagemaker-model-monitor-analyzer
toaws_sagemaker_prebuilt_ecr_image
data source.Relations
Relates #29768.
References
CreateDataQualityJobDefinition Documentation
Output from Acceptance Testing