-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default tags: zero value, duplicate, and computed tags #30793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
4e12a98
to
7df63f4
Compare
ewbankkit
reviewed
Apr 18, 2023
ewbankkit
reviewed
Apr 18, 2023
c2130ad
to
4407d76
Compare
8605329
to
fa35b24
Compare
21863bd
to
025ed97
Compare
6fd8ff0
to
394de93
Compare
This was referenced May 23, 2023
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
provider
Pertains to the provider itself, rather than any interaction with AWS.
service/vpc
Issues and PRs that pertain to the vpc service.
size/XL
Managed by automation to categorize the size of a PR.
tags
Pertains to resource tagging.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
verify
Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
tags
anddefault_tags
to do the following using SDKv2.tags
anddefault_tags
. Default tags can be overwritten by resource tags.""
tags in bothtags
anddefault_tags
Computed
tags.Relations
Relates #29747
Relates #29842
Relates #24449
References
Output from Acceptance Testing