Bugfix: aws_ssm_activation Fails on nonexistent role

[brittandeyoung]

Description

This pull request accomplishes the following:

1. Updates the tests for aws_ssm_activation to properly test the iam_role field by separating out the resource name and the iam role name.
2. Updates the IamRole in the CreateActivationInput to use the proper schema field.

I made sure that the tests were failing before the update to code and are now passing with the correct field being passed.

Relations

Closes #30441

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccSSMActivation' PKG=ssm 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSMActivation -timeout 180m
=== RUN   TestAccSSMActivation_basic
=== PAUSE TestAccSSMActivation_basic
=== RUN   TestAccSSMActivation_tags
=== PAUSE TestAccSSMActivation_tags
=== RUN   TestAccSSMActivation_expirationDate
=== PAUSE TestAccSSMActivation_expirationDate
=== RUN   TestAccSSMActivation_disappears
=== PAUSE TestAccSSMActivation_disappears
=== CONT  TestAccSSMActivation_basic
=== CONT  TestAccSSMActivation_expirationDate
=== CONT  TestAccSSMActivation_disappears
=== CONT  TestAccSSMActivation_tags
--- PASS: TestAccSSMActivation_disappears (22.92s)
--- PASS: TestAccSSMActivation_expirationDate (25.55s)
--- PASS: TestAccSSMActivation_tags (33.43s)
--- PASS: TestAccSSMActivation_basic (33.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        36.971s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMActivation_' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2  -run=TestAccSSMActivation_ -timeout 180m
=== RUN   TestAccSSMActivation_basic
=== PAUSE TestAccSSMActivation_basic
=== RUN   TestAccSSMActivation_tags
=== PAUSE TestAccSSMActivation_tags
=== RUN   TestAccSSMActivation_expirationDate
=== PAUSE TestAccSSMActivation_expirationDate
=== RUN   TestAccSSMActivation_disappears
=== PAUSE TestAccSSMActivation_disappears
=== CONT  TestAccSSMActivation_basic
=== CONT  TestAccSSMActivation_expirationDate
--- PASS: TestAccSSMActivation_expirationDate (27.27s)
=== CONT  TestAccSSMActivation_tags
--- PASS: TestAccSSMActivation_basic (27.35s)
=== CONT  TestAccSSMActivation_disappears
--- PASS: TestAccSSMActivation_disappears (22.23s)
--- PASS: TestAccSSMActivation_tags (33.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	66.192s

[ewbankkit]

@brittandeyoung Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.