-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EBS Volumes as Target Resource for FIS experiment templates #31499
Add EBS Volumes as Target Resource for FIS experiment templates #31499
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @frank-dall 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccFISExperimentTemplate_' PKG=fis ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 2 -run=TestAccFISExperimentTemplate_ -timeout 180m
=== RUN TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== RUN TestAccFISExperimentTemplate_disappears
=== PAUSE TestAccFISExperimentTemplate_disappears
=== RUN TestAccFISExperimentTemplate_update
=== PAUSE TestAccFISExperimentTemplate_update
=== RUN TestAccFISExperimentTemplate_spot
=== PAUSE TestAccFISExperimentTemplate_spot
=== RUN TestAccFISExperimentTemplate_eks
=== PAUSE TestAccFISExperimentTemplate_eks
=== RUN TestAccFISExperimentTemplate_ebs
=== PAUSE TestAccFISExperimentTemplate_ebs
=== CONT TestAccFISExperimentTemplate_basic
=== CONT TestAccFISExperimentTemplate_spot
--- PASS: TestAccFISExperimentTemplate_spot (18.00s)
=== CONT TestAccFISExperimentTemplate_ebs
--- PASS: TestAccFISExperimentTemplate_basic (21.10s)
=== CONT TestAccFISExperimentTemplate_eks
--- PASS: TestAccFISExperimentTemplate_ebs (38.82s)
=== CONT TestAccFISExperimentTemplate_update
--- PASS: TestAccFISExperimentTemplate_update (32.27s)
=== CONT TestAccFISExperimentTemplate_disappears
--- PASS: TestAccFISExperimentTemplate_disappears (15.24s)
--- PASS: TestAccFISExperimentTemplate_eks (712.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fis 738.579s
@frank-dall Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds EBS volumes as a target resource type for FIS experiment templates.
Relations
Closes #31470
References
https://docs.aws.amazon.com/fis/latest/userguide/fis-actions-reference.html#ebs-actions-reference
Output from Acceptance Testing