-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuickSight: Use correct enums for template filters #32822
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇 - nice find!
$ make testacc PKG=quicksight TESTS=TestAccQuickSightAnalysis_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightAnalysis_disappears (48.40s)
--- PASS: TestAccQuickSightAnalysis_forceDelete (48.91s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (53.26s)
--- PASS: TestAccQuickSightAnalysis_basic (53.50s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (69.86s)
--- PASS: TestAccQuickSightAnalysis_update (92.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 96.164s
$ make testacc PKG=quicksight TESTS=TestAccQuickSightTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightTemplate_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightTemplate_disappears (43.84s)
--- PASS: TestAccQuickSightTemplate_barChart (47.43s)
--- PASS: TestAccQuickSightTemplate_basic (47.83s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (50.49s)
--- PASS: TestAccQuickSightTemplate_table (75.61s)
--- PASS: TestAccQuickSightTemplate_update (81.55s)
--- PASS: TestAccQuickSightTemplate_tags (101.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 104.860s
This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR corrects an issue with QuickSight resources that led to the incorrect function being used to return the list of valid values for
select_all_options
.Relations
Closes #32353
References
These references point to the AWS Go SDK type definition for each of the affected filter types
CustomFilterConfiguration
(category_filter.configuration.custom_filter_configuration
)CustomFilterListConfiguration
(category_filter.configuration.custom_filter_list_configuration
)FilterListConfiguration
(category_filter.configuration.filter_list_configuration
)NumericEqualityFilter
(numeric_equality_filter
)NumericRangeFilter
(numeric_range_filter
)Enums are defined in this file (sorry, it's too big for GitHub to render, so raw link will have to suffice).
Output from Acceptance Testing
Unfortunately I'm not able to run QuickSight acceptance tests.