-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated aws_dms_endpoint.engine_name possible values w/ redshift-serverless #33316
Updated aws_dms_endpoint.engine_name possible values w/ redshift-serverless #33316
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mmccarthy404 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=^TestAccDMSEndpoint_basic$$' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run=^TestAccDMSEndpoint_basic$ -timeout 180m
=== RUN TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== CONT TestAccDMSEndpoint_basic
--- PASS: TestAccDMSEndpoint_basic (91.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 97.691s
@mmccarthy404 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
AWS DMS currently supports creating endpoint targets for Redshift Serverless w/ the engine name
redshift-serverless
as seen below:This pull requests enables
redshift-serverless
as an available option when creating AWS DMS endpoint resources, and the below MvP will successfully deploy an AWS DMS endpoint based on the AWS whitepaper documentation here.I based this implementation off of the previous one done for Aurora Serverless here: #21174
Because the Aurora Serverless implementation isn't included in the documentation or tests, I left these out to fit the convention, but please let me know if these should be included! 😄
Closes #33075.