[Bug]: regression in regexp validation

[dim13]

Terraform Core Version

1.5.7

AWS Provider Version

5.16.0

Affected Resource(s)

• aws_service_discovery_instance
• maybe more

Expected Behavior

Functional as in v5.15.0

Actual Behavior

Broken as in v5.16.0

Relevant Error/Panic Output Snippet

│ Error: Invalid map key
│
│   with module.database.aws_service_discovery_instance.database,
│   on mod/database/main.tf line 45, in resource "aws_service_discovery_instance" "database":
│   45:     AWS_INSTANCE_CNAME = aws_db_instance.database.address
│
│ Map key expected to match regular expression "^[0-9A-Za-z!~-]+$": AWS_INSTANCE_CNAME
╵
╷
│ Error: Invalid map value
│
│   with module.database.aws_service_discovery_instance.database,
│   on mod/database/main.tf line 45, in resource "aws_service_discovery_instance" "database":
│   45:     AWS_INSTANCE_CNAME = aws_db_instance.database.address
│
│ Map value expected to match regular expression "^([0-9A-Za-z!~-][0-9A-Za-z \\t!~-]*){0,1}[0-9A-Za-z!~-]{0,1}$": AWS_INSTANCE_CNAME =>
│ stage.hidden.eu-central-1.rds.amazonaws.com

Terraform Configuration Files

resource "aws_service_discovery_instance" "database" {
  instance_id = aws_db_instance.database.id
  service_id  = aws_service_discovery_service.database.id
  attributes = {
    AWS_INSTANCE_CNAME = aws_db_instance.database.address
  }
}

Steps to Reproduce

Downgrade module to v5.15.0 -- works. Update to v5.16.0 -- broken.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

Possible cause or point of interest: 8963cdd

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[ewbankkit]

Relates #33359.

[ewbankkit]

From the AWS Cloud Map API Reference:

Type: String to string map
Key Length Constraints: Maximum length of 255.
Key Pattern: ^[a-zA-Z0-9!-~]+$
Value Length Constraints: Maximum length of 1024.
Value Pattern: ^([a-zA-Z0-9!-~][ \ta-zA-Z0-9!-~]*){0,1}[a-zA-Z0-9!-~]{0,1}$

[ewbankkit]

% make testacc TESTARGS='-run=TestAccServiceDiscoveryInstance_private' PKG=servicediscovery
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 20  -run=TestAccServiceDiscoveryInstance_private -timeout 180m
=== RUN   TestAccServiceDiscoveryInstance_private
=== PAUSE TestAccServiceDiscoveryInstance_private
=== CONT  TestAccServiceDiscoveryInstance_private
    instance_test.go:27: Step 1/3 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid map key
        
          with aws_service_discovery_instance.test,
          on terraform_plugin_test.tf line 40, in resource "aws_service_discovery_instance" "test":
          40:     AWS_INSTANCE_IPV4 = "10.0.0.1" 
        
        Map key expected to match regular expression "^[0-9A-Za-z!~-]+$":
        AWS_INSTANCE_IPV4
        
        Error: Invalid map value
        
          with aws_service_discovery_instance.test,
          on terraform_plugin_test.tf line 40, in resource "aws_service_discovery_instance" "test":
          40:     AWS_INSTANCE_IPV4 = "10.0.0.1" 
        
        Map value expected to match regular expression "^([0-9A-Za-z!~-][0-9A-Za-z
        \\t!~-]*){0,1}[0-9A-Za-z!~-]{0,1}$": AWS_INSTANCE_IPV4 => 10.0.0.1
        
        Error: Invalid map key
        
          with aws_service_discovery_instance.test,
          on terraform_plugin_test.tf line 41, in resource "aws_service_discovery_instance" "test":
          41:     AWS_INSTANCE_IPV6 = "2001:0db8:85a3:0000:0000:abcd:0001:2345"
        
        Map key expected to match regular expression "^[0-9A-Za-z!~-]+$":
        AWS_INSTANCE_IPV6
        
        Error: Invalid map value
        
          with aws_service_discovery_instance.test,
          on terraform_plugin_test.tf line 41, in resource "aws_service_discovery_instance" "test":
          41:     AWS_INSTANCE_IPV6 = "2001:0db8:85a3:0000:0000:abcd:0001:2345"
        
        Map value expected to match regular expression "^([0-9A-Za-z!~-][0-9A-Za-z
        \\t!~-]*){0,1}[0-9A-Za-z!~-]{0,1}$": AWS_INSTANCE_IPV6 =>
        2001:0db8:85a3:0000:0000:abcd:0001:2345
--- FAIL: TestAccServiceDiscoveryInstance_private (2.67s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	7.723s
FAIL
make: *** [testacc] Error 1

[dim13]

Thanks! Works.

[github-actions]

This functionality has been released in v5.16.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.