Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add resource_sets to aws_fms_policy #33372

Closed
marcosentino opened this issue Sep 8, 2023 · 5 comments · Fixed by #38161
Closed

[Enhancement]: Add resource_sets to aws_fms_policy #33372

marcosentino opened this issue Sep 8, 2023 · 5 comments · Fixed by #38161
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service.
Milestone

Comments

@marcosentino
Copy link
Contributor

Description

Provide the user the ability to use Terraform to create AWS Firewall Manager resource sets. Currently, they are not able to use AWS Firewall Manager effectively to manage policies via Terraform. To do so, the "resource_sets" attribute needs to be added to the "aws_fms_policy" resource to facilitate firewall policy management within AWS Firewall Manager.

Affected Resource(s) and/or Data Source(s)

aws_fms_policy

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

None

@marcosentino marcosentino added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jar-b jar-b added the service/fms Issues and PRs that pertain to the fms service. label Dec 14, 2023
@stumyp
Copy link

stumyp commented Dec 20, 2023

For full support of resource sets we need to be able to create them in Terraform as well, not just reference.

#35000

@nam054 nam054 self-assigned this Jun 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 24, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.58.0 milestone Jul 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants